From: John Garry <john.g.garry@oracle.com>
To: Vasant Hegde <vasant.hegde@amd.com>,
Robin Murphy <robin.murphy@arm.com>,
joro@8bytes.org
Cc: will@kernel.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v4] iommu: Optimise PCI SAC address trick
Date: Tue, 18 Apr 2023 11:19:50 +0100 [thread overview]
Message-ID: <6b14b2a0-cf1c-fbfb-5028-d7a6974ef39f@oracle.com> (raw)
In-Reply-To: <21e49cd7-ee15-5ebd-7805-37d5f347635f@amd.com>
On 18/04/2023 10:23, Vasant Hegde wrote:
> [ 172.017120] nvme 0000:41:00.0: Using 64-bit DMA addresses
> [ 172.022955] nvme 0000:41:00.0: Using 64-bit DMA addresses
> [ 172.028720] nvme 0000:41:00.0: Using 64-bit DMA addresses
> [ 172.031815] nvme 0000:41:00.0: Using 64-bit DMA addresses
> [ 172.031816] nvme 0000:41:00.0: Using 64-bit DMA addresses
> [ 172.038727] nvme 0000:41:00.0: Using 64-bit DMA addresses
> [ 172.038726] nvme 0000:41:00.0: Using 64-bit DMA addresses
> [ 172.038917] nvme 0000:41:00.0: Using 64-bit DMA addresses
> [ 172.038968] nvme 0000:41:00.0: Using 64-bit DMA addresses
> [ 172.038970] nvme 0000:41:00.0: Using 64-bit DMA addresses
> [ 172.039007] nvme 0000:41:00.0: Using 64-bit DMA addresses
> [ 172.039091] nvme 0000:41:00.0: Using 64-bit DMA addresses
> [ 172.039102] nvme 0000:41:00.0: Using 64-bit DMA addresses
>
> Otherwise patch worked fine for us.
Hi Vasant,
JFYI, Since you are using NVMe, you could also alternatively try
something like which I did for some SCSI storage controller drivers to
limit the request_queue max_sectors soft limit, like:
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index c2730b116dc6..0a99c9a629c9 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1814,6 +1814,8 @@ static void nvme_set_queue_limits(struct nvme_ctrl
*ctrl,
max_segments = min_not_zero(max_segments, ctrl->max_segments);
blk_queue_max_hw_sectors(q, ctrl->max_hw_sectors);
q->limits.max_sectors = min(q->limits.max_hw_sectors,
+ (unsigned int)dma_opt_mapping_size(ctrl->dev));
blk_queue_max_segments(q, min_t(u32, max_segments, USHRT_MAX));
}
blk_queue_virt_boundary(q, NVME_CTRL_PAGE_SIZE - 1);
lines 1-25/25 (END)
dma_opt_mapping_size() will return the max IOVA caching size for iommu
dma ops, so this would mean that we avoid alloc'ing and free'ing IOVAs
at such a high rate (which I assume was your problem).
Thanks,
John
next prev parent reply other threads:[~2023-04-18 10:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 13:40 Robin Murphy
2023-04-13 14:02 ` Jakub Kicinski
2023-04-14 11:45 ` Joerg Roedel
2023-04-14 17:45 ` Robin Murphy
2023-05-23 16:06 ` Joerg Roedel
2023-05-24 14:56 ` Robin Murphy
2023-06-13 17:58 ` Jakub Kicinski
2023-06-15 7:49 ` John Garry
2023-06-15 9:04 ` Robin Murphy
2023-06-15 10:11 ` John Garry
2023-06-15 11:41 ` Robin Murphy
2023-06-15 12:15 ` John Garry
2023-04-18 9:23 ` Vasant Hegde
2023-04-18 10:19 ` John Garry [this message]
2023-04-18 17:36 ` Linus Torvalds
2023-04-18 18:50 ` John Garry
2023-04-18 10:57 ` Robin Murphy
2023-04-18 13:05 ` Vasant Hegde
2023-07-14 14:09 ` Joerg Roedel
2023-07-17 9:24 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b14b2a0-cf1c-fbfb-5028-d7a6974ef39f@oracle.com \
--to=john.g.garry@oracle.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=torvalds@linux-foundation.org \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®