From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757502AbcHYKaU (ORCPT ); Thu, 25 Aug 2016 06:30:20 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:15057 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbcHYKaT (ORCPT ); Thu, 25 Aug 2016 06:30:19 -0400 X-AuditID: cbfec7f4-f79cb6d000001359-84-57bec6217771 Subject: Re: [alsa-devel] [RFC PATCH] mfd: arizona: Add gating of external MCLKn clocks To: Charles Keepax References: <1471627036-19465-1-git-send-email-s.nawrocki@samsung.com> <20160822092233.GN21682@localhost.localdomain> <20160823162825.GO21682@localhost.localdomain> Cc: broonie@kernel.org, alsa-devel@alsa-project.org, lee.jones@linaro.org, linux-kernel@vger.kernel.org From: Sylwester Nawrocki Message-id: <6b1626c1-d223-4e39-8065-a7421bd3944c@samsung.com> Date: Thu, 25 Aug 2016 12:18:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <20160823162825.GO21682@localhost.localdomain> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrILMWRmVeSWpSXmKPExsVy+t/xy7qKx/aFG8w8o2Jx5eIhJoupD5+w WfybcoPd4v7Xo4wWl3fNYXNg9djwuYnNY9OqTjaPO9f2sHm8nPibzePzJrkA1igum5TUnMyy 1CJ9uwSujGN7D7EVbOKquDrrF2MD40qOLkZODgkBE4ntt9czQ9hiEhfurWfrYuTiEBJYyigx u/ERE4TznFGif+oksCphgUiJxUs/sYHYIgIWElOW3GKGKLrLKPFk4ytGkASzQKbEuY6NYA1s AoYSvUf7wOK8AnYSU1c/B2tmEVCV2L1mEjuILSoQIXFr1UeoGkGJH5PvsYDYnALWEttnzwCK cwDN1JO4f1ELYry8xOY1b5knMArMQtIxC6FqFpKqBYzMqxhFU0uTC4qT0nMN9YoTc4tL89L1 kvNzNzFCAvrLDsbFx6wOMQpwMCrx8O5YtTdciDWxrLgy9xCjBAezkgivzNF94UK8KYmVValF +fFFpTmpxYcYpTlYlMR55+56HyIkkJ5YkpqdmlqQWgSTZeLglGpgzBaZtHcX+/U1vAndj43v 9C85uMlh/fpV97f96q/Zw/jOz4o97cXFYtfNHbNvG65ekFL5/oRN7Nkje6Z0Twq43fnEbPey 0Jfy67MTviZKC918lOR6uGXx5zCTqfG5W5ok7nw36ghbuHrTyjlp+2d25kis3bCx6vyqB8xq XD/cijgaF/3QStdS2KjEUpyRaKjFXFScCADHnsEtZAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/23/2016 06:28 PM, Charles Keepax wrote: > Apologies it seems I missed another version of this on the > mailing list, please do feel free to add me or the > patches@opensource.wolfsonmicro.com list as a direct CC on > any patches using our CODECs, I am always more than happy to look > over things and feel bad when I miss stuff. I will have a look > at the latest version of the patch. Actually I should have copied you on the last iteration after addressing your review comments, sorry about this omission. > I think we should be able to do something requesting the 32k > approximately as your existing patch here does, but then > requesting the main MCLK from the set_pll and set_sysclk > handlers. Eventually I would like the internal SYSCLK and FLLs > represented in the clock framework, so I want to have a quick > think about how that would migrate over. Let me see what I can > come up with here. Sounds good, I assume you mean enabling/disabling from the set_pll and set_syclk handlers. Do you find any issues with that? I think the CODEC should ensure external MCLK is enabled when setting FLL, otherwise it will not lock? Presumably arizona_set_fll() and arizona_set_sysclk() are places where it should be checked what the root source clock is and enable it if it's not yet enabled?