From: Joe Perches <joe@perches.com>
To: Stephen Brennan <stephen@brennan.io>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Tobin C . Harding" <me@tobin.cc>
Subject: Re: [PATCH v2 2/3] staging: rtl8192u: fix macro alignment in ieee80211
Date: Wed, 28 Aug 2019 10:20:24 -0700 [thread overview]
Message-ID: <6b17910acdb7259b16a65265e8a6a8bbcd6c86cd.camel@perches.com> (raw)
In-Reply-To: <20190821143540.4501-3-stephen@brennan.io>
On Wed, 2019-08-21 at 07:35 -0700, Stephen Brennan wrote:
> Several macros display unaligned, due to mixes of tabs and spaces. These
> can be fixed by making spacing consistent, do this.
[]
> @@ -452,18 +452,19 @@ do { if (ieee80211_debug_level & (level)) \
> printk(KERN_DEBUG "ieee80211: " fmt, ## args); } while (0)
> //wb added to debug out data buf
> //if you want print DATA buffer related BA, please set ieee80211_debug_level to DATA|BA
> -#define IEEE80211_DEBUG_DATA(level, data, datalen) \
> - do { if ((ieee80211_debug_level & (level)) == (level)) \
> - { \
> - int i; \
> - u8 *pdata = (u8 *) data; \
> - printk(KERN_DEBUG "ieee80211: %s()\n", __func__); \
> - for (i = 0; i < (int)(datalen); i++) { \
> - printk("%2x ", pdata[i]); \
> - if ((i + 1) % 16 == 0) printk("\n"); \
> - } \
> - printk("\n"); \
> - } \
> +#define IEEE80211_DEBUG_DATA(level, data, datalen) \
> + do { if ((ieee80211_debug_level & (level)) == (level)) \
> + { \
> + int i; \
> + u8 *pdata = (u8 *) data; \
> + printk(KERN_DEBUG "ieee80211: %s()\n", __func__); \
> + for (i = 0; i < (int)(datalen); i++) { \
> + printk("%2x ", pdata[i]); \
> + if ((i + 1) % 16 == 0) \
> + printk("\n"); \
> + } \
> + printk("\n"); \
without pr_cont/KERN_CONT, this will output a terrible mess.
It's probably better to use print_hex_dump_debug
next prev parent reply other threads:[~2019-08-28 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 14:35 [PATCH v2 0/3] staging: rtl8192u: coding style fixes " Stephen Brennan
2019-08-21 14:35 ` [PATCH v2 1/3] staging: rtl8192u: fix OPEN_BRACE errors " Stephen Brennan
2019-08-21 14:35 ` [PATCH v2 2/3] staging: rtl8192u: fix macro alignment " Stephen Brennan
2019-08-28 17:20 ` Joe Perches [this message]
2019-08-21 14:35 ` [PATCH v2 3/3] staging: rtl8192u: fix spacing " Stephen Brennan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b17910acdb7259b16a65265e8a6a8bbcd6c86cd.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=stephen@brennan.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®