From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D36D16A395 for ; Tue, 14 Apr 2026 14:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776178093; cv=none; b=ovYtN6prUHwcu6Z+oqhMSfNGCRsoJ6ZBjzZx9XXaDhXCYyDFI1ncew4cYApkyoHtmd6xKca3oxBRI46Rd+we5Yolc2HkFxR7Aj8lVhVD7z92bSl69i6ZtwG+DdtKRB+IRj8TLlKJzI/igaya1CsPEUdBew0UdllbG0Y6yIccpzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776178093; c=relaxed/simple; bh=F4KrN7AxWl1zxvFjsxoDq7IgNFLpL0NQ0qQaV4v5U2A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KZPUBX3szg/PG6BYU8PdOxRJtLtfQx7/MkTuKRCh42DpGF66V3n1UGWE55RElAcEl8gTyxaqDcCunUkECtNe5RjifYq5q1EoQcULF2fnw9h+DI4b03PIa6haTK5JIuu0Aat9iD9H41L2J4B48McSfWxVOdECt0JKpjhVmm5e5NU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TMMyTpJ0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Tgon4keH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TMMyTpJ0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Tgon4keH" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63EBh9Yo282234 for ; Tue, 14 Apr 2026 14:48:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= asIz/goXM85jx8Mtx/IA42gOXbEjTcLDg3RNbVf0uDI=; b=TMMyTpJ0SSjVBYqU btGRqb3op5XUXdbZUaFI/uSd8zvCXcYPVd3/mmffHe8p8C8r0FtY217bMo9vQJPP QL2lW7JB+JtX85N4SMFL/iKURvd74y4ej7KLOW8Dt+3GebWPKY9h3PhR8gXYcuqA VWMivjyVlPeIQuBuffqCVQXtppfc3P95pEpjoH8EpsSrZLcQj+G8MaU4+75y+QqQ 7GRfhzEIOGEE6azrOnT0QHtTO2nZ/WTRfGkZJSzSKGwTfkEhHsEa3mf6TGd49yIF /wSiS6wyNGOxNsnAwJ8Y/NW1RKa7TPFg1Ro7s8xekkqgFYBKr8O00eli3xYTdaa6 opMQQw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh86vk5jk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Apr 2026 14:48:11 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50db373cf13so9341631cf.1 for ; Tue, 14 Apr 2026 07:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776178091; x=1776782891; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=asIz/goXM85jx8Mtx/IA42gOXbEjTcLDg3RNbVf0uDI=; b=Tgon4keHXZeVc2JWzzxRcOBXbLaK49C7Fodtr/VGQITwdYfG77vJH/rsi/2x7+xYAm G/WTFRBVizAJ9C8ljNEEGW/85Qp1acpmy7NeTOom9MOOjkD0EGIBkMNDhp4bBIxxH2An wW07J0RbHM4rJuEU2Z+FP3PvJTOfKFDWM1verNvMG4G8ZLdtsyvVRPzmI0XcPhRr2oZm iARQEEftHh2hltXtA2Q2u+aCmCMtEvO3e76C2BqfvJhClHNMwpCcc8KPGAfFphvWDYVS 0kl2iiwU5qyKDsF8+gPGzfT909RWp6jBKUZTMyVsn6EFUvNiWGVUkZnzSTqdbgWGAMdh sonw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776178091; x=1776782891; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=asIz/goXM85jx8Mtx/IA42gOXbEjTcLDg3RNbVf0uDI=; b=WOweN4W6reQNpn+cW0xQFzrHZN1MJQWIOwzUe3Eam5C4QKsGfSjzEfBQB3BpS+Ni68 JOaLNUudSc80Ru6JsJD6L36GIk1Ke6aPI3gba884rnC162VaLsW6e7ODmNbxnnYCzN5j JPEOHt76jbdYFkQCFT5pR/hF9ul373ELQY6Wf3JQ43IrKOvGd8lMk6KdupCjJ1P8oe7B 5Hyoy8G9v+K7xdKTunAxaY4SUXgss5x0ppg7v8p9K0ua//pccJXx+QXbpB5/pM1R0h9z j0dik4azIZoOqkmWPbUXlTjBsfHU7DVSZ4Mmrddw0j3b3gvgGayaLuVuwzCB6ULVU6M6 WECA== X-Forwarded-Encrypted: i=1; AFNElJ836TOkW+/DEwx219hFyBX1ix0mQTW1g1tprb/eTY9M4kE53LKo37Y/oo9RR083A8CECf3e198ePDwJFOk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/g2PNbBDPrVqMM7VPakkvsR8SYqhpfO4jo8lC72iWrGAvLh/P 1ml78PfG4nJQExlrhckB1ClbKFpR24tu60V6+n44ov28JQWiyLkTUrWv37pMsedEOwTrbCTTO/f srVEUJIV+FNnhrm9NRjb3xblcyPeS4tvj8fbsf8WOWLHxR108T4Xc2m4ZcbeY4dL9mCQ= X-Gm-Gg: AeBDietQGsMUCt1aMzXlkdQjOTcou8s047jaQtGOz1ef+Ns47fGY02zhC6ZCAUhYXyH 6qMpeA86eWPV0sOeABIHyEf0TVX45DHdaIB06I5tElMwoL5YsFM/P/Wa2zrsuL19GnpWKEeB+pu /yI1EWvkh3f3sxMpk1qzmH4wZKJoNlmttigQAFC1XCRfYZEcW03OyiGUkfHEhrRhe5g5eOjs8I2 wIRKvY4Jgh2EjomSAJvmLpVkcZR25aCAL4GzC58qh++G6ujMJtWKclx+hcSUaC4xSM1sNwmXGdF WWBiWzhqTYrVz51As02piwZwR50ogfzzcEnM9xUdOcYMEmapCzd9B180SlWB/bvmbIwgd5PxW+c d7KNW6n8JSSJDcMpE/65NBw3DcGgRP1kETUp08o/Wjp2BCS2UxawW7wgxwjmnZV5aLZzhm4HJqc Vg0ioLNPnNE4C6Iw== X-Received: by 2002:a05:622a:98e:b0:50b:8ccc:a41f with SMTP id d75a77b69052e-50dd82add60mr172439541cf.6.1776178090595; Tue, 14 Apr 2026 07:48:10 -0700 (PDT) X-Received: by 2002:a05:622a:98e:b0:50b:8ccc:a41f with SMTP id d75a77b69052e-50dd82add60mr172439181cf.6.1776178090154; Tue, 14 Apr 2026 07:48:10 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-670703f1340sm3291881a12.10.2026.04.14.07.48.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 07:48:09 -0700 (PDT) Message-ID: <6b19880e-83b4-4811-aea1-dac6cbdce2f3@oss.qualcomm.com> Date: Tue, 14 Apr 2026 16:48:04 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] clk: qcom: gxclkctl: Remove GX/GMxC rail votes to align with IFPC To: Taniya Das , Bjorn Andersson , Michael Turquette , Stephen Boyd , Abel Vesa , Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20260407-gfx-clk-fixes-v1-0-4bb5583a5054@oss.qualcomm.com> <20260407-gfx-clk-fixes-v1-4-4bb5583a5054@oss.qualcomm.com> <73196147-0133-4646-927d-dbe93c254286@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: MSnoGIY2yktbRVZqC2aaMd2wA_ELodJR X-Authority-Analysis: v=2.4 cv=cffiaHDM c=1 sm=1 tr=0 ts=69de53ab cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=Kn1p6E0Hg4E-9EtVOsMA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: MSnoGIY2yktbRVZqC2aaMd2wA_ELodJR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE0MDEzOSBTYWx0ZWRfX/pm1Wd0H6XA3 JDizzj+lSWmGZRp9Pvo0AxDNKXfgN9R66fdbfZ3Rpg4PwHEZ7GlpzN/n+4VoI3bgLTJigAkHXJp iQdsGKN8xgs+NFhd5jlf7VbAZJdae9BtYByVJIEX/VR/9jjgP1BqIo21mnl819+SDze2m4CZF1K zdDUlQCu107cadkXSAgWqJP7IaEDptuh4LLtvP9rfrabvCfGQSwb5BxQwbJ3LBo9gP+jRCp6mWU wWJhbFXZfHTh6LeMlKV/3LzdMmvMVCOffH5/OuSHz8NK3XjVQXeiISEXjJhZC9HthWRlRl4iem4 14eQkvq/giHeMKAm3uUqOpSQ4qZImqIuT852wTrWBf9Ms/Y7e659NE5KnK9A7LDfyzz6FoM+yjy hPK5GPgmvEfvKhJ312VZXH9WLEqk7eznMA2zQhVmFY08qNP0aBY6RBjJCQPLP0UC8cYJ3U3ldgo q4hXNPtebA7j8k2iXgA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 adultscore=0 malwarescore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140139 On 4/8/26 9:25 AM, Taniya Das wrote: > > > On 4/7/2026 4:59 PM, Konrad Dybcio wrote: >>> >>> #include @@ -61,7 >>> +62,15 @@ MODULE_DEVICE_TABLE(of, >>> gx_clkctl_kaanapali_match_table); >>> >>> static int gx_clkctl_kaanapali_probe(struct platform_device *pdev) >>> { - return qcom_cc_probe(pdev, &gx_clkctl_kaanapali_desc); + int >>> ret; + + ret = qcom_cc_probe(pdev, &gx_clkctl_kaanapali_desc); + >>> if (ret) + return ret; + + pm_runtime_disable(&pdev->dev); >> My understanding is that this works because we have more than one >> domain associated with the nod (so the generic code that would >> otherwise enable a single one so long as the device is resumed >> doesn't apply) and your previous patch ensures that after probe, the >> clock controller is being put to sleep, right before >> pm_runtime_disable() executes. > > Konrad, by disabling runtime_pm will ensure that when GMU is moved to > runtime active the clock controller is not runtime resumed, which would > prevent the votes on the rails as per IFPC expectations. Right, so the burden of only accessing the gxclkctl when it's got power gets moved to the driver (which patch 6 assures), got it. Konrad