From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754059AbdEQIXV (ORCPT ); Wed, 17 May 2017 04:23:21 -0400 Received: from mail-bn3nam01on0052.outbound.protection.outlook.com ([104.47.33.52]:42624 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752596AbdEQIXQ (ORCPT ); Wed, 17 May 2017 04:23:16 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH] gpu: drm: radeon: refactor code To: "Gustavo A. R. Silva" , Alex Deucher , David Airlie References: <20170517022012.GA11913@embeddedgus> CC: , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <6b1a4f85-bf6e-2b0f-7b7d-2eef9756113b@amd.com> Date: Wed, 17 May 2017 10:22:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170517022012.GA11913@embeddedgus> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:f869:d664:ea8a:b6d2] X-ClientProxiedBy: HE1P18901CA0022.EURP189.PROD.OUTLOOK.COM (10.168.181.160) To BN6PR12MB1300.namprd12.prod.outlook.com (10.168.227.150) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e0d2979-3d29-4806-5407-08d49cfdf60a X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:BN6PR12MB1300; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1300;3:WfJfPbXv51CzkYuwQQDDzgaLoS2q4wZaRwuqVVK7QTQmnkO8ZWpKL1NzOKEpH7UTOsj6l5DVe3/0nKWpZDpUIRgA6v+XmYgueU4QQJJgCS+4pfTTomcas/baU6vCXqi8UmLddGROe+wFBhUGgfY3BT9ygNCQj/YjoQfXfAkBP7gHtz5R1lF2dH0Dmsn5DN0LR2sVb1GkNu6Zozsi6be5Qr25w3O8IqTiipgvF/2D+xPhSBH7yEbsVYJmi2dtY9+8FZysZkeYJtGD6PjuLAd2CHLzuD353yxOHitNHtnU6GdtzqElEgTMbM6jGSuWFwuqRPv7MfrCIQbBnVTecnXyJVHj3y82XMd2fvnbfCMjwfc=;25:ftVVn7L81ODGkGigtYNQmF06odcwmLrig3pieQMEwUJK3uY6hFCEtKO2oF6HAPULin94EaG7n0HebN73P0dLPS9L/cEdSLv5Vjpn562divYyVoqVLIXlnJEB/2Dn6fTKgyPLHHNo356CaL2+IxYtaqIyanzz/BKZoPsVBkUBnxRzOnWK6WPaI4huyhoaXesQy4X1dwuGTu8txbBRwNbmOuJHuIaG1oTV6lihiO9qinecT4icA4458JiugSbGzYfjeQriCqwGc1Y67EuFJ3i5Tq//lH6s4SFzVIO55WapeaYcxsfP9Nu/Jur/8hKHqwFXagdy95zMKpBN+bubaSr2ym0WNVDhiZo1eTU2XMnT2akaiakGVKBCdwk+GjmIh0uRPt21s5yWt7L42i6J34Im1nWzWI407OrkJkIm8+/GLfbTjZ/dM0eHQNYEOyCR58wJZpC03lfm9Mz/pigiAB3w5MnCy+jqh8Bv+gEtdci7e3o= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1300;31:VYHyDyxWNtFPJ0+ogO9Gif/Mxw8E6lrlDFAGeabfPytSZxM7rICKXcNcxIrPLTNMCnHTjE/lnUSv7wkxZz8ua7t/QlL5lCK030eqwSLOFTB1wP/6Mij8WVWOxj/P32g6HE3/SRD3KlLg6RcYYZZUFdzaWIrF4/M0JhGaaTwVRKO0zAZr5hiqBp9j1VwoAEbUtn5q7A6y4a1k2MQcwboWVNtByfX3i9tJZKgaua3g7dw=;20:khpDIfWh6RDA430Mw5z9jwjEKyNBo/piXRxS0SwwfNyJrqkbGgBz8XMtFn2svYiARbZwM4ArcjX+DZkio1EsJrDaZVymNjcWGLjR9E0l4jEpOKH7kObFuOprbKfS3XOybeFGCfXxmCCmohkjhz11tbweKRv8yYwM9qYc8bM1HM4RejlkdU19Ts8nUx7DE03U+GLb8pJCY/mAFXHL95nA5HVjZXX4S9JpIVZU5jmcplF5e3HP4mYECBproSP48SVx3LG3orj6KfJEPnpzmDDszAXotLDc0GZX7ZmjBQkNtomMBlb2TZkp5tg9p1frVj0LfTR3RNB2Kt9LENS34PUk4wH5IMO0CLNIQdayX7obc09T9MkqlvE9ja7Qlqy8tLJbxuGTHxCB31yDLkhusshF1yRDSRjKI04851qWi5utUiNIXNFFWvxmxxP1k+bAEzwqyT/05xbaRft0J4oKl9rBqky6f2JZzjS++/tTsPvjP3Iu9tnEITtNLUI09hLKrjPZ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123555025)(20161123558100)(6072148);SRVR:BN6PR12MB1300;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1300; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1300;4:YrI2dc64uHCaluV/BY3d07EyTTvZob4jZ1cBioogEPf5GfbMS9gaE0ti2tEAYeZKRyC3FgqG+AxWXhjZluD9xYonX/57p4iEwxghrXpapAGFzrG2oYMrbf2el3M/B+BFX/p47JbM5j5wTad62FG9KepCRG9CFq5i1KNO6y7V5vTwunD1NhRj/s9KTH31kIlUUPoLd8uM5ctVXqTvgwfAF8oBd7Pcoi4vOeWEiDXB74whXD5FaqpVSKZ3JUTqu5ozGcYUjLorQ1N5oS8SwQ54cOzB//LzTHQQIwCNTyLCSknJFGpOyfTb+dfgLpjCfAPPgNjDrFw4JqWfguSDt84fFIIdXi802lvaQGl4LPNWeFZmq6tH3VYRRUTNdeJ7aAjy0+34N2P3dgB0StQJY1sd4/xu1vMkM4brm7oG0FL44WQ1sTXixaJVg9e7aZ40DfeAyubHAu212QapvH97jWWUw8wPGwpSXGf0B1TQni7hmG8CGjmB7PmE561XVBwBDHNEH9zlz66Jd0ylU7x9OMZfhYimlnLbtUV8gdEaE+vgBxuPEEy80GFAOoMD1TaX1J1nVjU3lQxKVJGIbCAMzbkdcUgN4E0cpExxApNn/Jwy0VqP2whDDllmTxdi3e674G+Fa87iB8xPSIm4QKSepBIdZ0XRLBqzD/+kyDUNhz/lUyv+aO05miNxQo3xGFbCrE+O9icPXtVeUwJxlA4J1D3D6G+nlBCJKfHvpjb6y/17ivDRZW3wsH0yCzl5Pai8yUB9tmU2Cy2LYbdcg0TmrWD/Z9Ga8fjNTErFAjlhnbUtlKAlBXshrpE/MPbcm6vZS9wtE4GiqUutGLbq/Z75KkNI+g== X-Forefront-PRVS: 0310C78181 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39850400002)(39450400003)(39410400002)(39400400002)(39860400002)(39840400002)(36756003)(6116002)(81166006)(54906002)(4326008)(8676002)(31686004)(2870700001)(53936002)(42186005)(54356999)(50986999)(33646002)(76176999)(305945005)(4001350100001)(23746002)(7736002)(229853002)(6246003)(6666003)(83506001)(25786009)(64126003)(65806001)(6486002)(2906002)(47776003)(5660300001)(50466002)(478600001)(2950100002)(72206003)(575784001)(189998001)(86362001)(31696002)(38730400002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1300;H:[IPv6:2a02:908:1251:7981:f869:d664:ea8a:b6d2];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR12MB1300;23:e1ZNIOX19h1vhutLZHF1n/r1jgGRYq2UF8CjI?= =?Windows-1252?Q?tlrJikHbstIrt3rmS3f7mn2FJcqwxldUMth5qKK1VErgOUywHq/aIE+N?= =?Windows-1252?Q?NNuy8iblUqbbLfUw81ZYqjzeokhhdwAmkmeIf1i3TOt8daFu2TjkVWL6?= =?Windows-1252?Q?u0S743aSaljfKWtFZztoCQmtzujnAuiiCNKbit9jnooZEOQnc81UUXk2?= =?Windows-1252?Q?DiHj9SsLjjyqN8aZOmuo/3QudbVRb2pWiZ8BwIuAt1WCzobC6e7Ot/Rh?= =?Windows-1252?Q?41GsqAeEwCUhokCi2S+u594/W2hyFXpmNliXnCTU91AL9Jmx+RalJCOD?= =?Windows-1252?Q?ewdfHstdpG0WW5ecp/uB9Fn9mD3GFy4P4fEuj9POO9FHCzFiyzD5aVSd?= =?Windows-1252?Q?5t9ifLZ/SZ/qO+TTVNZ+5yTX0CRTcdGOqBy2bFy/bBWjNumQMjvtEh6X?= =?Windows-1252?Q?zbYI7Ntm3/SM74t9RYCytAC56F1BDGD0n1n07AZA3Zbd/0D4RJEYB2VK?= =?Windows-1252?Q?IYapgFoiOQ24fv3Sp6f5iZIQiWuT4eAdhRRkWLaBvYUmAhOFrdPBp5qv?= =?Windows-1252?Q?VxEIeVm+o/B/Xl+yDZWNA9TkQyfTAreGJhzMVc2T8lCK9gVzdjEFRP6U?= =?Windows-1252?Q?Livt1lURZnRKAXwKKWj8OMu0eaaaN8N22q1S4s44BYZHqcn9IJ6UCRzI?= =?Windows-1252?Q?Un2GTbG7rqGvdK/nWWDr7Wk1Vm5QrxI9T9k56sae943IUqv0MZCNAK3K?= =?Windows-1252?Q?bvwneVGA5hzHj9FD8LsDHqlvr+i9WfwMB8VePikCLs5xdOUQhGlw7/cN?= =?Windows-1252?Q?r83fwESNEZheK986roarWJkiqZoLcIpjS6bR+lYAWrSI/71Ff3zCkl/J?= =?Windows-1252?Q?Au83PNURhjI6WSetuyVSuilXJ+IAGX3Jczq7njP10DSbdu+JiTxE+dVK?= =?Windows-1252?Q?68C5BJbYvkbLTFm1SWdHVQZDQTlc5gEM/ZFfCmaPLPWIWFmiki2nyDWv?= =?Windows-1252?Q?DYG1DxozeLSc76QyNGDrdVScS4Yi8KXf3L+FbnOO2XLnGKJVO7LL+3K3?= =?Windows-1252?Q?a+Pu3r0gMLGwbchppnnlxl9px9ASHlUx0tTBzEGgiyeJeBfdjJMpumub?= =?Windows-1252?Q?G78qAdBZvYSXzW6YlfzkDVAiwIe8szApEF3nSodTkrFrWJmCKKTRGZ20?= =?Windows-1252?Q?ba7y2cNeDU/qzm30uV9X7G/myGH+y9J5kgAXZ59Lk7JquEAtaCrHmZ+z?= =?Windows-1252?Q?Em1o7JOM4d8dm3UxXrEmJOfDhqyfVRzE41eCqI=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1300;6:+jw9FUb/YpedRNxNHUwiOc3YEBxq/+CDGG6U3ndwk05sIh7G6VPZQmNKmEQmxmWz16QR6cu5PK88C3eCrKc1FrD7eFBODy4eOtZBvOvAZWfZneJsy5EsjSVxe0jPBMKVRcrrqA0Rehwts62P4Gwbcu9OD3034KHJY+fMFuKAEnOFwN2a550nikRlYqD0BaSGTPOrfqEgD5K6BI5yB0ImOEJopfeh2ZMeE+O2kT7o209vl0aXCRiCBHM+vGaniivtYxq3dLmHK2pooNXh+zdrZ26fPMNsW8eWcjxhE8TJIIhK7SKA+M07Han+5H5b0CRcRgketR8Iq0+pDSiBCfkuHiXdGqay3rRnhHOCHUuyw0LePnCKz37f6Ajmh531F5lnalNYKns877p5KeWhubfZJYnx/HSxFr2gqmYaL0/zVU0fGsY2o3bMDm3ZbVKaAoknACyP8sRHhS72VdPC1sIXHRM1N+vq6LHxwTfGG//66L80MLhXLg/WWUmMpTs2RvujYRMIzdQTLTQubSn0bgcxOPPBJZkhSl1d49Sjqjref7g=;5:ojx1ITvBjiYDsCmhEarWn4YWtGPgP3BPTSdLm1TNyWpIJog1WwJCGpD9xPiME4ng/ow/lj6qJ57w93QAFa6U4yCgmgBlfThVqucCpvWGNzCqQcZDuyTsH31bkw098gwsNKHSq2fGaPk5NVUJr0GNtw==;24:OwWXtossh0TroeDLqxHvyGXeF1Dx2mZdi5Wet9+0yIqB0OdN6EHoFpeOAgCuWggPhMjZZxty9qLV+xtthYcXaVeJGv1++spN/2rv1Ede4Nc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1300;7:wLAiHKgyMw3zwd7OoomLwDwLgiAcuNm+L32qKkVgLEF44eqSyJA7hX2RyxYH1Z9nxog+E6J6yd3AghjCZpw7QPq69i0XRSqRHxn3c+I4UbC3Z0VbmEH+pVpaEgcUO32fMzeBZrU5opPgLq2rZ1VcPg1T1YagW5RysagBN7Fxq9sccJuPNxBisemNNBdXXF/Gp5I0joi43y078whTjWRV6IHQ2yMk29J8KX5EgFuV5ZDD5cZur9YTLsk+/UWfyHya3KQb8eDltHSw4Nhn/b2K1fGtTsNq2zA24GNl9r5ONJXGcxTgTtPHUl+Pa3tuYpwd1WTjRqDsPAL2Fk/dhBcRIQ==;20:w32w4usvayKplJQVT/KLJCjEO5MBiMOhMKhDNxqXKmZWWA3FK+vxn+5VjysBvfd3YRr+rkSM2bLzAL5GJbateMIvVjjZBjPv+MSlss3IsxY6R+M2ViTBzbCwoDIscengKfMAHWWPxXTCWql5hqMVMHaZ0wyatAjQY4IVBG5wj7pzpjSJaUMtVzzW1jYfrLZbViFsOu7+2FHjafxXg2qEMYyNYQcUhy2T6fPZyN8IkBK7CnDjYvxo/rMmb9eRCf5Y X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2017 08:23:11.9951 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1300 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 17.05.2017 um 04:20 schrieb Gustavo A. R. Silva: > Local variable _color_ is assigned to a constant value and it is > never updated again. Remove this variable and refactor the code it > affects. > > Addresses-Coverity-ID: 1226745 > Signed-off-by: Gustavo A. R. Silva Mhm, on the one hand it looks like a valid cleanup. On the other that is legacy code we haven't touched in a while. Feel free to put my Reviewed-by: Christian König on it, but I'm not sure if Alex will pick it up. Regards, Christian. > --- > drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c > index 222a1fa..7235d0c 100644 > --- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c > +++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c > @@ -640,7 +640,6 @@ static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_enc > uint32_t vclk_ecp_cntl, crtc_ext_cntl; > uint32_t dac_ext_cntl, dac_cntl, dac_macro_cntl, tmp; > enum drm_connector_status found = connector_status_disconnected; > - bool color = true; > > /* just don't bother on RN50 those chip are often connected to remoting > * console hw and often we get failure to load detect those. So to make > @@ -665,12 +664,7 @@ static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_enc > WREG32(RADEON_CRTC_EXT_CNTL, tmp); > > tmp = RADEON_DAC_FORCE_BLANK_OFF_EN | > - RADEON_DAC_FORCE_DATA_EN; > - > - if (color) > - tmp |= RADEON_DAC_FORCE_DATA_SEL_RGB; > - else > - tmp |= RADEON_DAC_FORCE_DATA_SEL_G; > + RADEON_DAC_FORCE_DATA_EN | RADEON_DAC_FORCE_DATA_SEL_RGB; > > if (ASIC_IS_R300(rdev)) > tmp |= (0x1b6 << RADEON_DAC_FORCE_DATA_SHIFT);