mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linkui Xiao <xiaolinkui@126.com>
To: netdev-bot+sinfo@kernel.org
Cc: razor@blackwall.org, idosch@nvidia.com, davem@davemloft.net,
	edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
	horms@kernel.org, bridge@lists.linux.dev, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Linkui Xiao <xiaolinkui@kylinos.cn>
Subject: Re: [PATCH net] net: bridge: netlink: do not clear the vlan info dump error
Date: Tue, 27 Oct 2026 17:08:50 +0800	[thread overview]
Message-ID: <6b1d38f9-458e-47a0-a593-e47a219ff13e@126.com> (raw)
In-Reply-To: <179309134717.3327.17438354236814047357@kernel.org>

Hi,

Thanks for the notice. Please find the missing information below.

On 2026/10/27 16:55, netdev-bot+sinfo@kernel.org wrote:
> Hi!
> 
> This is an automated message. This series looks like a fix, but its
> commit messages seem to be missing some information:
> 
>   - Whether the issue was actually triggered, or is only theoretical
>     (e.g. found by code inspection). If it was triggered please include
>     the symptoms, like the stack trace or error messages.
> 
> Please do not repost the series just to address the above. Instead,
> reply to this email with the missing information, so that reviewers
> can take it into account. If the series needs another revision for
> other reasons, please include the information in the commit messages
> then.
> 
> The evaluation is done by an LLM so it may be wrong, if you think
> that is the case please reply and explain.

How the issue was discovered: Found during Sashiko AI review of the 
bridge netlink code. The review identified that 
br_fill_vlan_tunnel_info() could overwrite a previous -EMSGSIZE error 
from br_fill_ifvlaninfo*() when the port has no VLAN-to-tunnel mapping. 
The relevant review comment is already referenced in the commit message 
via the Link: tag.

Whether the issue was actually triggered: Not triggered at runtime. This 
is a theoretical error-path issue found by code inspection/AI review, 
not by syzbot, a static analysis tool scan, or a production report. No 
stack trace or error message was observed, and no test case was written 
to reproduce it.

Testing: The change was compile-tested only. No hardware or runtime test 
was performed, as reproducing the exact -EMSGSIZE + no-tunnel-mapping 
combination requires a specific skb size boundary that was not constructed.

If a v2 is needed for other review reasons, I will include this 
information in the commit messages.

Thanks,
Linkui Xiao


  reply	other threads:[~2026-10-27  9:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27  8:52 Linkui Xiao
2026-10-27  8:55 ` netdev-bot+sinfo
2026-10-27  9:08   ` Linkui Xiao [this message]
2026-10-27  9:09 ` Eric Dumazet
2026-10-27 10:02 ` Nikolay Aleksandrov
2026-10-29  1:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b1d38f9-458e-47a0-a593-e47a219ff13e@126.com \
    --to=xiaolinkui@126.com \
    --cc=bridge@lists.linux.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev-bot+sinfo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    --cc=xiaolinkui@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®