mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Kohei Tarumizu <tarumizu.kohei@fujitsu.com>,
	catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org, hpa@zytor.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/8] x86: Add hardware prefetch control support for x86
Date: Mon, 14 Mar 2022 14:05:56 -0700	[thread overview]
Message-ID: <6b28a6f3-8d3d-76f4-d517-62260ac5b337@intel.com> (raw)
In-Reply-To: <20220311101940.3403607-7-tarumizu.kohei@fujitsu.com>

On 3/11/22 02:19, Kohei Tarumizu wrote:
> +static int broadwell_write_pfreg(enum pfctl_attr pattr, unsigned int cpu,
> +				 unsigned int level, u64 val)
> +{
> +	int ret;
> +	u64 reg;
> +
> +	ret = rdmsrl_on_cpu(cpu, MSR_MISC_FEATURE_CONTROL, &reg);
> +	if (ret)
> +		return ret;
> +
> +	ret = broadwell_modify_pfreg(pattr, &reg, level, val);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = wrmsrl_on_cpu(cpu, MSR_MISC_FEATURE_CONTROL, reg);
> +	if (ret)
> +		return ret;
> +
> +	return 0;
> +}

This needs to integrate _somehow_ with the pseudo_lock.c code.  Right
now, I suspect that code would just overwrite any MSR changes made by
this code.

  reply	other threads:[~2022-03-14 21:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11 10:19 [PATCH v2 0/8] Add hardware prefetch control driver for arm64 and x86 Kohei Tarumizu
2022-03-11 10:19 ` [PATCH v2 1/8] drivers: base: Add hardware prefetch control core driver Kohei Tarumizu
2022-03-11 10:19 ` [PATCH v2 2/8] drivers: base: Add Kconfig/Makefile to build " Kohei Tarumizu
2022-03-11 10:19 ` [PATCH v2 3/8] arm64: Add hardware prefetch control support for ARM64 Kohei Tarumizu
2022-03-30 22:11   ` Rob Herring
2022-04-04 11:56     ` tarumizu.kohei
2022-03-11 10:19 ` [PATCH v2 4/8] arm64: Add Kconfig/Makefile to build hardware prefetch control driver Kohei Tarumizu
2022-03-11 10:19 ` [PATCH v2 5/8] arm64: Create cache sysfs directory without ACPI PPTT for hardware prefetch control Kohei Tarumizu
2022-03-30 22:14   ` Rob Herring
2022-04-04 11:48     ` tarumizu.kohei
2022-03-11 10:19 ` [PATCH v2 6/8] x86: Add hardware prefetch control support for x86 Kohei Tarumizu
2022-03-14 21:05   ` Dave Hansen [this message]
2022-03-18  6:41     ` tarumizu.kohei
2022-03-11 10:19 ` [PATCH v2 7/8] x86: Add Kconfig/Makefile to build hardware prefetch control driver Kohei Tarumizu
2022-03-11 10:19 ` [PATCH v2 8/8] docs: ABI: Add sysfs documentation interface of " Kohei Tarumizu
2022-03-14 16:39   ` Jonathan Cameron
2022-03-16 12:56     ` tarumizu.kohei
2022-03-14 19:19 ` [PATCH v2 0/8] Add hardware prefetch control driver for arm64 and x86 Dave Hansen
2022-03-18  6:34   ` tarumizu.kohei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b28a6f3-8d3d-76f4-d517-62260ac5b337@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tarumizu.kohei@fujitsu.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®