From: Ruan Jinjie <ruanjinjie@huawei.com>
To: <jassisinghbrar@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] octeontx2: Remove unnecessary ternary operators
Date: Tue, 1 Aug 2023 19:28:53 +0800 [thread overview]
Message-ID: <6b2a52c8-041b-5dfc-8087-36b1d31c8dff@huawei.com> (raw)
In-Reply-To: <20230801112409.304564-1-ruanjinjie@huawei.com>
Sorry!the patch has sent incorrectly.
On 2023/8/1 19:24, Ruan Jinjie wrote:
> There are a little ternary operators, the true or false judgement
> of which is unnecessary in C language semantics. So remove it
> to clean Code.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> Reviewed-by: Simon Horman <horms@kernel.org>
> ---
> v2:
> - Fix the subject prefix and commit message issue.
> ---
> drivers/net/ethernet/marvell/octeontx2/af/ptp.c | 4 ++--
> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/ptp.c b/drivers/net/ethernet/marvell/octeontx2/af/ptp.c
> index 0ee420a489fc..c55c2c441a1a 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/ptp.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/ptp.c
> @@ -61,12 +61,12 @@ static const struct pci_device_id ptp_id_table[];
>
> static bool is_ptp_dev_cnf10kb(struct ptp *ptp)
> {
> - return (ptp->pdev->subsystem_device == PCI_SUBSYS_DEVID_CNF10K_B_PTP) ? true : false;
> + return ptp->pdev->subsystem_device == PCI_SUBSYS_DEVID_CNF10K_B_PTP;
> }
>
> static bool is_ptp_dev_cn10k(struct ptp *ptp)
> {
> - return (ptp->pdev->device == PCI_DEVID_CN10K_PTP) ? true : false;
> + return ptp->pdev->device == PCI_DEVID_CN10K_PTP;
> }
>
> static bool cn10k_ptp_errata(struct ptp *ptp)
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> index 9551b422622a..61f62a6ec662 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> @@ -2027,7 +2027,7 @@ u16 otx2_select_queue(struct net_device *netdev, struct sk_buff *skb,
> #endif
> int txq;
>
> - qos_enabled = (netdev->real_num_tx_queues > pf->hw.tx_queues) ? true : false;
> + qos_enabled = netdev->real_num_tx_queues > pf->hw.tx_queues;
> if (unlikely(qos_enabled)) {
> /* This smp_load_acquire() pairs with smp_store_release() in
> * otx2_qos_root_add() called from htb offload root creation
prev parent reply other threads:[~2023-08-01 11:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 11:24 Ruan Jinjie
2023-08-01 11:28 ` Ruan Jinjie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b2a52c8-041b-5dfc-8087-36b1d31c8dff@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®