From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
matti.lehtimaki@gmail.com, quic_grosikop@quicinc.com
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 4/8] media: qcom: camss: Move VFE power-domain specifics into vfe.c
Date: Sat, 25 Nov 2023 13:54:22 +0100 [thread overview]
Message-ID: <6b30c1ba-9740-41f7-95c0-cdb1803fe19a@linaro.org> (raw)
In-Reply-To: <3b8e6b65-5f37-49e5-b83e-b89726867ed2@linaro.org>
On 25.11.2023 13:53, Konrad Dybcio wrote:
> On 23.11.2023 18:03, Bryan O'Donoghue wrote:
>> Moving the location of the hooks to VFE power domains has several
>> advantages.
>>
>> 1. Separation of concerns and functional decomposition.
>> vfe.c should be responsible for and know best how manage
>> power-domains for a VFE, excising from camss.c follows this
>> principle.
>>
>> 2. Embedding a pointer to genpd in struct camss_vfe{} meas that we can
>> dispense with a bunch of kmalloc array inside of camss.c.
>>
>> 3. Splitting up titan top gdsc from vfe/ife gdsc provides a base for
>> breaking up magic indexes in dtsi.
>>
>> Suggested-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
>> Tested-by: Matti Lehtimäki <matti.lehtimaki@gmail.com>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
> Reviewed-by: Konrad Dybcio <konrad.dybciolinaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
next prev parent reply other threads:[~2023-11-25 12:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 17:02 [PATCH v6 0/8] media: qcom: camss: Introduce support for named power-domains Bryan O'Donoghue
2023-11-23 17:03 ` [PATCH v6 1/8] media: qcom: camss: Flag which VFEs require a power-domain Bryan O'Donoghue
2023-11-23 17:03 ` [PATCH v6 2/8] media: qcom: camss: Convert to per-VFE pointer for power-domain linkages Bryan O'Donoghue
2023-11-23 17:03 ` [PATCH v6 3/8] media: qcom: camss: Use common VFE pm_domain_on/pm_domain_off where applicable Bryan O'Donoghue
2023-11-23 17:03 ` [PATCH v6 4/8] media: qcom: camss: Move VFE power-domain specifics into vfe.c Bryan O'Donoghue
2023-11-25 12:53 ` Konrad Dybcio
2023-11-25 12:54 ` Konrad Dybcio [this message]
2023-11-23 17:03 ` [PATCH v6 5/8] media: qcom: camss: Add support for named power-domains Bryan O'Donoghue
2023-12-06 11:35 ` Hans Verkuil
2023-12-06 12:25 ` [PATCH v6.1] " Bryan O'Donoghue
2023-12-06 12:28 ` [PATCH v6 5/8] " Bryan O'Donoghue
2023-11-23 17:03 ` [PATCH v6 6/8] media: qcom: camss: Flag VFE-lites to support more VFEs Bryan O'Donoghue
2023-11-23 17:03 ` [PATCH v6 7/8] media: qcom: camss: Flag CSID-lites to support more CSIDs Bryan O'Donoghue
2023-11-25 12:49 ` Konrad Dybcio
2023-11-23 17:03 ` [PATCH v6 8/8] media: qcom: camss: Add sm8250 named power-domain support Bryan O'Donoghue
2023-11-27 11:25 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b30c1ba-9740-41f7-95c0-cdb1803fe19a@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matti.lehtimaki@gmail.com \
--cc=mchehab@kernel.org \
--cc=quic_grosikop@quicinc.com \
--cc=rfoss@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®