From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E8E2426EB9 for ; Tue, 16 Jun 2026 10:27:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781605644; cv=none; b=adw8MpzoBWhMAm1sLkXVkOXo3gu+fYT+XVPtj6Zkpk7q4CCcz1vxi2X3CC1OIRJNL38EzYD1GzKip8Xm1zMJkrU/sxozdM34XWGx8vDUv0FAn8kgKuosQj1D/6dfSVC2nzytjp6kdTqC3GmQqZejOeYc29SmfZ6Cl2vwYsZYnTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781605644; c=relaxed/simple; bh=QMo3iSUBVZbXVK3uwB583SZFQY/wSl9nL8ZZ5XuBugo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uNYIVMkNIO+c2Kz1TV0T0/OrQ3eb3O95a51zsAn6/b3PgoUXAyeD6vemix1/4X7fI7LjUHFcbjJcyhkh+BiyfuAlqxJIxwJRgAtb+oUB9WAeXGvX45vAmGOqetTXYjhRaNjS0N3L1wSZFjRZiQNIB+AZW1es7dkzkzMA/nGYHMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jzmPgDiT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a4/65cZY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jzmPgDiT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a4/65cZY" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GA9ho32799365 for ; Tue, 16 Jun 2026 10:27:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Xfl7YUDOtyUDhv9IockQhbr+f+EP3g53NkHVlg+iaEw=; b=jzmPgDiTIV/kyDSn QxQ55kQeJcp/0gJjC/9zdSfF/zsfyIb0SdZEmXQ3PwVfAuSTU20+DoQAG6+8kTgo Q0EGd43ttYS7DnSHV/AnXfqdmD/nREPmUCTc7uvQS4I37GMbIUa8l+boO4xpagbH KdAcFpJ1xcl1BHgx46CJA84uR6UtPrutsV1I3YF0LF+Y5mJ26DMHfpxtpS5dpfcY 42GgnFRVR82fXV/67mZNvquo2uaK7zqFrISQX+37VcSeu6KjUnpXYTZS9g5CxGWy ReMrJdnvb/nXotHJeRV0fBTomLY81r/NVtUhxkwlvyPrfutsP6cI+vYwCv7qiCDU W+l1NA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eu0a7s961-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 10:27:22 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-9157263095fso35433785a.0 for ; Tue, 16 Jun 2026 03:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781605642; x=1782210442; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Xfl7YUDOtyUDhv9IockQhbr+f+EP3g53NkHVlg+iaEw=; b=a4/65cZYCSi2kAekvL/zUyWeedulEH1ANCyb3eqRUtVH8VfCTcm9HsMlFfeeSpEqgA fKh8hSzF2+L7StLIpGV1lDszEKcv6ErlNPQs/zM+rQ5+bBlePzhvzcZbOzRpzTgcyz3b juPVNarrA4Q0uY1N1eo+lP/WDFZMPzAKfzPvPA/OBw31TDJMv2jS6q1mF/ge8JNlv0DB njpGx9KhBFTGW5OaKT5mLprIL1jBHRw1e0TTLFBwano0iKDtU8AEX0xjCNsW9EQVL4Nv mOBh00dSw0kFK9PDjv7k0cgrvHwMt1qNUSxSgShXogWIWdjg4mWvDG+GXPqXu1r7PTbA J28g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781605642; x=1782210442; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Xfl7YUDOtyUDhv9IockQhbr+f+EP3g53NkHVlg+iaEw=; b=mUO1VuchK+ch5053UpKMS04AyN8y1tieiWV2hStrPab43bI9Y/8wL9YPrWotokPF/N r92TI6SkDjIEJHE72zcMrBPE+IAa0huTX7ydPOc4a2HeJXK9VvZ79gTeXOjbC1/ijiRZ jSr/W+ZVHyrgwJH3NAMGK6VZtlWZ13VWNf45BS6hJfzkoREj9juLDS18f1jTqaCehV4r Pc7NzKzazH0Tg1nD1GGyDJHJ6qJ07Ga73+uwkzgUBDkjv1ze82Gzjy+1UtEctMO4lM8A ICdASuUIgf7Uctn94D84UVfFQw8WKFPri+9BgCxZu228nWhPKRbj/Ie+QGMMZyh8uGiL F4kg== X-Forwarded-Encrypted: i=1; AFNElJ9b3hVDNsjnRJ3q/OcdGjP6colvRu45/T01ykZZFk4YyUe/s+0i6km9U9BWi+rpfTCM+fqP8iPollJhj1M=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2Z8rQX8ajZ0F6+VAUIV3xJQQKSAA84F+mW+NcRPNO8g5u5SiF liVX4su6IMbZJOQyggpl0F83GF5B8PhU5tjW/7WpNHQrqni964wv4GEeo06RQkP6PHoZWj8fuGv V0cLD6ioMHaBp5UP6iE8YOX0Q2m11Y2i+FgwcEmM8QIVhp5aUvyBAjfYfhM10rB5xntc= X-Gm-Gg: Acq92OEMGiKyVQRWNm5vaFjM9a/ofAnmhSn7co3hAkbdTA+DdaDeoMK+aWbQQGBYbWp pfEVKr95JE+DnpIzAB2uvsDXgjGfdyqZeXJp91VKpS70/fntibw/0+qD4/jeL9qW80t9zhd1WFD zpXWOUdgmSZf+Nd73qpxrhnm1EGYi08mdYRL0tsSUmW0CqEBWnktAfVFiLJgzUS7GIUywmzf913 AqlK/PGj5jcruUM0L/BpElXX4LzGja1JONb+mSg3P65ptilRWov0bY4mgKXlRFXTqwzRy0WS2um s9qf6H8NqSdc35ZAhegZWN09x5jAf+JeWv1XXlarzampdE0TuAKvWpfpLb9QQcelhIOzltH5zKr xBzyHfaYIR1i6wSNjDJDQGaKZwamvg8LoJGCVfpPovJuxbQ== X-Received: by 2002:a05:620a:c4d:b0:915:4ca0:1210 with SMTP id af79cd13be357-9161bc725a3mr1758231185a.3.1781605641728; Tue, 16 Jun 2026 03:27:21 -0700 (PDT) X-Received: by 2002:a05:620a:c4d:b0:915:4ca0:1210 with SMTP id af79cd13be357-9161bc725a3mr1758229785a.3.1781605641290; Tue, 16 Jun 2026 03:27:21 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb8e209f0sm610213066b.57.2026.06.16.03.27.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 03:27:20 -0700 (PDT) Message-ID: <6b3155ea-b583-4f82-8313-7a057fd78066@oss.qualcomm.com> Date: Tue, 16 Jun 2026 12:27:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: qcom: Add PMIH0108 haptics device node To: Fenglin Wu , linux-arm-msm@vger.kernel.org, Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Stephen Boyd , Bjorn Andersson , Konrad Dybcio Cc: David Collins , Subbaraman Narayanamurthy , Kamal Wadhwa , kernel@oss.qualcomm.com, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260616-qcom-spmi-haptics-v1-0-d24e422de6b4@oss.qualcomm.com> <20260616-qcom-spmi-haptics-v1-4-d24e422de6b4@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260616-qcom-spmi-haptics-v1-4-d24e422de6b4@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDEwNSBTYWx0ZWRfX3/M/KCU/4CeY TIF2ysKcCk5uwUcWg7JuNaB34ylnQiHVQhNk8lznibzeb91nI94vkwRb+CYt2zSmRngIgEcBYsL x7Fw7eM12YhN6Wp5SX7zXAnxLNf/vx72GKOXtFpw2wqhTjoLWsuLe4WL5aROOOULcVt9k9qS0DP ibZf9quIm21QlggRzKiCQ+Ce6JJFV4iwe3S7pbIAAesAQKqxC/BEDpkpeMpATr8s0GIA3oIVA7c dF4G2BqAub55x/AOkQCTEjyp5gaAgcbY9EeELlDR/yivogsSuDWE8Y0laHH39xh4rOT9N6dcDsZ XZETPPaZEPI+AdKZ/ij58AOsB2s0ZYzNtC3pqwChyMLHvHsdOtL/ng9m4WYFzffkVuDlZMU35YQ N5/P5iCjoEID/hWekMT9zcsm2uKF8TkxFXgrW/FHOt94FSfS4thtYBfERVLGY5XPAmrCMiyYbWr 2RAJmhQMKGRkQWwl2wg== X-Authority-Analysis: v=2.4 cv=JKALdcKb c=1 sm=1 tr=0 ts=6a31250a cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=WGoPKrXAnCDrgKufU7AA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: FfLbSpamCYKe3Q5NiOjHLH6JTZPM0miF X-Proofpoint-GUID: FfLbSpamCYKe3Q5NiOjHLH6JTZPM0miF X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDEwNSBTYWx0ZWRfX7B2wJa4pXfiV RjMrBghZq6OpXnM5iyUMEajr3mHJ2fRoWg1EJJ2AMley2jjA3KOFeF8zzLysSaJm+bL7joV5NIE BogGlFD/NKA03WDPje1wlZvjQJQ4r6w= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_03,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 clxscore=1015 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160105 On 6/16/26 12:08 PM, Fenglin Wu wrote: > Add haptics device node in the PMIH0108 PMIC base dtsi files, and enable > it on several boards according to the LRA (Linear Resonant Actuator) > component mounted on each of them. > > Signed-off-by: Fenglin Wu > --- > arch/arm64/boot/dts/qcom/kaanapali-mtp.dts | 7 +++++++ > arch/arm64/boot/dts/qcom/kaanapali-qrd.dts | 7 +++++++ > arch/arm64/boot/dts/qcom/pmih0108-kaanapali.dtsi | 9 +++++++++ > arch/arm64/boot/dts/qcom/pmih0108.dtsi | 9 +++++++++ > arch/arm64/boot/dts/qcom/sm8750-mtp.dts | 7 +++++++ > arch/arm64/boot/dts/qcom/sm8750-qrd.dts | 7 +++++++ One commit per board, please > 6 files changed, 46 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts > index 07247dc98b70..7e3f59fc008e 100644 > --- a/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/kaanapali-mtp.dts > @@ -952,6 +952,13 @@ wifi@0 { > }; > }; > > +&pmih0108_e1_haptics { > + status = "okay"; 'status' should go last > + > + qcom,lra-period-us = <6667>; > + qcom,vmax-mv = <3600>; Do these properties depend on the physical characteristics on what's connected to the other end of the haptics driver? Konrad