From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A42CC433F5 for ; Fri, 29 Apr 2022 09:41:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356627AbiD2Jol (ORCPT ); Fri, 29 Apr 2022 05:44:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356676AbiD2Joa (ORCPT ); Fri, 29 Apr 2022 05:44:30 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1DF035AA9 for ; Fri, 29 Apr 2022 02:41:12 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8777F210DB; Fri, 29 Apr 2022 09:41:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1651225271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TLN93rTB7llJ/DviTuLPV8Vw8InbmxfO6KMnH2jX3Tg=; b=vNjNDSI2Wes8ONnaVEGXMqkr+7o8qgPdZ22+ueEmBrM1qo3apGIpHeHWQ0XaBqrb6krNld LpdM0USytIMix47Y9FPv2h6wkS09vRhtIFiKUDe7sRvZ9gIehJfIfTYNjK8gnwMT8yLT9q qlMKZ6OoCwXf5v8iRyJ6yCTtxtqzSQg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1651225271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TLN93rTB7llJ/DviTuLPV8Vw8InbmxfO6KMnH2jX3Tg=; b=W/XlIb45DUWyXfJqS2V+DNIWA4NO+UI6p7qCWKXeqsPLz+BmjrTqOEEe4HcYZ/h8nvD6Y+ CG1m+9HRo8Le/EAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5874113AE0; Fri, 29 Apr 2022 09:41:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PuvFFLeya2IHCgAAMHmgww (envelope-from ); Fri, 29 Apr 2022 09:41:11 +0000 Message-ID: <6b31f436-5bfb-9d8f-9418-55036f342f2e@suse.cz> Date: Fri, 29 Apr 2022 11:41:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/2] mm: slab: fix comment for ARCH_KMALLOC_MINALIGN Content-Language: en-US To: andrey.konovalov@linux.dev, Andrew Morton Cc: Andrey Konovalov , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Peter Collingbourne , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov References: From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/28/22 17:59, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > The comment next to the ARCH_KMALLOC_MINALIGN definition says that > ARCH_KMALLOC_MINALIGN can be defined in arch headers. This is incorrect: > it's actually ARCH_DMA_MINALIGN that can be defined there. > > Fix the comment. > > Signed-off-by: Andrey Konovalov Thanks, added both patches to the slab tree. > --- > include/linux/slab.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 373b3ef99f4e..8cc1d54e56ad 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -190,7 +190,7 @@ void kmem_dump_obj(void *object); > /* > * Some archs want to perform DMA into kmalloc caches and need a guaranteed > * alignment larger than the alignment of a 64-bit integer. > - * Setting ARCH_KMALLOC_MINALIGN in arch headers allows that. > + * Setting ARCH_DMA_MINALIGN in arch headers allows that. > */ > #if defined(ARCH_DMA_MINALIGN) && ARCH_DMA_MINALIGN > 8 > #define ARCH_KMALLOC_MINALIGN ARCH_DMA_MINALIGN