From: Shixiong Ou <oushixiong1025@163.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.or, linux-kernel@vger.kernel.org,
Shixiong Ou <oushixiong@kylinos.cn>
Subject: Re: [PATCH] drm/sysfb: ofdrm: Fix is_avivo() constant comparison bug
Date: Fri, 24 Jul 2026 21:21:11 +0800 [thread overview]
Message-ID: <6b37e718-becc-41d0-8d94-5858293a2f3f@163.com> (raw)
In-Reply-To: <adae9260-e4ec-4be0-990a-825d4f2ff470@suse.de>
On 2026/7/24 19:34, Thomas Zimmermann wrote:
> Hi
>
> Am 24.07.26 um 11:41 schrieb oushixiong1025@163.com:
>> From: Shixiong Ou <oushixiong@kylinos.cn>
>>
>> The is_avivo() function has a logic error where it compares a constant
>> to another constant instead of checking the device parameter:
>>
>> (PCI_VENDOR_ID_ATI_R600 >= 0x9400)
>>
>> However, according to the code comment and the OFDRM_MODEL_AVIVO
>> definition ("ATI R5xx"), this function is intended to match only R5xx
>> cards (device IDs 0x7100-0x7800), not R6xx or later. The second
>> condition checking for R600 is erroneous and should be removed.
>>
>> Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
>> ---
>> drivers/gpu/drm/sysfb/ofdrm.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/sysfb/ofdrm.c
>> b/drivers/gpu/drm/sysfb/ofdrm.c
>> index a6dc34b9ec0f..ea1db1cfe3ed 100644
>> --- a/drivers/gpu/drm/sysfb/ofdrm.c
>> +++ b/drivers/gpu/drm/sysfb/ofdrm.c
>> @@ -238,8 +238,7 @@ static bool is_avivo(u32 vendor, u32 device)
>> {
>> /* This will match most R5xx */
>> return (vendor == PCI_VENDOR_ID_ATI) &&
>> - ((device >= PCI_VENDOR_ID_ATI_R520 && device < 0x7800) ||
>> - (PCI_VENDOR_ID_ATI_R600 >= 0x9400));
>
> I tried to match exactly this:
> https://elixir.bootlin.com/linux/v7.1.4/source/drivers/video/fbdev/offb.c#L365
>
> IDK if that works in practice, but I don't dare changing it without a
> concrete bug report.
>
> Best regards
> Thomas
>
Hi,
PCI_VENDOR_ID_ATI_R600 is defined as 0x9400 . Therefore, this expression
always evaluates to true (0x9400 >= 0x9400).
It does not depend on the device parameter passed to is_avivo().
So is this a coding mistake?
Best regards
Shixiong Ou.
>> + (device >= PCI_VENDOR_ID_ATI_R520 && device < 0x7800);
>> }
>> static enum ofdrm_model display_get_model_of(struct drm_device
>> *dev, struct device_node *of_node)
>
next prev parent reply other threads:[~2026-07-24 13:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 9:41 oushixiong1025
2026-07-24 11:34 ` Thomas Zimmermann
2026-07-24 13:21 ` Shixiong Ou [this message]
2026-07-24 14:42 ` Thomas Zimmermann
2026-08-25 10:41 oushixiong1025
2026-08-25 11:23 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b37e718-becc-41d0-8d94-5858293a2f3f@163.com \
--to=oushixiong1025@163.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.or \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=oushixiong@kylinos.cn \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®