From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752868AbdJLOrr (ORCPT ); Thu, 12 Oct 2017 10:47:47 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:45852 "EHLO mail-io0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752340AbdJLOrq (ORCPT ); Thu, 12 Oct 2017 10:47:46 -0400 X-Google-Smtp-Source: ABhQp+R7ivOQWuElBcR6yeK6hOxZXTXB1tHPoSMOCitq3NG1FDC1nokHfyA/+KkgRA5uxA4QuN6Jdw== Subject: Re: [PATCH] nullb: make config_item_type const To: Bhumika Goyal Cc: Julia Lawall , shli@fb.com, Linux Kernel Mailing List References: <1507803575-5749-1-git-send-email-bhumirks@gmail.com> <0cb128c9-75b0-946a-5f61-969374caa3ae@kernel.dk> From: Jens Axboe Message-ID: <6b3e0504-99f6-ee3f-d3da-2858d9a5ca04@kernel.dk> Date: Thu, 12 Oct 2017 08:47:43 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/2017 08:42 AM, Bhumika Goyal wrote: > On Thu, Oct 12, 2017 at 4:27 PM, Jens Axboe wrote: >> On 10/12/2017 04:19 AM, Bhumika Goyal wrote: >>> This is a followup patch for: https://lkml.org/lkml/2017/10/11/375 and >>> https://patchwork.kernel.org/patch/9999649/ >>> >>> Make these structures const as they are either passed to the functions >>> having the argument as const or stored as a reference in the "ci_type" >>> const field of a config_item structure. >> >> Thanks, applied. >> > > Hello, > > Actually, this patch is dependent on the patches in the links > https://lkml.org/lkml/2017/10/11/375 and > https://patchwork.kernel.org/patch/9999649/. Therefore, this patch > won't be correct unless the patches in these links gets applied. Gah, I do see that now. That should have been made much clearer in the patch description! When you send out patches with hard dependencies like that, either wait until the dependency has been solved in mainline, or make it explicitly clear in the patch submission. -- Jens Axboe