From: SF Markus Elfring <elfring@users.sourceforge.net>
To: "Jörg Rödel" <joro@8bytes.org>, iommu@lists.linux-foundation.org
Cc: David Woodhouse <dwmw2@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Intel-IOMMU: Delete an error message for a failed memory allocation in init_dmars()
Date: Sat, 20 Jan 2018 15:55:37 +0100 [thread overview]
Message-ID: <6b452dfb-b2fc-2417-26b3-bbcdf11ed06f@users.sourceforge.net> (raw)
In-Reply-To: <20180120133452.GB28161@8bytes.org>
>> Date: Sat, 20 Jan 2018 13:51:49 +0100
>>
>> Omit an extra message for a memory allocation failure in this function.
>>
>> This issue was detected by using the Coccinelle software.
>>
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>
> NACK on this one and the other two IOMMU patches you sent.
Do you need any more background information for this general transformation pattern?
> The messages give the user/developer useful information about what the memory
> that failed to allocate would have been used for.
Do you find the Linux allocation failure report insufficient for this use case?
Regards,
Markus
next prev parent reply other threads:[~2018-01-20 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 13:00 SF Markus Elfring
2018-01-20 13:34 ` Jörg Rödel
2018-01-20 14:55 ` SF Markus Elfring [this message]
2018-01-20 19:40 ` Jörg Rödel
2018-01-21 1:37 ` Joe Perches
2018-01-21 7:19 ` Jörg Rödel
2018-01-21 19:37 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b452dfb-b2fc-2417-26b3-bbcdf11ed06f@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome