From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1608B1C4EF9 for ; Tue, 27 Aug 2024 14:41:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724769715; cv=none; b=HQbqsurUHxDdCYV1Oy5qIGm7Cs98dxiLoTg4ldoinvAabt7fkVvCoxnwRDhzjWBpQcyiend4paRU51/lEGY1WKXWt3VaLoXNBLD0u7cUWoDDdlhe6Oy0R3rGPOK94O1DWwys2CPNS/kumlzM/RCYxYpUSwlNE7pgkCIhNFpsY3w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724769715; c=relaxed/simple; bh=H+6cCp+741S1jmZeN1/j+eaIKgM43f89iZXxvad582Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qdrXPIC6zch+ML8jZLKB/kDx/n7zuX29MZr3YMSkTp62F0O/MFhY7kw8iq5kVV6zd0+eLDRPEHWPVgQnkl9XiZN3qGZU7EDq2/H4c6fX8/O9b/2ZiTavYgR8+YqXJlMgB1OyrkDd/OZqihmAxoAkQUgH4S+6RFhMTF2UhU4iRfQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kCTFrcNo; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kCTFrcNo" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3718cea0693so206328f8f.2 for ; Tue, 27 Aug 2024 07:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724769712; x=1725374512; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=eeFJp64j8+utoarUzbDHezpPIBUD0Z7OIl2+BjKQ8mE=; b=kCTFrcNoOsBtbodILfkOr/XO5kqwnQoM6a9Aa3SnETDNcOpGO6qllNn5mbkbFtQOHx B8GZtE75I+Jv1vWZhXdnaGd9YtR0TBCRCOWwCTWdQcTuqOI0Nu978mrUv8BWykS5FBJC 5Rx7nIohK4HZBiRiUY22ir8i1eqLGeGl5E3T2C7/FVc2RiHkWSzMOlKIODrq6WWXH5ii MDmIW4KJz3/CbZdj6+9eGfGstNzp9iNe6ObRHbRaucb0sijZw/9xPL7Exey6b1DoHuSK qK5XkyXjRN3Evu2GrSdNDarf72pbvvSNWZpUuij10q24ctyQh5QL/oERhEDhIK2npWBO vGpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724769712; x=1725374512; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eeFJp64j8+utoarUzbDHezpPIBUD0Z7OIl2+BjKQ8mE=; b=c55fzF6MKaW3K7TRX1ex3TF8fqpeRNjcUDXxJ4RFJCsRw2yqsaf95l30kiZP9U4FOk 9YPf4i3V8+mhJgL7jniRdsq2GlKxeHWOL+mJC8hHVQlCtF4mAoUS+upbzdhk3eXsJzyw Iv0PQwo/E8BiR4Dims3u6wAA3eBpuneiPP/R7ktAA/uGXDc7EbrALL0Fo7wxRi5I37ia mp+lbtQ5rWUFFPfe3zuob2KlyWuzqtzoPihwEp+nmYGd7irQhud4hsibTo/5Ep3nN7ld 7tM7N/cOBfENkjR5KsARjQynwmE8IbdaQoidmlKKy6d6dC+gfenkAvFgFQTqgC98zU7O EfPg== X-Forwarded-Encrypted: i=1; AJvYcCWBR6c6YogQpUHhHAOHR95nln+h5PFbkSQPl8AxoX9IaSQ9JkUBCpDmrcII7kj2wsNBSti1koQmJVAJzus=@vger.kernel.org X-Gm-Message-State: AOJu0YxszNAnbcsIym2IznJZm806xCmKx4dVzNfZzP8MBRKplEoJMTpY 1YKJYtZPeUJM+RKEw0/dL+6WtlvkpqWgD85FuqqHc4hxBvzPmMeWjt723u/Zw3g= X-Google-Smtp-Source: AGHT+IEER2p+CG0AK10idopzDFngjXs66PqSkE0h5u8xVVMh/bzYLQ3F6Xn8jaT6l+lLmA5+Mb9rEg== X-Received: by 2002:a5d:6d05:0:b0:367:9495:9016 with SMTP id ffacd0b85a97d-373118e9996mr5511256f8f.6.1724769712319; Tue, 27 Aug 2024 07:41:52 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.82]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3730811001fsm13298892f8f.20.2024.08.27.07.41.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Aug 2024 07:41:51 -0700 (PDT) Message-ID: <6b483487-1806-424c-8237-07c0de481790@linaro.org> Date: Tue, 27 Aug 2024 16:41:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] net: hisilicon: hip04: fix OF node leak in probe() To: Simon Horman Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Salil Mehta , Yisen Zhuang , LKML References: <20240825185311.109835-1-krzysztof.kozlowski@linaro.org> <20240827144010.GD1368797@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240827144010.GD1368797@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 27/08/2024 16:40, Simon Horman wrote: > On Sun, Aug 25, 2024 at 09:21:31PM +0200, Markus Elfring wrote: >>> Driver is leaking OF node reference from >>> of_parse_phandle_with_fixed_args() in probe(). >> >> * Is there a need to improve such a change description another bit? >> >> + Imperative mood >> >> * Tags like “Fixes” and “Cc” > > I think it would be helpful if these were either explicitly targeted for > net-next without Fixes tags (the assumed state of affairs as-is). > > Subject: [Patch x/n net-next] ... > > Or targeted at net, with Fixes tags > > Subject: [Patch x/n net] ... > > I guess that in theory these are fixes, as resource leaks could occur. > But perhaps that is more theory that practice. I am unsure. I'll resend with net-next. Best regards, Krzysztof