mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laura Abbott <labbott@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Andy Lutomirski <luto@amacapital.net>
Cc: Andrew Lutomirski <luto@kernel.org>,
	mjw@fedoraproject.org, "H.J. Lu" <hjl.tools@gmail.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	nickc@redhat.com, ccoutant@gmail.com,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO
Date: Wed, 23 May 2018 18:36:08 -0700	[thread overview]
Message-ID: <6b4c2c4f-00db-22b7-db3a-a1e76899c6d0@redhat.com> (raw)
In-Reply-To: <CA+55aFxXCWc5qCAsuRmrCGqL7ws4f6B_zy1WR98kHgr_XZs3fw@mail.gmail.com>

On 05/23/2018 05:06 PM, Linus Torvalds wrote:
> 
> 
> On Wed, May 23, 2018, 17:01 Andy Lutomirski <luto@amacapital.net <mailto:luto@amacapital.net>> wrote:
> 
> 
>     I don’t know whether I’m missing something obvious, but can’t this be in C?
> 
> 
> Yes, but I thought Laura wanted to limit it to linker file tricks (this thread has gone on for so long that I've forgotten the details of why).
> 
>         Linus
> 
> 

So we have to update the kernel and every module and the easiest way
to do that was the linker script. I was assuming I'd just use the
same approach for the vDSO but you're right that there's no reason
we can't apply a different technique. I notice there's already a
vdso-note.S which adds LINUX_VERSION_CODE as a note. This doesn't
include the extra version so it doesn't quite meet our needs.
There's no reason why we can't throw something else in there for
good measure.

Thanks,
Laura

  parent reply	other threads:[~2018-05-24  1:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23  0:19 [PATCHv3 0/2] Salted build ids via linker sections Laura Abbott
2018-05-23  0:19 ` [PATCHv3 1/2] kbuild: Introduce build-salt linker script Laura Abbott
2018-05-23  0:19 ` [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO Laura Abbott
2018-05-23  0:33   ` Andy Lutomirski
2018-05-23  1:23     ` Laura Abbott
2018-05-23 22:53     ` Laura Abbott
2018-05-23 23:55       ` Linus Torvalds
2018-05-24  0:01         ` Andy Lutomirski
     [not found]           ` <CA+55aFxXCWc5qCAsuRmrCGqL7ws4f6B_zy1WR98kHgr_XZs3fw@mail.gmail.com>
2018-05-24  1:36             ` Laura Abbott [this message]
2018-05-24  0:11       ` Masahiro Yamada
2018-05-24  1:43         ` Masahiro Yamada
2018-05-24  2:16           ` Laura Abbott
2018-05-24  1:55   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b4c2c4f-00db-22b7-db3a-a1e76899c6d0@redhat.com \
    --to=labbott@redhat.com \
    --cc=ccoutant@gmail.com \
    --cc=hjl.tools@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=luto@kernel.org \
    --cc=mjw@fedoraproject.org \
    --cc=nickc@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®