From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Tom Rix <trix@redhat.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"nathan@kernel.org" <nathan@kernel.org>,
"ndesaulniers@google.com" <ndesaulniers@google.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>
Subject: Re: [PATCH] scsi: target: core: remove unused prod_len variable
Date: Wed, 29 Mar 2023 21:07:36 +0000 [thread overview]
Message-ID: <6b50e660-f10d-82ae-4a15-86fb575dcab5@nvidia.com> (raw)
In-Reply-To: <20230329132421.1809362-1-trix@redhat.com>
On 3/29/23 06:24, Tom Rix wrote:
> clang with W=1 reports
> drivers/target/target_core_spc.c:229:6: error: variable
> 'prod_len' set but not used [-Werror,-Wunused-but-set-variable]
> u32 prod_len;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2023-03-29 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 13:24 Tom Rix
2023-03-29 21:07 ` Chaitanya Kulkarni [this message]
2023-04-12 2:04 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b50e660-f10d-82ae-4a15-86fb575dcab5@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=target-devel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®