From: "yu kuai" <yukuai@fygo.io>
To: "Abd-Alrhman Masalkhi" <abd.masalkhi@gmail.com>,
<song@kernel.org>, <yukuai@fygo.io>, <magiclinan@didiglobal.com>,
<xiao@kernel.org>, <vverma@digitalocean.com>, <axboe@kernel.dk>
Cc: <linux-raid@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"sashiko-bot" <sashiko-bot@kernel.org>, <yukuai@fygo.io>
Subject: Re: [PATCH] md/raid1: free r1_bio when REQ_NOWAIT is set and read would block on retry
Date: Sun, 21 Jun 2026 04:30:35 +0800 [thread overview]
Message-ID: <6b5204ab-dd2e-460c-b2cc-2ed04f6fa816@fygo.io> (raw)
In-Reply-To: <20260611101350.759154-1-abd.masalkhi@gmail.com>
在 2026/6/11 18:13, Abd-Alrhman Masalkhi 写道:
> When a read is retried, raid1_read_request() may be called with a
> pre-allocated r1_bio. If wait_read_barrier() fails for a REQ_NOWAIT
> read, the bio is completed and the function returns immediately. In this
> case the existing r1_bio is leaked.
>
> This fixes a leak of pre-allocated r1_bio structures for retried reads.
>
> Fixes: 5aa705039c4f ("md: raid1 add nowait support")
> Reported-by: sashiko-bot<sashiko-bot@kernel.org>
> Closes:https://sashiko.dev/#/patchset/20260611083514.754922-1-abd.masalkhi@gmail.com?part=1
> Signed-off-by: Abd-Alrhman Masalkhi<abd.masalkhi@gmail.com>
> ---
> drivers/md/raid1.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Applied to md-7.2
--
Thanks,
Kuai
prev parent reply other threads:[~2026-06-20 20:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 10:13 Abd-Alrhman Masalkhi
2026-06-20 20:30 ` yu kuai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b5204ab-dd2e-460c-b2cc-2ed04f6fa816@fygo.io \
--to=yukuai@fygo.io \
--cc=abd.masalkhi@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=magiclinan@didiglobal.com \
--cc=sashiko-bot@kernel.org \
--cc=song@kernel.org \
--cc=vverma@digitalocean.com \
--cc=xiao@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®