From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3A5872D8DCA for ; Tue, 14 Jul 2026 05:05:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784005511; cv=none; b=PMlbB6RDtOm+jo6AJyYxjBU9HSvWGhpuR4TcSk82Wl/Ked6daVV0hoHIDug8jfCJa82RbkMTo6whmZP6iWlQvzT9V+ry+r4QpLBvciGij1lAUYT/u3pgR3lEyD0ci9xJnZarHAtibT5jfksLlni+9PkG9h/gJIlsi0MOwyzvZDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784005511; c=relaxed/simple; bh=qT2mgHMj6QJLWSA0zgmN/WGwxPyCB1BtgvzkcnB5MEE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VnL2lujpQHR3TGixhTJ3GcutL7hkOwuN1jl73HHwSqaQin11oauRJhJUEejHrtG32LjgsPDuWpUA4J6Ixlv3U8E6pgHIU6rgkk4LG2rYkwnbv3O1w3lGVPnHlEdGNgJK2JV2ZBQRs94OOFZUFW76y5e1kRmcAV13gIG7WWsR1Zs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=IskI8LYM; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="IskI8LYM" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E2101570; Mon, 13 Jul 2026 22:05:04 -0700 (PDT) Received: from [10.164.148.52] (unknown [10.164.148.52]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 22C9D3F7D8; Mon, 13 Jul 2026 22:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1784005508; bh=qT2mgHMj6QJLWSA0zgmN/WGwxPyCB1BtgvzkcnB5MEE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IskI8LYMi4GXyfPv7L8xPVpvWDxpiq8313AKc2M43sY5KWhxkTyocowGn4AGEEyJv h44kaMYYonhUoEWFqSxZ0jdW4tTEI3H2Xaqo/l/lc9ViKG0y333AP70WBnwJ1SDx3L 9P/n83Am3WBMzsWH5EFM54C0a4T+luMARG5rJaxE= Message-ID: <6b526275-0e43-413e-adfe-b466155d9ae0@arm.com> Date: Tue, 14 Jul 2026 10:35:00 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 6/6] mm/vmalloc: align vm_area so vmap() can batch mappings To: Wen Jiang , akpm@linux-foundation.org, catalin.marinas@arm.com, linux-mm@kvack.org, urezki@gmail.com, will@kernel.org Cc: Xueyuan.chen21@gmail.com, ajd@linux.ibm.com, anshuman.khandual@arm.com, david@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, rppt@kernel.org, ryan.roberts@arm.com, "Barry Song (Xiaomi)" , Wen Jiang , Leo Yan References: <20260709073823.6643-1-jiangwen6@xiaomi.com> <20260709073823.6643-7-jiangwen6@xiaomi.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20260709073823.6643-7-jiangwen6@xiaomi.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/07/26 1:08 pm, Wen Jiang wrote: > From: "Barry Song (Xiaomi)" > > Try to align the vmap virtual address to PMD_SHIFT or a > larger PTE mapping size hinted by the architecture, so > contiguous pages can be batch-mapped when setting PMD or > PTE entries. We do not expect any significant overhead for > this. > > Add __get_vm_area_node_aligned_caller() as a wrapper over > __get_vm_area_node() to simplify repeated calls with fixed > arguments. > > Signed-off-by: Barry Song (Xiaomi) > Signed-off-by: Wen Jiang > Tested-by: Xueyuan Chen > Tested-by: Leo Yan > Reviewed-by: Uladzislau Rezki (Sony) > --- Reviewed-by: Dev Jain > mm/vmalloc.c | 35 ++++++++++++++++++++++++++++++++++- > 1 file changed, 34 insertions(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index db0492151ad08..2ac805cdf18ad 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3314,6 +3314,14 @@ struct vm_struct *get_vm_area_caller(unsigned long size, unsigned long flags, > NUMA_NO_NODE, GFP_KERNEL, caller); > } > > +static struct vm_struct *__get_vm_area_node_aligned_caller(unsigned long size, > + unsigned long align, unsigned long flags, const void *caller) > +{ > + return __get_vm_area_node(size, align, PAGE_SHIFT, flags, > + VMALLOC_START, VMALLOC_END, > + NUMA_NO_NODE, GFP_KERNEL, caller); > +} > + > /** > * find_vm_area - find a continuous kernel virtual area > * @addr: base address > @@ -3626,6 +3634,30 @@ static int vmap_pages_range_batched(unsigned long addr, unsigned long end, > return err; > } > > +static struct vm_struct *vmap_get_aligned_vm_area(unsigned long size, > + unsigned long flags, pgprot_t prot, const void *caller) > +{ > + struct vm_struct *vm_area; > + unsigned int shift; > + > + if (arch_vmap_pmd_supported(prot) && size >= PMD_SIZE) { > + vm_area = __get_vm_area_node_aligned_caller(size, PMD_SIZE, > + flags, caller); > + if (vm_area) > + return vm_area; > + } > + > + shift = arch_vmap_pte_supported_shift(size); > + if (shift > PAGE_SHIFT) { > + vm_area = __get_vm_area_node_aligned_caller(size, 1UL << shift, > + flags, caller); > + if (vm_area) > + return vm_area; > + } > + > + return __get_vm_area_node_aligned_caller(size, PAGE_SIZE, flags, caller); > +} > + > /** > * vmap - map an array of pages into virtually contiguous space > * @pages: array of page pointers > @@ -3664,7 +3696,8 @@ void *vmap(struct page **pages, unsigned int count, > return NULL; > > size = (unsigned long)count << PAGE_SHIFT; > - area = get_vm_area_caller(size, flags, __builtin_return_address(0)); > + area = vmap_get_aligned_vm_area(size, flags, prot, > + __builtin_return_address(0)); > if (!area) > return NULL; >