From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38BE138C414 for ; Wed, 8 Jul 2026 08:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783500083; cv=none; b=n6mO/8jJBnKvNwuYW7OUwjti1ZKzOhKNQbz3g6LSqRXLWyVQ2HfkWrkLR2NDyPjyftuhApedymUXUCtPmDVjmGQo/320WVv7uht+2jK/U9QPI4BghLxo14bCCV0OmAJu4zQ1Uv20ytYErEup4pz+Muc1JBzVW2j8tXkLoppI4o0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783500083; c=relaxed/simple; bh=CaAJ7HYKzvyC411ua2eBPgcGy5Mkp+vj2eWyIKZJ/cE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l/ZNEl/SZVdnhAh/KzMm3KCHQ68HGisWLovdoR1VDvOeGGkQ7OnQ7l5mdyWJmsDTK9AeVYPXJYo5MePEDT1O2gyeclMYPWmexa79/Th4n9xjWOseDY3MZiJY0EQGB1SJQH607BVZ99ec9WGTurapmOF1BmCDQY+zKqu/Opn81II= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ursulin.net; spf=pass smtp.mailfrom=ursulin.net; dkim=pass (2048-bit key) header.d=ursulin.net header.i=@ursulin.net header.b=GMff3dRT; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ursulin.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ursulin.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ursulin.net header.i=@ursulin.net header.b="GMff3dRT" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-6989c0ec3c5so738275a12.2 for ; Wed, 08 Jul 2026 01:41:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ursulin.net; s=google; t=1783500080; x=1784104880; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3DZTTXE9BUksJ1j2NPuZCs/kRS4hcs1yGW38pGmaPVA=; b=GMff3dRT3qoEFJc4+SrmEfwIO9iz/Uzvvbt0mBO+rjYY1h25Ggd3jbKJaLe/+yOt4R nfq7qaPS/AMm8DPzkRNVzVWQIujW+CMG01KqTce2lo0xRFWlunDUmOZg6ElJc9He0EIc ozkxtcUgzeJI351DUhZwLmGJTqG2UnxBGXcUsbZNT6hfxnatH+/eyZo4jIGFDx09z1Km gtfOo9CnE8T2ysMVMsPy8PJvDPXWJi4fc1vtcx0V6w8lxVWYnXClZqubUU12HTZxoBoU yYje55jgT/wQkkwEQbAd56jk448vSFrRBj7nNg3GBp/4l9AcVQW2ZwgA6S/DFBTP7ZJz uILg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783500080; x=1784104880; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3DZTTXE9BUksJ1j2NPuZCs/kRS4hcs1yGW38pGmaPVA=; b=kPwcqiHTEwJR16oavwlxpjz7fInSfZqzAyORzgweSqrz9mZUYFOqpD345LvcnkgmQs GBaBm8/fd+dONwoxj9q+crMdKg64THw4/M5BBtTXGmuKHA8aoK6j22NQfviYeQ45iljN yIzNVlgRB/5jdQmrK9o1D+oAkOlIYXobybzO6bAgaP2xVNNAjSEMWm1ErO66b46JwVn+ sncME0uToBmwjr+TtGRjlPq0lGdfCl1XBgtXut7qVGrBDIozhfzfQNX8E+7zkK5ZyCG/ M9ZD0uvcIopu1ytvcjx0jbg8DOL+gzBaumjuTrtmjIvRSg5qqET4nO8OAJ5amRfG99A/ Fwyg== X-Forwarded-Encrypted: i=1; AHgh+RoXfEFhEcGSeNvpuNt9g06pMw43OmRIzr/EkPoU3XDW4m7GBmarcij2R+43f5Bum5qAuiFLECdtttrOk4c=@vger.kernel.org X-Gm-Message-State: AOJu0YzJS14dbpgtd5fnU6tz3ViPGoVI3fHzuuU8+JdOaOKgxv1dDNol W4TW7DlZxKV3TE9NoHy2pBUAiobGV9SiVh+nF02GxFAbGuFQxtx1IBaAa9/VMwhMIfo= X-Gm-Gg: AfdE7cndnynt2Zq6sUDtfR06n1+n5H5iu40xk3mZd5UpAE60WLP8bKz90SlxV0957Ew 5dEo51zsYAoMKaYPMWX9pJFRID731BBjByLSvdFfx9TX+FtEbxV4roy7vNysloyf8WFpJCj56SM ce/QxrYtpEAVC7MhV12D/sVBziXFvihOvtvsWZ/JRCpFPEXnjNb5/CvPNiO0jRqJl/EsY/+cH66 D52ms1bym11DYSAXr6eCJexROlSNXa30qywKZ46TWoIIqTihnIQETIdpGEe3oJ+bqvPu61BAtYg 0I/Q46X/mktlzf+RYro8bZC46FJlm9PQU3nB0Y7Y/6qoUWZ+W9fur4Pvbj7ZcLecbQG/V6EM+eG hNnL9k+RndNHTZF7lllnShisjckbXAgfrNNS7/7O+lp6O0B1T7wgnnqKySX7HTi/DOtVfuPgfrX FWJh6CZSjKzlkzDbeN/8kP4biB82yPICOwIg== X-Received: by 2002:a05:6402:2755:b0:697:5140:a146 with SMTP id 4fb4d7f45d1cf-69ab445334cmr563051a12.5.1783500080309; Wed, 08 Jul 2026 01:41:20 -0700 (PDT) Received: from [192.168.0.116] ([90.240.106.137]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69ac41d7ceesm160654a12.23.2026.07.08.01.41.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 01:41:19 -0700 (PDT) Message-ID: <6b551a44-96fe-4429-a337-9e6a32ac5156@ursulin.net> Date: Wed, 8 Jul 2026 09:41:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/i915/gt: use correct selftest config symbol To: Pengpeng Hou , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Simona Vetter , Thomas Zimmermann Cc: Daniele Ceraolo Spurio , Chris Wilson , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260705080225.436-1-pengpeng@iscas.ac.cn> Content-Language: en-GB From: Tvrtko Ursulin In-Reply-To: <20260705080225.436-1-pengpeng@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/07/2026 09:02, Pengpeng Hou wrote: > intel_engine_user.c checks CONFIG_DRM_I915_SELFTESTS before running > the engine UABI isolation check. Kconfig defines DRM_I915_SELFTEST, > without the trailing "S", and the rest of i915 uses > CONFIG_DRM_I915_SELFTEST. > > Because CONFIG_DRM_I915_SELFTESTS is not backed by any Kconfig symbol, > the IS_ENABLED() test is always false. Use the existing selftest symbol > so the debug/selftest guarded path can be reached when selftests are > enabled. > > This is a source-level fix. It does not claim dynamic hardware > reproduction; the evidence is the Kconfig definition and the inconsistent > guard in intel_engine_user.c. > > Fixes: 750e76b4f9f6 ("drm/i915/gt: Move the [class][inst] lookup for engines onto the GT") > Signed-off-by: Pengpeng Hou > --- > drivers/gpu/drm/i915/gt/intel_engine_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_user.c b/drivers/gpu/drm/i915/gt/intel_engine_user.c > index be4bbff1a57c..d5190e11b270 100644 > --- a/drivers/gpu/drm/i915/gt/intel_engine_user.c > +++ b/drivers/gpu/drm/i915/gt/intel_engine_user.c > @@ -259,7 +259,7 @@ > p = &prev->rb_right; > } > > - if (IS_ENABLED(CONFIG_DRM_I915_SELFTESTS) && > + if (IS_ENABLED(CONFIG_DRM_I915_SELFTEST) && > IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) { > struct intel_engine_cs *engine; > unsigned int isolation; Looks correct but we need to have a test run done to see that the checks this guards actually pass. Please stay tuned for results and please do ping us in a week or so if we forget. Regards, Tvrtko