From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66E51C43331 for ; Fri, 6 Sep 2019 14:50:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DDFC206A5 for ; Fri, 6 Sep 2019 14:50:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394629AbfIFOuW (ORCPT ); Fri, 6 Sep 2019 10:50:22 -0400 Received: from mga06.intel.com ([134.134.136.31]:60335 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729121AbfIFOuW (ORCPT ); Fri, 6 Sep 2019 10:50:22 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Sep 2019 07:50:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,473,1559545200"; d="scan'208";a="185802221" Received: from spandruv-mobl3.jf.intel.com ([10.251.22.142]) by orsmga003.jf.intel.com with ESMTP; 06 Sep 2019 07:50:21 -0700 Message-ID: <6b576770a4bbe6c24ea524083dec5a16bf3c9e94.camel@linux.intel.com> Subject: Re: [PATCH 2/2] tools/power/x86/intel-speed-select: Display core count for bucket From: Srinivas Pandruvada To: Andy Shevchenko , Prarit Bhargava Cc: darcari@redhat.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Date: Fri, 06 Sep 2019 07:50:21 -0700 In-Reply-To: <20190906134655.GU2680@smile.fi.intel.com> References: <20190905233748.6822-1-srinivas.pandruvada@linux.intel.com> <20190905233748.6822-2-srinivas.pandruvada@linux.intel.com> <780a3faf-9e44-64f4-a354-bdee39af3af5@redhat.com> <20190906134655.GU2680@smile.fi.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-3.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-09-06 at 16:46 +0300, Andy Shevchenko wrote: > On Fri, Sep 06, 2019 at 05:39:54AM -0400, Prarit Bhargava wrote: > > On 9/5/19 7:37 PM, Srinivas Pandruvada wrote: > > > Read the bucket and core count relationship via MSR and display > > > when displaying turbo ratio limits. > > > + ret = isst_send_msr_command(cpu, 0x1ae, 0, buckets_info); > > > > ^^^ you can get rid of the magic number 0x1ae by doing (sorry for > > the cut-and-paste) > > > > diff --git a/tools/power/x86/intel-speed-select/Makefile > > b/tools/power/x86/intel > > index 12c6939dca2a..087d802ad844 100644 > > --- a/tools/power/x86/intel-speed-select/Makefile > > +++ b/tools/power/x86/intel-speed-select/Makefile > > @@ -15,6 +15,8 @@ endif > > MAKEFLAGS += -r > > > > override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include > > +override CFLAGS += -I../../../include > > +override CFLAGS += > > -DMSRHEADER='"../../../../arch/x86/include/asm/msr-index.h"' No, we can't use msr_index. > > I guess it can be done in more neat way. > > > As I've been looking at this code I have been wondering why didn't > > you just use > > the standard /dev/cpu/X/msr interface that other x86 power > > utilities (turbostat, > > x86_energy_perf_policy) use? Implementing msr_read() is trivial > > (warning > > untested and uncompiled code) No. We can't. The MSR interface is disabled on several distribution and platforms with secured boot. So some special MSRs are only allowed via this IOCTL interface. Thanks, Srinivas > > Actually good point! >