From: Alex Elder <elder@linaro.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, evgreen@chromium.org,
subashab@codeaurora.org, cpratapa@codeaurora.org,
bjorn.andersson@linaro.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: ipa: always report GSI state errors
Date: Mon, 29 Jun 2020 20:03:26 -0500 [thread overview]
Message-ID: <6b5baacc-3ae0-e801-1db7-d40dae560094@linaro.org> (raw)
In-Reply-To: <20200629170912.39188c5b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 6/29/20 7:09 PM, Jakub Kicinski wrote:
> On Mon, 29 Jun 2020 16:37:36 -0500 Alex Elder wrote:
>> We check the state of an event ring or channel both before and after
>> any GSI command issued that will change that state. In most--but
>> not all--cases, if the state is something different than expected we
>> report an error message.
>>
>> Add error messages where missing, so that all unexpected states
>> provide information about what went wrong. Drop the parentheses
>> around the state value shown in all cases.
>>
>> Signed-off-by: Alex Elder <elder@linaro.org>
>
> nit:
Sorry about that. I'll fix this and run checkpatch on v2.
Thanks for your quick review.
-Alex
> CHECK: Alignment should match open parenthesis
> #105: FILE: drivers/net/ipa/gsi.c:1673:
> + dev_warn(dev,
> + "limiting to %u channels; hardware supports %u\n",
>
> CHECK: Alignment should match open parenthesis
> #120: FILE: drivers/net/ipa/gsi.c:1685:
> + dev_warn(dev,
> + "limiting to %u event rings; hardware supports %u\n",
>
next prev parent reply other threads:[~2020-06-30 1:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 21:37 [PATCH net-next 0/3] net: ipa: small improvements Alex Elder
2020-06-29 21:37 ` [PATCH net-next 1/3] net: ipa: always report GSI state errors Alex Elder
2020-06-30 0:09 ` Jakub Kicinski
2020-06-30 1:03 ` Alex Elder [this message]
2020-06-29 21:37 ` [PATCH net-next 2/3] net: ipa: standarize more GSI error messages Alex Elder
2020-06-29 21:37 ` [PATCH net-next 3/3] net: ipa: kill IPA_MEM_UC_OFFSET Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b5baacc-3ae0-e801-1db7-d40dae560094@linaro.org \
--to=elder@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®