From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B87C4C3279D for ; Wed, 7 Oct 2020 02:54:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4044F207EA for ; Wed, 7 Oct 2020 02:54:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qehWR4LY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727099AbgJGCyu (ORCPT ); Tue, 6 Oct 2020 22:54:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726627AbgJGCyt (ORCPT ); Tue, 6 Oct 2020 22:54:49 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92AF2C061755 for ; Tue, 6 Oct 2020 19:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Date:Message-ID:Subject:From:Cc:To:Sender:Reply-To:Content-ID: Content-Description:In-Reply-To:References; bh=Kfn1EjIw61OOA6atfqtDsUyZD8OZlfnAF20PJC2dm14=; b=qehWR4LYimU3auLImYdY7dy5xT qJQ7N/N3RyKgXPBBGJYKenvFHzkRm0aP5DoMQ6DGuzp7kbj88LGDpZobZVYOq+KTpLb3Ws0H0gEJJ IrwCgHI6Lz1Iu127MZ7tZ9ovdDvIP4MEjIO206vqEC4Aa1haNrPBcr40VsRTJDbSdg0zvbQbXYIUk N9qUoTB3J73qcHt8uu/vJKNlQl8dXXsI5VB7doSJ8ZxVzCjsip4lJe9+mlP7fROSXTEZomxi5C4Ux SeYr8zbaP9gWNhZyg8dwsv7anSol1N7Ff9jeXVxsSjv5Bwex6spTxEHGQ2Am/A9i/FvSHfHCmpa1a WgQks5Rw==; Received: from [2601:1c0:6280:3f0::2c9a] by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPzbI-0004UB-3H; Wed, 07 Oct 2020 02:54:44 +0000 To: LKML , Vineet Gupta , "linux-snps-arc@lists.infradead.org" , Dan Williams Cc: kernel test robot From: Randy Dunlap Subject: [PATCH] fs: dax: fix build error on ARC Message-ID: <6b5c6090-331d-7485-da4a-45e9c7f13be1@infradead.org> Date: Tue, 6 Oct 2020 19:54:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap fs/dax.c uses copy_user_page() but ARC does not provide that interface, resulting in a build error. Provide copy_user_page() in (beside copy_page()) and add to fs/dax.c to fix the build error. ../fs/dax.c: In function 'copy_cow_page_dax': ../fs/dax.c:702:2: error: implicit declaration of function 'copy_user_page'; did you mean 'copy_to_user_page'? [-Werror=implicit-function-declaration] Fixes: cccbce671582 ("filesystem-dax: convert to dax_direct_access()") Reported-by: kernel test robot Signed-off-by: Randy Dunlap Cc: Vineet Gupta Cc: linux-snps-arc@lists.infradead.org Cc: Dan Williams --- Vineet, This patch fixes the build error but is it correct for ARC? arch/arc/include/asm/page.h | 1 + fs/dax.c | 1 + 2 files changed, 2 insertions(+) --- lnx-59-rc7.orig/fs/dax.c +++ lnx-59-rc7/fs/dax.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #define CREATE_TRACE_POINTS --- lnx-59-rc7.orig/arch/arc/include/asm/page.h +++ lnx-59-rc7/arch/arc/include/asm/page.h @@ -10,6 +10,7 @@ #ifndef __ASSEMBLY__ #define clear_page(paddr) memset((paddr), 0, PAGE_SIZE) +#define copy_user_page(to, from, vaddr, pg) copy_page(to, from) #define copy_page(to, from) memcpy((to), (from), PAGE_SIZE) struct vm_area_struct;