mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: Cristina Moraru <cristina.moraru09@gmail.com>,
	"jic23@kernel.org" <jic23@kernel.org>,
	"knaack.h@gmx.de" <knaack.h@gmx.de>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"daniel.baluta@intel.com" <daniel.baluta@intel.com>,
	"octavian.purdila@intel.com" <octavian.purdila@intel.com>
Subject: RE: [PATCH] iio: max5487: Add support for Maxim digital potentiometers
Date: Fri, 25 Mar 2016 10:20:34 +0000	[thread overview]
Message-ID: <6b5caa6c47c34d5eaa302dccf8dd89aa@EMAIL.axentia.se> (raw)
In-Reply-To: <1458818485-2770-1-git-send-email-cristina.moraru09@gmail.com>

Hi again,

Cristina Moraru wrote:
> Add implementation for Maxim MAX5487, MAX5488, MAX5489
> digital potentiometers.
> 
> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
> CC: Daniel Baluta <daniel.baluta@intel.com>

Some more comments, the mcp4531 chips have n**2 + 1 positions,
therefore .max_pos in that driver isn't the number of wiper positions, it's
the actual maximum value. So, in this driver, the corrent number for
.max_pos would be 255, otherwise the reported scale is wrong (and then
you also need to adjust the EINVAL check in max5487_write_raw to use >
instead of >=).

Further comparison with the mcp4531 driver reveals that this driver does
not support IIO_CHAN_INFO_RAW in max5487_read_raw. I assume the SPI
interface does not support reading back the current value?

Cheers,
Peter

  parent reply	other threads:[~2016-03-25 10:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 11:21 Cristina Moraru
2016-03-24 11:42 ` Daniel Baluta
2016-03-24 21:46 ` Peter Rosin
2016-04-01  8:28   ` Daniel Baluta
2016-04-03  9:25     ` Jonathan Cameron
2016-03-25 10:20 ` Peter Rosin [this message]
2016-04-01  8:33   ` Daniel Baluta
2016-04-09  8:24 ` [PATCH v2] " Cristina Moraru
2016-04-10 11:24   ` Jonathan Cameron
2016-04-10 12:47   ` Joachim Eastwood
2016-04-10 13:10     ` Joachim Eastwood
2016-05-17 13:11 ` [PATCH v3] " Cristina Moraru
2016-05-17 13:33   ` Peter Meerwald-Stadler
2016-05-19  2:21   ` Matt Ranostay
2016-05-18  9:15 ` [PATCH v4] " Cristina Moraru
2016-05-19  5:55 ` [PATCH v5] " Cristina Moraru
2016-05-21 19:14   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b5caa6c47c34d5eaa302dccf8dd89aa@EMAIL.axentia.se \
    --to=peda@axentia.se \
    --cc=cristina.moraru09@gmail.com \
    --cc=daniel.baluta@intel.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=octavian.purdila@intel.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®