From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934502AbdJJUb2 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Oct 2017 16:31:28 -0400
Received: from esa2.dell-outbound.iphmx.com ([68.232.149.220]:26310 "EHLO
        esa2.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S934184AbdJJUbZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Oct 2017 16:31:25 -0400
From: <Mario.Limonciello@dell.com>
X-LoopCount0: from 10.166.132.189
X-IronPort-AV: E=Sophos;i="5.43,359,1503378000"; 
   d="scan'208";a="560592210"
X-DLP: DLP_GlobalPCIDSS
To: <pali.rohar@gmail.com>
CC: <dvhart@infradead.org>, <andy.shevchenko@gmail.com>,
        <linux-kernel@vger.kernel.org>, <platform-driver-x86@vger.kernel.org>,
        <luto@kernel.org>, <quasisec@google.com>, <rjw@rjwysocki.net>,
        <mjg59@google.com>, <hch@lst.de>, <greg@kroah.com>
Subject: RE: [PATCH v6 10/14] platform/x86: dell-smbios: add filtering
 capability for requests
Thread-Topic: [PATCH v6 10/14] platform/x86: dell-smbios: add filtering
 capability for requests
Thread-Index: AQHTQfYXOzH7qEACq0KBub4Xu34036LdiIQw
Date: Tue, 10 Oct 2017 20:31:11 +0000
Message-ID: <6b5cc33ec5f444a58cff4aec90f799ac@ausx13mpc120.AMER.DELL.COM>
References: <cover.1507589249.git.mario.limonciello@dell.com>
 <3892df796d90f3568be48b85498a7819711323db.1507589249.git.mario.limonciello@dell.com>
 <20171010160131.wkaxfsevd6w2akep@pali>
In-Reply-To: <20171010160131.wkaxfsevd6w2akep@pali>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.143.242.75]
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v9AKVome010022

> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@gmail.com]
> Sent: Tuesday, October 10, 2017 1:32 PM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: dvhart@infradead.org; Andy Shevchenko <andy.shevchenko@gmail.com>;
> LKML <linux-kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org;
> Andy Lutomirski <luto@kernel.org>; quasisec@google.com; rjw@rjwysocki.net;
> mjg59@google.com; hch@lst.de; Greg KH <greg@kroah.com>
> Subject: Re: [PATCH v6 10/14] platform/x86: dell-smbios: add filtering capability
> for requests
> 
> On Monday 09 October 2017 17:51:48 Mario Limonciello wrote:
> > +static struct token_range token_blacklist[] = {
> > +	{0x0000, 0x0175, 0x0176},
> > +	{0x0000, 0x0195, 0x0197},
> > +	{0x0000, 0x01DC, 0x01DD},
> > +	{0x0000, 0x027D, 0x0284},
> > +	{0x02E3, 0x0000, 0x0000},
> > +	{0x02FF, 0x0000, 0x0000},
> > +	{0x0000, 0x0300, 0x0302},
> > +	{0x0000, 0x0325, 0x0326},
> > +	{0x0000, 0x0332, 0x0335},
> > +	{0x0350, 0x0000, 0x0000},
> > +	{0x0363, 0x0000, 0x0000},
> > +	{0x0368, 0x0000, 0x0000},
> > +	{0x0000, 0x03F6, 0x03F7},
> > +	{0x0000, 0x049E, 0x049F},
> > +	{0x0000, 0x04A0, 0x04A3},
> > +	{0x0000, 0x04E6, 0x04E7},
> > +	{0x0000, 0x4000, 0x7FFF},
> > +	{0x0000, 0x9000, 0x9001},
> > +	{0x0000, 0xA000, 0xBFFF},
> > +	{0x0000, 0xEFF0, 0xEFFF},
> > +};
> 
> Hi! There should be information what is hidden in those tokens, so other
> people would be able to review why are those token blacklisted.
> 

I'll add some comments explaining what I can about why they're blacklisted.
Most of them are for use during manufacturing time and those I won't explain further.