From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E6CF27FD74 for ; Sat, 11 Jul 2026 03:54:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783742072; cv=none; b=tFVMO8iDF7eN4HPP9DOizWn92JlGA+Wh5e1lVpoRDyQVFVTLlx6IEmwoq5M11Ni/xyer3mScdGrV0n5RSKncHVvWLcfojQ9MyLcU2sm9veYc+CD/C0uf7zkqiBTO+T5PJPB5/1eZx/mNXzwCVwg2irD/2XXUOPMcXu38FQSLeHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783742072; c=relaxed/simple; bh=Ei1ZcO1wvdACPMG6sL/wGcRy+ehAtulyMYsMK34GiK0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C//9zf10aTPEVlJ0jYQ0LBZLP0OquOYU0iHrmmlNFW/RJtcW+ISgfnvu6kDqXHBH0Ooaen6yflwMqZ8uPEYNmNJ/FXpfmTYioc72D50csBrDZ1U24NjaaJ+Bc3aEzrCuBM+rPUnpvzJ7tS4GyBjuHieC18xBctUZKIkgyll6bTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U39rOvfh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g3UUX8Rm; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U39rOvfh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g3UUX8Rm" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66B3ofUZ2630871 for ; Sat, 11 Jul 2026 03:54:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zWp3h9IfShwVVthOqsYFNWjXLlqI8l6BavhKygxu5/o=; b=U39rOvfhQnVrppQC LgDFYjY6PRHuxRL7tkS1RfhyuqJ/jK5ZyWvyzkKHcqeHvIQQviS2NCPrGurQ4hlo wVsR8eLCg/rKguI59y175ymYubPvFEUzyfM1Y0jYKGv4lbd3HSPf0UCMMGhBNgoS DHlZJEoV5Sd7e+MpfZFsrG/3W+3hDJNZ31AiTpg+e61MG4nLgMTELK8KRdfWvrCg iPEiocigDg6hxwfu5L89LlQk6CJKcFW541WtmGAPZ99EVtNtKK0fk2jY1Xl5SXmy 0ah8heVsCKuh7gNyg7QDj1Jx5LnMa4/U5ElSeYQAseXThYlw22P88t2J3VnCPu4v apGcDQ== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fbe9k0075-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 11 Jul 2026 03:54:29 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c889d1eebafso769347a12.0 for ; Fri, 10 Jul 2026 20:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783742069; x=1784346869; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zWp3h9IfShwVVthOqsYFNWjXLlqI8l6BavhKygxu5/o=; b=g3UUX8RmIRzKQ7H9aI0ROVE+kBfmPqn8x/zadbGUW1F8O3jIVaNpOmqDE9l9iHuOqC 9MozVgEj+kgAzjoGdMEuu+zu+pxbtus++SRVROAr45P+m+TwRLT8MEExHsBDItVHU/vo 2CYRLn1CUTa+w9mGqpRwQTxRDqWrPwb7Rv0nccZP4FLluxIlKT8HeyRNVPdDf+kvZiMJ CsrFW3W6ODb2mqYeQa3L74yaxoGfRROhkB9qBRsTZHjydTySlh766Pa989uc5tiOKtzy 6s1G0grAjrZxY59PfeEazZUpJRC6qrDxRTS/8Cjt0ZbGM/YxKdD+jQtv/qvw3YN65UAN W+mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783742069; x=1784346869; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zWp3h9IfShwVVthOqsYFNWjXLlqI8l6BavhKygxu5/o=; b=rk3VQ0AdA+tiNGCuylXJYYRk67ZVYLK7yZ1mkbGe3mwQvBIpoCjD56L36wJSuG/zXj 0d4jOxWaEsRMoX/VXUxXm0S6ql+tL5uKt8sMtwB5lm97oG95dTY+J+Qf6FBfpFfLRgs/ rYG4vG2NgyUYOWey7ztfGc7V5toP5NADko+J5wrih+YC80oH4PJOaZnEYtqBO5mTBMMJ IqWuWv2GX/y+e8MZMzyNwkgJi582+H0D1MkrQhePzPlg+8SUbrjcww/MQrU/eV+PIV2d w8LH3/+EE5GCOvc18T/Pw9Jo4/OViqWSxchRl7TihpQHBstq4y+Wf/5CHnHFFq7N1S00 /2lw== X-Forwarded-Encrypted: i=1; AHgh+Rpoi3SGuSdIuRoMDV3CLo39eVniEKQcDtBZiCL3H7BWjmLodFBW23vk6LOzTnsUZFpAkpBiBnAMofLUPLc=@vger.kernel.org X-Gm-Message-State: AOJu0YxpqoptNTWRYZIO4B8pT5RifJUjTn1vx1/479u+nP9BVT/aglOr rSFfh9DXzw2YisvgWOGD4fPdylK6+6g4q4vQPxt2yrHxn4oHyUFeNl0egexsP5gPDd5FbuNdI2u SHVzY/wmr2zq1CILanG+UA2FaS15O4iJnFTCphazPOhomDJVz9A/bfmOfs0RhMDsOk2U= X-Gm-Gg: AfdE7cmqdfSQDsGRaW0ng2Ok/UUP+vfDad11Cz3dbJnirEZPDggkFqse4aHGyyo+/er xrJYBkUkieq9M3yxGMrCB1Hi9HD6IzPswSdujDGCA3jLXmdqJ/jXZ41yaL3Skom2ZZRx2hvW8HP hmN2FoW2aOVhozI398MLv27qvPIsmwaAqi7+TWNCafhTjAz3wpHJtBqe+MhAx/WcVRXR8dd4zdJ JbFgd1mALxzzDgr76/JCin9FuciewSICZfLF1l2eZLwWV9yKXAs7IWAzkVg1Rf1oZhohMZNq6Id 8PzckkxyfZbU46KGU8+IPs+O+bWsOeueJeYV5f8sEGSRjgUKfiyQ/lwpIPQ7A5ri7LWNzsPOMUC SabLQ/VrVGd3Uv1hKnFiNfco/pEaCG4bHgi+s3yP842pQ4xg= X-Received: by 2002:a17:90b:3908:b0:384:a641:3fe with SMTP id 98e67ed59e1d1-38dc7737215mr1569966a91.21.1783741714683; Fri, 10 Jul 2026 20:48:34 -0700 (PDT) X-Received: by 2002:a17:90b:3908:b0:384:a641:3fe with SMTP id 98e67ed59e1d1-38dc7737215mr1569933a91.21.1783741714165; Fri, 10 Jul 2026 20:48:34 -0700 (PDT) Received: from [192.168.0.116] ([124.123.151.85]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31174accb0esm48880829eec.30.2026.07.10.20.48.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 20:48:33 -0700 (PDT) Message-ID: <6b67c5e8-202e-42a1-a3fe-04a6d60e6083@oss.qualcomm.com> Date: Sat, 11 Jul 2026 09:18:28 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: shikra: Add BAM-DMUX support To: Stephan Gerhold Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, chris.lew@oss.qualcomm.com References: <20260611-qcom-shikra-dts-bam-dmux-v1-1-43d0b43d41ef@oss.qualcomm.com> Content-Language: en-US From: Vishnu Santhosh In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzExMDAzNCBTYWx0ZWRfXzP8PgrCnrpkN t+kIQcLcY3qsiQx7feui/lHPRzoc0WMadKKsp4BPre75iPCB+AkcB8vHexWtaWgvoNh/0vKt9Zx 6v7/jcmRrXx2Nns5VCI+uVFm+bBSFqpo4Xk+rpf9UjoEiXhCCHX/dBtniePkylzysNKmGU2UvaK TXL9RvBdzxeAoSZuZiJ1rhJ/xzdV+peM6i4TWXA2q/ogk7jEE6tMUrLtk3olHyodKo2pt74tPy2 tQgoTnUy1uEgXGRIGQkRs/JJdBaEqdY63DQyWrcUvk8fWTr49DwOUPbKdLEMp0It/lXYD4eVrk9 4tDFBvxrbqz3HDHiMByzxdn5d+IsBonY6GD2N23XQ1jsAKla0cZ5fzh4K5gDyAFLDcY8PgOLjdU G4kBBsI4u9PBXgTDxrZE3Km4/rnFE/lD6c7cT7JuHUCrA13+yesSuVw2kxYvXM19Q8IIdBc4z8D MAg904LaW0hpEGjw5vg== X-Proofpoint-ORIG-GUID: SW1fhuSJVfv0E4yXOeV2ojqmXlbxYOYe X-Proofpoint-GUID: SW1fhuSJVfv0E4yXOeV2ojqmXlbxYOYe X-Authority-Analysis: v=2.4 cv=O/MJeh9W c=1 sm=1 tr=0 ts=6a51be75 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ziBI+Y3eO/H+UwYWWny9Hg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=qCRXIqyDeEQ_VX0ZX7wA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzExMDAzNCBTYWx0ZWRfX65Ysahlpb/+d ASzYRW7MAYmC8TogCVFNskNG9kC9SxjMp9nLOVx5RLQy2xTML0f14VsDH+Lt5ZsWM6iukZF5XmD KbuqNXHOm1qCLbk8Q2m7dwBYw9ySXiE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-11_01,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 phishscore=0 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607110034 On 11-06-2026 02:25 pm, Stephan Gerhold wrote: > On Thu, Jun 11, 2026 at 02:11:59PM +0530, Vishnu Santhosh wrote: >> Add required nodes to enable the upstream BAM-DMUX WWAN driver on >> Qualcomm Shikra SoC. >> >> The SMSM (Shared Memory State Machine) node provides the power >> control signaling between the AP and modem for BAM-DMUX. The >> BAM DMA controller node describes the A2 modem BAM hardware as a >> standard DMA controller. The BAM-DMUX node references the DMA >> channels and the pc/pc-ack interrupt lines from the modem SMSM >> entry for power control signaling. >> >> Signed-off-by: Vishnu Santhosh > I'm quite surprised to see this 15+ years(?) old hardware block being > brought back to a new SoC. Is Shikra not using IPA? > >> --- >> arch/arm64/boot/dts/qcom/shikra.dtsi | 51 ++++++++++++++++++++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi >> index a4334d99c1f35ee851ca8266ec37d4a200a07ee5..3e59d5f6323c0d857f376316faa26c503e67f6bc 100644 >> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi >> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi >> @@ -17,6 +17,23 @@ / { >> #address-cells = <2>; >> #size-cells = <2>; >> >> + bam_dmux: bam-dmux { >> + compatible = "qcom,bam-dmux"; >> + >> + interrupts-extended = <&modem_smsm 1 IRQ_TYPE_EDGE_BOTH>, >> + <&modem_smsm 11 IRQ_TYPE_EDGE_BOTH>; >> + interrupt-names = "pc", >> + "pc-ack"; >> + >> + qcom,smem-states = <&apps_smsm 1>, >> + <&apps_smsm 11>; >> + qcom,smem-state-names = "pc", >> + "pc-ack"; >> + >> + dmas = <&bam_dmux_dma 4>, <&bam_dmux_dma 5>; >> + dma-names = "tx", "rx"; >> + }; > This should be a child node of the modem remoteproc. See msm8916.dtsi > for example. > >> + >> clocks { >> xo_board: xo-board { >> compatible = "fixed-clock"; >> @@ -314,6 +331,28 @@ lmcu_dtb_mem: lmcu-dtb@b4702000 { >> }; >> }; >> >> + smsm { >> + compatible = "qcom,smsm"; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + mboxes = <0>, <&apcs_glb 13>; >> + >> + apps_smsm: apps@0 { >> + reg = <0>; >> + #qcom,smem-state-cells = <1>; >> + }; >> + >> + modem_smsm: modem@1 { >> + reg = <1>; >> + interrupts = ; >> + >> + interrupt-controller; >> + #interrupt-cells = <2>; >> + }; >> + }; >> + >> soc: soc@0 { >> compatible = "simple-bus"; >> >> @@ -640,6 +679,18 @@ &clk_virt SLAVE_QUP_CORE_0 RPM_ALWAYS_TAG>, >> }; >> }; >> >> + bam_dmux_dma: dma-controller@6044000 { >> + compatible = "qcom,bam-v1.7.0"; >> + reg = <0x0 0x06044000 0x0 0x19000>; >> + interrupts = ; >> + #dma-cells = <1>; >> + qcom,ee = <0>; >> + >> + num-channels = <6>; >> + qcom,num-ees = <1>; >> + qcom,powered-remotely; >> + }; >> + >> sram@c11e000 { >> compatible = "qcom,shikra-imem", "mmio-sram"; >> reg = <0x0 0x0c11e000 0x0 0x1000>; >> >> --- >> base-commit: ba3e43a9e601636f5edb54e259a74f96ca3b8fd8 >> change-id: 20260603-qcom-shikra-dts-bam-dmux-7fdcbb6fb662 >> prerequisite-message-id: <20260527-shikra-dt-v4-0-b5ca1fa0b392@oss.qualcomm.com> >> prerequisite-patch-id: 3a689e8dda5fd2755b689d94d095806b3f2e6eed >> prerequisite-patch-id: 2acc300a68ed8c5364fb5f2f7d28fc0d56ab07bf >> prerequisite-patch-id: 2357cac636e019eaf14d6a493a1c72bca56fe405 >> prerequisite-patch-id: 2885f299e711582da312ca9d13983d296a3dd5dc >> prerequisite-patch-id: 91af5f3c01e766a53ce8de69aa21847a2d6bbbf8 >> > If the DT isn't merged yet, you can also just squash that into the > existing series that adds the modem remoteproc. > > Thanks, > Stephan Since the existing series is already in a stable state, the author does not want to add any more patches to it. Therefore, I will update the current patch with the DT changes you suggested and submit a separate patch to incorporate the corresponding driver changes. Thanks, Vishnu