From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A07137F8A1 for ; Fri, 24 Jul 2026 07:34:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784878469; cv=none; b=Ntw5o10bhKPyFRI3WiRo9MZoywRrvqye++FM52/XcTR9nErdZkBD3FlBViVsZKzrV88VpcQe/FJrtws0YoqGFa0B+eBZ+VttC50/lhttyt9Z1E8Z7i6Cg2SXkNO+5orM5OxV9PQ3gJc7cjCWnhsVqTirlaTnFxr6u7CWiiI/B7o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784878469; c=relaxed/simple; bh=vXpRSWi/oVCMquWL7cTrWQgG+Q6PVnMDhgoEilSgEXU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TDWHnVAfLb3ArmSzqn4LmdxHgZUIODAxxPKhmQ8o62c0GNlXWQ3dtgBTLU0+HRRs2yANpbkqpG24hsq+f3KI62UL9w+2WomhHV9cBE+8rjEKDKXROIorzKjiuPG7ENtbozfGzkNtv9EwVjzmcMbvkzJBt62XKlx2MgnKQjFp6D8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dn83Ve3r; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dn83Ve3r" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cf27856f9cso1912955ad.2 for ; Fri, 24 Jul 2026 00:34:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784878467; x=1785483267; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=3LzKJmUsJl3t+t7LREmJa3ZK6twh8h3ZLCQyYGIQu7w=; b=Dn83Ve3r97W4wC0W+r41vBC/v9UQgyUnxNOU0JchMsc7G9ahtILugIzT8PHus6syKf OqWH7Kx0tnNNyhslbXfFyBPcLXG6TmGduyX7a2qDp3gdEW89jtuxRI/RWQ64dLH6OjPY h4G45Sgs973/xlhJIPN1zro/fc2qjOm9X//l67w0YU/Rwvyq4Y8Stg2QX1tuVAvAV3D8 Xytzc/2nNlQvUkbMFeAKmdC2ivIMXbWOMIZl05QncGbb5fANX1SyBBwW4tIF0tloqqZU 3UIijQ6Xyg4XNNYfQSIzo3EoWolZqbnpI8JNbWAcIdB/DarK165o4XxykQEu9/WaNYJr J7MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784878467; x=1785483267; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3LzKJmUsJl3t+t7LREmJa3ZK6twh8h3ZLCQyYGIQu7w=; b=ZINcDnlBS+F0jE5jSO4fXrT90wYqIFdneRjkJYj9OYI/+tsg2Pd66afItBj4bjtsFk RJssWbva2535Tt0gJw+qnFka80/yRWG+E8aqhCBiSPhlJYIrGBHoTXiLZ99mxZkvlj1a nsFMgKLC4e4KveRlWJorNkQNlf/Q8lZAvqsm8V8xnnGO34SqU4/nUXIGlguyuQJMgPJA jZZGMT4z7Z3tJJd7fHqV8eTZN9hYuGAiPWC7MSduY6Z1KEfX+wqZKfjzUrUMaM1jMM08 JWjWmPW/sIBT4dFhxZiu7G/deTH9RJsSGUQ8ok3V6nzp/fAUy+BVphww2Gp0gDjJeDVD fkwQ== X-Forwarded-Encrypted: i=1; AHgh+RqFiNxxfthc4iZKPCTetusNwC0KTzCakhiBN/1NAkGs8cztBowJqyuY6chPdQni15EtJ55gchvKuPlR+c4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+WzKOZ5LaeMpp0ugqu9dx0Rx84nFZFrL/NYLQiL04ty3rnUmR aqXCJm/KrLLwdng7bA5tWrQ94ZKYw2MmgFLjpLgDp8T5E2kAwF7wFmKP X-Gm-Gg: AR+sD10gjrJMEh8AhdIjK7VFgD7oS14IX5mb3GWB4C9qx8cuGr+ZFQB66UgfRRd7PBF zRqVTbkL3YyLzxjrFcaZ9VEz9vfkkfVBmnwFU7ZfPp+ZqUUVi2uADXVqFhp7x1+UYvuogFIlAsA cFzrnqsqtCXZsZ6KH4dPgBYoK9Ox3RF81lCdGVmyixnvDraT/3MZg5yh07gcIC5MQg1INOeR7tI MOEPulXIRj5TnWCbrdSF6CXYYYrrJqp+TmmGVpUKmYI525xP9zdXGjLVUBOEo2+3wgnPEdDAXEA zX4xFsnL/dxghL+1rI+aQCl9d+qIgz0yST9dfRLkf+qt0okr9GAetgbG8tMWI7PHwvwDqhDWBCr PLOxz7aHO2LcghYrC4V4zI8yB/F4PxXqlYyQXyK436YseIq8+rF+Ip0CmkLGk9KeG2UId14jYXM UbuShVwUvhKEIWpaR9iQc= X-Received: by 2002:a17:903:468e:b0:2c9:fbde:ab66 with SMTP id d9443c01a7336-2cfa6c72079mr71784215ad.37.1784878467184; Fri, 24 Jul 2026 00:34:27 -0700 (PDT) Received: from [10.22.76.22] ([111.223.92.222]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8efa39ddsm46944805ad.17.2026.07.24.00.34.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 00:34:26 -0700 (PDT) Message-ID: <6b684c2f-1f98-43ea-84c9-9b6f162d5e9f@gmail.com> Date: Fri, 24 Jul 2026 15:34:23 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] vsock: use sock_error() to consume sk_err after connect timeout Content-Language: en-GB To: Michal Luczaj , Stefano Garzarella Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , syzbot+1b2c9c4a0f8708082678@syzkaller.appspotmail.com, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260719220103.684489-1-phind.uet@gmail.com> <78225425-1ca7-45fb-85cb-9e04f489e68f@gmail.com> <95cd0d4e-58c9-44ab-b94f-fcf57b88583b@rbox.co> <27412e44-ab4b-4dd3-9685-481875683860@gmail.com> From: "Nguyen Dinh Phi [SG]" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/7/26 05:43, Michal Luczaj wrote: > On 7/23/26 12:26, Nguyen Dinh Phi [SG] wrote: >>>>>> ... >>>>>> Yeah, we need to handle that part better, I think it's a leftover when >>>>>> we generalized AF_VSOCK to support more transport than vmci. >>>> >>>> Speaking of leftovers, I have trouble understanding where does vsock set >>>> sk_err on listener sockets anyway. If it doesn't, why vsock_accept() >>>> checks for it? >>> >>> I can't also see where it can be set TBH. Should we remove it ? >> >> I couldn't find it for listener side too. > > Removing sk_err handling from vsock_accept() solves the problem, right? > > thanks, > Michal Yes, confirmed, removing sk_err checks from vsock_accept() does solve the problem. Thanks, Phi