From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58AD83BBFA2 for ; Mon, 6 Jul 2026 04:56:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783313765; cv=none; b=XfDd8oYvUd4N3/21zmdDm4KMWSQw7YD3D3TpUZQOfma3XLFvWst5AQ6NIUn5Mk+glnP2zM9auWGRWEVdZFqc5pdgPby/nL8uRqw6i6+4wVriqTFVkpLHZ7zx8yRCNEBNwbYptCVnnxJHXrFEzr9XzFgHjeNdqdIjMZ9IEoy7to0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783313765; c=relaxed/simple; bh=9b/4FZ+3+qRq+fXpfPVgslie5izhocjgJJoFMG79fvc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LqZ1MX8YCfTYYq5v0m/o7cka9lO4x4jLp2rNw+oeqHQ4q7Yl4wNqqzdn0pWRooT1JdEwLfyVdN9av7p8Wm96g2VYORAn3ba5GZKHksiI66TTsImiln9A71+sO3AouFqNpVkKiFdw8dl7FiQ5x9zpcrGQpPKoWUY7ZTXEjXvzBaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j4LmCalt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SnrvUr52; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j4LmCalt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SnrvUr52" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66641j4x3402390 for ; Mon, 6 Jul 2026 04:56:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uZuEm94SloL3WtfgsZqmYPrzPC054at/1BedQur6MUE=; b=j4LmCaltYE0CabBi kSx3so/eLQvWs3aD8BM2OdPb4VrmUEhXHPRP6PHTurRAUGApb4DI8wBbHohRNuzE DwjXosTJH0ygtSmymmyS+PfzIHWEovaj3Tbzcp44Siw+f/A4x/22UrYMU6Lxv48L B+P2XT3XZN3nJnu9J8/ccPFFbDqWpKHIyG4kLhhFKrPQPEmEnW+Q4TUTiYRJ5Fhc PItKcXkNHhckYJKE6L48DzrG6xUjuDMgn5IAT3D+VncxXz1RfXWKizgJejigU2hU 5DUV/d5KE3tuU4YXMC3DN+8hnKwDazsWO7HG7W2lGXX2YxTWpi0fYcJEH/VWXwPM Cjfgzg== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6ubgm8jy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 04:56:02 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c8895156101so3813526a12.1 for ; Sun, 05 Jul 2026 21:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783313761; x=1783918561; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uZuEm94SloL3WtfgsZqmYPrzPC054at/1BedQur6MUE=; b=SnrvUr52EwfTpazaBmOhtcWGLTHGZaLb+86PCkDbNV4hRXiQIP5ADoO6Uj0apvX66r /UG3D2ZtE67N4L4IfWUk3YTR+M+zhTIPOMDzNtcJofS+TB6tXXBAvVTSxcmB4ESSoHxp o3qvnu6oRTa0rypi0d9TlLqPc0aI6UZwF2giZ7qb9/bAXo0c0nTwb4vLfDxesVA1AA0p urIHCBeIlnCXNZxcHJQxJ2ue2fKUELiN8xgJrXR7Ju1KKpg6wj7SWwB5LbuORb/yXXUV 1T6pv7HkYB5Ioe+TU9JDWWu74wP1SICM8IxBxtaAxaM3E/XzBuJzbCrjreqjDDaGJB47 aE6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783313761; x=1783918561; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uZuEm94SloL3WtfgsZqmYPrzPC054at/1BedQur6MUE=; b=DwOUERRpjCgolCjKRYvUgsMRNQiyYyau0AzSHLtGbVNeKKynphyy4yN7+sHFN3Nqe+ petnay7/EdO5hev74+84nd8yzeK22r2hHmr8Mr9iZJ14HqlBFdLMiYmIN+JOyPCh6xl+ s1sj5qHLkqN0cUYOGRIK2dgVURbSj7ZB+Y8COPj6MdKzXiCRLDpXXdv7sOp/44mf+2Qz AmuSXplyft51q/iXJTZmOjOuCeuy3CdVU4LaRdF6AgXRhIsvmsu9+fo6rL2PI1qe6Ix+ VaCfqlEp97SMIfy6aosb9kMoZB9ePCRtCUUuErk8Vst6dcgJPNmo0Z0yAhyuWOy1ZdQM 9dNQ== X-Forwarded-Encrypted: i=1; AHgh+RpATUnExGqp90E/ATUV2bNDTzJnyNb7oms49xp/43X2tpuzEfMs6TGu5vsW6IMjDy92FQuZg2FbUUH/9Ws=@vger.kernel.org X-Gm-Message-State: AOJu0YxXxmKsOxkmm4Prn0Ew1zZ1buiG2S7kkaZ151RyG7IixrlQMc/G WKFD9F61JBQJ5+C8EdTMLTvhgo821kkW4umn5Q/YTMa7j0AEJl+z7xh7SYhpS1HrFVCc3AU6rPD +W6wjVH6JxyCSN8Xlve/zPH9erUGl7Jmnq3fFN3hpCmILdeJNoUojSW9Baf7AqBvD8+8= X-Gm-Gg: AfdE7ckB4fNBk7iSmjLfCBS0KWKulRTijuom2Z2KxDPdF54Uzczi+lPz6mcqjiIsECd gxU6MkFmJVlCBfP3DdA8cLLgbgTv4OcMOQnV8vt75BcVZ1yxOFrMm8MAXfeJoiIxVBvlqdN3Jsi HbnvyDNMNEZqrKTvZOxQcr37iBamEBWpxV0c7wqfrKaNqmFhRa9a5IM0Z5CfjIAg/yvZsWcymBv pv0vYDQKcWQ+qM0YYATEGAnzO9dfPh1HlQjhQ66J2+DHW0hfkEpsDN/+uJAoiGl+voF9HFTExlb LpzFjXvdbR/RoqyS/Z1vgFWTwKqRXEdDk07/b7LGfSDZit3HlEzgkpz6npG17Nx8r6hbaEBtsYp Q15m4MOa80ix9exkVE2E0gbLaqV2wpStjrIpTvKg= X-Received: by 2002:a05:6a20:6a07:b0:3bf:bdbc:bb0a with SMTP id adf61e73a8af0-3c03e21c329mr9214407637.17.1783313761499; Sun, 05 Jul 2026 21:56:01 -0700 (PDT) X-Received: by 2002:a05:6a20:6a07:b0:3bf:bdbc:bb0a with SMTP id adf61e73a8af0-3c03e21c329mr9214364637.17.1783313761066; Sun, 05 Jul 2026 21:56:01 -0700 (PDT) Received: from [10.217.216.242] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b3c870effsm62052392c88.12.2026.07.05.21.55.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jul 2026 21:56:00 -0700 (PDT) Message-ID: <6b691eb6-07b6-48e8-9952-8a88e315a5ea@oss.qualcomm.com> Date: Mon, 6 Jul 2026 10:25:53 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] clk: qcom: gcc-hawi: Add support for global clock controller on Maili To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vivek Aknurwar Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260618-maili_initial_clock-v1-0-d6ede0352113@oss.qualcomm.com> <20260618-maili_initial_clock-v1-4-d6ede0352113@oss.qualcomm.com> <62cfb2ec-f069-4012-88a1-8667d3f3e5e9@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: <62cfb2ec-f069-4012-88a1-8667d3f3e5e9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDA0NSBTYWx0ZWRfXzKq1VLKyRPGJ dvrJ7RE157UDkGTg3M8FE1LsdR9STA5+WAtg/8Ej2BFvKoHXW8sIguYwiQwGAco2j2UVLSwUxod jhqEJBi09JLLCNeaZD4Zg5P40YuelsU= X-Proofpoint-ORIG-GUID: LlIGZXjNTPDYPTPlblcDHVTHMJFVjBqE X-Proofpoint-GUID: LlIGZXjNTPDYPTPlblcDHVTHMJFVjBqE X-Authority-Analysis: v=2.4 cv=FJwrAeos c=1 sm=1 tr=0 ts=6a4b3562 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=tZh_4sgZHyZb0SdsJiQA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDA0NSBTYWx0ZWRfXxFD0ETQcCTas 35LeL07smhPg3/QE6HjpgBQVkel2y/XO4v5T556A/FLye7CkemsLpbtLA0i8fE1xBr9Qq4cXdoQ UzTli2X4MCYk+tKPrRu3bTbwhH2Dr175IwCjJJteRDOHrzGDOAz1/MNUB1s785canaTn4tA2IO0 Vrlbu/HIR/C/OVaIOfY6fWGrkvlx0xM6AN6gnj8yxFaQVRB4VeIM0604sanma1GWiM1YdpdIPdc g48AdfFtd23e5XCxa/enCvrGnUEnFRz6RxD5pBVxDYnDiP/SLR7jIZ3GU/onsBHBZnnhaEJTgdW uchsK+DtzoXxmr1+00mmxyPrWcNA5sC6suBonYa/QbrUnSWZ8ztIQMf849204D48XyVZb/FH7op CN7fOayJrfuFhxxzJ19tIZyHsBiCdLYGkt6v6coqwz6wbXmxYT1J4JLX4PHzraKUSI6AT27rYMS vBuHx/hz5FAo+SbV4Gg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060045 On 6/22/2026 7:30 PM, Konrad Dybcio wrote: >> + /* >> + * Maili-only clocks: NULL here to size the array to the highest Maili >> + * clock index. >> + */ >> + [GCC_QUPV3_WRAP_5_S_AHB_CLK] = NULL, > we have: > > --- common.c > qcom_cc_really_probe(): > > ... > cc->rclks = rclks; // desc->clks > cc->num_rclks = num_clks; // desc->num_clks > ... > > -> devm_of_clk_add_hw_provider(dev, qcom_cc_clk_hw_get, cc); > > and qcom_cc_clk_hw_get() has: > > if (idx >= cc->num_rclks) { > pr_err("%s: invalid index %u\n", __func__, idx); > return ERR_PTR(-EINVAL); > } > > so I think this should be unnecessary > Though common clock driver takes care of the check of idx, in order to allocate the memory for the new clocks present on top of Hawi, we need this piece of code. > Besides, is that new set of clocks actually unique to Maili, or > is it bound to a QSPI usecase on the specific QUP? Yes, these are specifically new clocks added to Maili. -- Thanks, Taniya Das