From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70ED62DB781 for ; Wed, 18 Mar 2026 21:16:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773868599; cv=none; b=K7HxfezIbCJYSRIzPiOWmpeTBAmahAoQCfQ4pf1LGOM6bPBDFRBAoVjCmt3Aa9bdUTiTYKIt2XEZYLaqVAw07opB5D/NnDKZQe3jkQjhV/xAKGgOCu6buzigkwzSmdseGatqzHSNBA+39hDJfBLqfsxB7j5mzDR44N0ntYz+E8Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773868599; c=relaxed/simple; bh=P//KxE6W/5Y+HAxi/f5cOXKna4n5LLIU7027UToyg34=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g1qUTZJEkXnPsr2iGo3mJ4QWWmHrlNqb7Tpo9O2aXyY9SQ8hyvg9+XRYYCQt3QmrNL0/BtjOtvhxN/JWYB5QyTmTiSj2RpvbvtUovv4HX/u1d+A8IlsTny5HCptzTcmScb13nFUUe8rq+DAymQujBAdycs7cMffOJ1WllODOaRo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linbit.com; spf=pass smtp.mailfrom=linbit.com; dkim=pass (2048-bit key) header.d=linbit-com.20230601.gappssmtp.com header.i=@linbit-com.20230601.gappssmtp.com header.b=Uh+4QSff; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linbit-com.20230601.gappssmtp.com header.i=@linbit-com.20230601.gappssmtp.com header.b="Uh+4QSff" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-439b94a19fdso192717f8f.0 for ; Wed, 18 Mar 2026 14:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20230601.gappssmtp.com; s=20230601; t=1773868597; x=1774473397; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6JSbsrYhFg+Au4jgvX758AnPNxCSSto/QgL2aLSvMGI=; b=Uh+4QSffM1uGTLyOEOiMET9Q9ElpLzCKb4XanROgT477VE+9Z7Imhlvsbho+yNIPn/ edWoCR/vrz4sOfms3aCJk2GXaXp2BB7vQ0c3By8j7A+p+dBzfw3wxMpSL9kuBqByFlOa jfVZeQQS+NyWj6eAT5LYWSwgsc2nPYQ3Q9oO5wjeUmCW/56DH2QmP/av+CgqUY9sFedv GG74szR+s1k8eICg6667X6jFJTG42+2ACKcGpARFX7Bdo+aad+qUFXxfNubA+21WP39I KVIzj7YOZ8gJ07/eygvoApUPGkQ9vOuodL9AWwguT+7Rsuhja8VWzSOIFkm0jbIpckep 7KRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773868597; x=1774473397; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6JSbsrYhFg+Au4jgvX758AnPNxCSSto/QgL2aLSvMGI=; b=cwnXiwz5vGgrQIAr359BEu1lo6u1SEC3yqm9vTmkz+twYLugXQSXzHyrYMO6UO26SE WQKLPWh95XJsz4nI5wSuAwru9yT7Y+MD7Ff0VPpuJ183pmV5CcArSS7QFuU/+Ff2IlPM uoqW25hl7YDKYBmX+Nmfg0PKptitvAmbtp4r0pqxOpeAohXsoWVolertZnSD9Dmj7q/U +K+DVwLopHM0/HvHZ8F4nILHLq0HqO7LUGaU2/UATFMKDa2Jw/VJEfp0OyiaUmjxuXiQ vnLmdxxflfRgs4+wwGRDULYbqSxjnbQggCFpbL+i9zexCIA8pU8a3iPa8lczcs3GNy1c jErA== X-Forwarded-Encrypted: i=1; AJvYcCVzuOSUM6+NI4AGWqZaOkjp21rSIPh8l4nJmmHNLti5XubAvO5SZ/on87aInNtylbP6dag8UTCS+U7ucE4=@vger.kernel.org X-Gm-Message-State: AOJu0Yww0c5ALZnR6QIT1gVqcJMUoVlQ1Fv7Ts+GBjOz+mx8OkIKDHZ8 FpW5JDIJDPpax3wroGu51SDp3ynIj7MhqnNeKEJ2d0MDOeyYdvwGoMu2mCj+x+9Lz+wAyI5XbR4 8Ds6MFvA= X-Gm-Gg: ATEYQzzwDDlZ33lzKCywl9+5vooPwA+FX2J7C2hWyH6S3dZ6vRDuSzTAiw1cDkxOLPc 2ZWgXfqEWHLPnHZgdHImBezFJgChIgJwkbVeOLwlucY5j2OFT7YKuv2N6CODYJ5ke8sxoHz49w1 z4f6phWa0XduTnJm/sqb6AexGHF9f1C9LoNOOrMT0jQljrGKeHB0WWoeP8b6YuPPpfcfviP1ww8 nrxq6LGTofOojqJZumQHANbl9FjckxZLs+KDpjbD0IBxdh5CrwxiKMow3IH/zpaDNDckQehy2K+ L2L06OsBqUU0G0/8I1MnsJFP+00bamiBO4taWBO5KVKz+UaPMmYK3rzJpBitJR9GtqXByNoikhV WttsOtSY1W4BzjfLhazcn7ju8QUJW0PJ2ag0L2uUa9ctOJNqF1+KKKzbX8C00eS0olUBwkunl4n xZAMkNUpAL81hKjJlC2NDuUXs45mKIqi0Rivkmi1Mr/CqiAWI0klm/czTjScWob6uxj3B0qG4k9 /uQgzLjuLpjCkY= X-Received: by 2002:a05:6000:608:b0:439:c69f:503a with SMTP id ffacd0b85a97d-43b527c4df0mr8143039f8f.27.1773868596733; Wed, 18 Mar 2026 14:16:36 -0700 (PDT) Received: from [192.168.178.55] (h082218028181.host.wavenet.at. [82.218.28.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b51892244sm11628020f8f.22.2026.03.18.14.16.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 14:16:36 -0700 (PDT) Message-ID: <6b696861-ac39-4a87-a2fa-ad47a75031c6@linbit.com> Date: Wed, 18 Mar 2026 22:16:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] drbd: select CONFIG_NET_HANDSHAKE To: Arnd Bergmann , Philipp Reisner , Lars Ellenberg , Jens Axboe , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Arnd Bergmann , Simon Horman , Eric Biggers , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20260318104858.1868731-1-arnd@kernel.org> <20260318104858.1868731-2-arnd@kernel.org> From: =?UTF-8?Q?Christoph_B=C3=B6hmwalder?= Content-Language: en-US In-Reply-To: <20260318104858.1868731-2-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Am 18.03.26 um 11:48 schrieb Arnd Bergmann: > From: Arnd Bergmann > > The TLS handshake code is optional and has to be enabled for DRBD: > > ERROR: modpost: "tls_handshake_cancel" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! > ERROR: modpost: "tls_server_hello_x509" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! > ERROR: modpost: "tls_client_hello_x509" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! > ERROR: modpost: "tls_get_record_type" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! > ERROR: modpost: "tls_alert_recv" [drivers/block/drbd/drbd_transport_tcp.ko] undefined! > > Select the option whenever DRBD is eanbled and rework the dependency in > the symbol so it can be selected more easily. > > Fixes: fa8ef6960ebd ("drbd: add TCP transport implementation") > Signed-off-by: Arnd Bergmann > --- > drivers/block/drbd/Kconfig | 1 + > net/Kconfig | 4 +--- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/block/drbd/Kconfig b/drivers/block/drbd/Kconfig > index 29ec6ed84251..de9e232d6479 100644 > --- a/drivers/block/drbd/Kconfig > +++ b/drivers/block/drbd/Kconfig > @@ -11,6 +11,7 @@ config BLK_DEV_DRBD > depends on PROC_FS && INET > select LRU_CACHE > select CRC32 > + select NET_HANDSHAKE > help > > NOTE: In order to authenticate connections you have to select > diff --git a/net/Kconfig b/net/Kconfig > index 62266eaf0e95..769880113740 100644 > --- a/net/Kconfig > +++ b/net/Kconfig > @@ -92,9 +92,7 @@ source "drivers/dibs/Kconfig" > source "net/xdp/Kconfig" > > config NET_HANDSHAKE > - bool > - depends on SUNRPC || NVME_TARGET_TCP || NVME_TCP > - default y > + def_bool SUNRPC || NVME_TARGET_TCP || NVME_TCP > > config NET_HANDSHAKE_KUNIT_TEST > tristate "KUnit tests for the handshake upcall mechanism" if !KUNIT_ALL_TESTS Thanks for the fix, I applied it to our drbd-next tree (which should end up in linux-next). I would prefer to squash these kinds of fixups to keep the history in our patch series clean. Arnd, does that work for you? How do you prefer we handle attribution? Unfortunately I couldn't really find a clear precedence pattern for this, how is this usually handled? -- Christoph Böhmwalder LINBIT | Keeping the Digital World Running DRBD HA — Disaster Recovery — Software defined Storage