From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 783741BCA1C for ; Thu, 20 Nov 2025 11:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763639331; cv=none; b=tAkPZKfILTStqEChttsT+tJ/ilisn9ZXHb/7ihknrAwZhMJkPRHV+Qfk2LdIWInbZKi6it5Pwdz6v8n1lgPrZg44SWIqSjpj68rI/GZdfJ80NBChgy3RJaz+ui/zihJW/zdts/gs4SZb0/zPbbFuB6zxcDUxV2unZ37wChARTFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763639331; c=relaxed/simple; bh=IpE98YtUJkz1WURHXdON4EeK1I2jEAM0yxPzud7iZwY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BE5QYgDMTSxX6Sp5Pjz+Nq04wfIEUQtQB7M70yW4vYxbmmG4HcjLH6NaewEMTiGlE3Qzp+qew2rGORVryxuqu1bWk5fDNSRnoXGvZbup3ZmJrN3kcQa/RXff5jlQT9LNGlf+2jIEmXS8z40Mtf8/CnjCThw4yoU5xHe4cEgevQo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h+RcTZzd; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h+RcTZzd" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-477a1c28778so9383155e9.3 for ; Thu, 20 Nov 2025 03:48:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763639328; x=1764244128; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3TPH7UjlNfZFqANQTeNbWZU6Inj9X9sCTFBqjBSBpJs=; b=h+RcTZzdmEnWEWOqsLIEn0ldXFL23HzE3rA2OCnHWbwo6hHCU/LG05rDGR0KC91W5Q ftCFLO9YvdlbRwzH7+l2Gq4y/zUGl9kILI/C0t+6+OfqoB4aOcYd4Lkl1wVrY8lZsoBu Y852QWxgSn/GZ09z3XebC80M5tHJYBZ6cXGsBXBMDw5Y5rTig6ZFEG4syyT83DfYtOdu Sz1BGLoNTyMNwScYe+YmNyHSQfSsD1E2pcZCi43GlUBv2S9aZjqqQa/ngHyD3Q/PgjTj qc8g7rRWMtyvx+FWwRJ7SvFI91jT6mv1JFfSXr8vMiUSinH2IJKiQRTEOFxsPQATowwu Um/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763639328; x=1764244128; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3TPH7UjlNfZFqANQTeNbWZU6Inj9X9sCTFBqjBSBpJs=; b=PDXQqA8RRi0JRt+HNop9cCivrqFXx5nlI/AYS7vAbOisZuSu4mPrrc8BQ0R2SiF/Df LSh+KdxMnwKft9IrOnYLhpNITwG7APF3OV8dRUa96DT6lS83Z3LnXN/5ld1KUSZvgR1v loHL7ktwjoU8ixnfOEMBd5MPdRar19ij28F1ubrpxOXGLiPjm7QhAzmpYpDLM7Aujk1G 3YASw/597wcgNcw33Dl24OKx6fuDZ/Gh+MkWP/YCf75dpJXQx3Uo06R3teHLbVJmDkaS bSFLtziNPD2U3zQC9mupLdmML8lecib+zBUh4R0XIGEvS2bJI36xKfzAW5YM25xSMq8w 5rlw== X-Gm-Message-State: AOJu0YwfgbrUNjWrQWf6SpWRr9jHMwr+Wv2x5D4ImpWiflhBBHdPulj4 RewmmWl8j6UEHk45Jer2cXYztXW/i1OOPQBfdsxqQbadLbrXcjh+ZGtmhrW1kA== X-Gm-Gg: ASbGncvOwvozG3uwwAcRpA73BbkZMz7YTLUBsNtg1EqbuS6K07i8seApSTODH2pMFgf oNS0eqGUJrWtuTt8oU8yxB6eEQm9OIBqvGzAC61zZx6fc2YWwh06JIKR9/r9+5l71FcSlLqMcDr LPasBobTvHerz5rjWmPG/GKFN8K7+b/1wf1espLJUEXldohYggwhithfQk4kHlwR444GE377zQh 7aHmvhOqEQk6fR1V72jsXGU00mIZWQiR4OWbX/B8CdgIL+wyfsdMypnR7BcrQzf/vWdmARgFbCR BD7DqOg3Og66UzNW/hzTMjYbv1dsK6FcYlFnN0BHNXE4dSY1q0hjNuypvTkDSYkBdYazMFU/HGA C68oWDBs+WUAf7bKm1cCA2g92HNAuFB1VbCTI1c9Frtth13iu6357YsSKFz325YSOPFgtsJoPUb 2rzsLrVbSzN7fMpYUKNsCMM/CX+yt+Ux+RQUGf04lHI5kEc289yA== X-Google-Smtp-Source: AGHT+IHaiHRiQWu9tKkalvEB+0JkQVKcZFjCNIsKpSkc9S0f0u1uLU4heqFveN0jijo2hAjPapxVJQ== X-Received: by 2002:a05:600c:470b:b0:477:9fcf:3fe3 with SMTP id 5b1f17b1804b1-477b8352507mr33106555e9.0.1763639327546; Thu, 20 Nov 2025 03:48:47 -0800 (PST) Received: from [192.168.178.118] (p54ad91dc.dip0.t-ipconnect.de. [84.173.145.220]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b82cc72dsm42665205e9.1.2025.11.20.03.48.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Nov 2025 03:48:46 -0800 (PST) Message-ID: <6b6e7d3e-7219-4459-b177-1e4123c531be@gmail.com> Date: Thu, 20 Nov 2025 12:48:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mcb: Fix incorrect sanity check To: Jose Javier Rodriguez Barbarin , gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org References: <20251120113732.24678-1-dev-josejavier.rodriguez@duagon.com> Content-Language: en-US From: Johannes Thumshirn In-Reply-To: <20251120113732.24678-1-dev-josejavier.rodriguez@duagon.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/20/25 12:37 PM, Jose Javier Rodriguez Barbarin wrote: > __mcb_register_driver() makes some sanity checks over mcb_driver > to check if .probe and .remove callbacks are set. However, not all > mcb device drivers implement .remove callback. > > Remove .remove check to ensure all mcb device drivers can be loaded. The only driver I can see that doesn't implement a .remove method is gpio-menz127.c. Is this safe? > > Signed-off-by: Jose Javier Rodriguez Barbarin > --- > drivers/mcb/mcb-core.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/mcb/mcb-core.c b/drivers/mcb/mcb-core.c > index c1367223e71a..3d487d75c483 100644 > --- a/drivers/mcb/mcb-core.c > +++ b/drivers/mcb/mcb-core.c > @@ -85,7 +85,8 @@ static void mcb_remove(struct device *dev) > struct mcb_device *mdev = to_mcb_device(dev); > struct module *carrier_mod; > > - mdrv->remove(mdev); > + if (mdrv->remove) > + mdrv->remove(mdev); > > carrier_mod = mdev->dev.parent->driver->owner; > module_put(carrier_mod); > @@ -176,13 +177,13 @@ static const struct device_type mcb_carrier_device_type = { > * @owner: The @mcb_driver's module > * @mod_name: The name of the @mcb_driver's module > * > - * Register a @mcb_driver at the system. Perform some sanity checks, if > - * the .probe and .remove methods are provided by the driver. > + * Register a @mcb_driver at the system. Perform a sanity check, if > + * .probe method is provided by the driver. > */ > int __mcb_register_driver(struct mcb_driver *drv, struct module *owner, > const char *mod_name) > { > - if (!drv->probe || !drv->remove) > + if (!drv->probe) > return -EINVAL; > > drv->driver.owner = owner;