From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BFADC433E9 for ; Sat, 6 Mar 2021 18:18:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D03E865018 for ; Sat, 6 Mar 2021 18:18:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231352AbhCFSSA (ORCPT ); Sat, 6 Mar 2021 13:18:00 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:60965 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231284AbhCFSRm (ORCPT ); Sat, 6 Mar 2021 13:17:42 -0500 Received: from mail-ed1-f70.google.com ([209.85.208.70]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lIbUi-0005gY-Mt for linux-kernel@vger.kernel.org; Sat, 06 Mar 2021 18:17:40 +0000 Received: by mail-ed1-f70.google.com with SMTP id r19so2334511edv.3 for ; Sat, 06 Mar 2021 10:17:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=g6bMYZr4IYJb49CfbN85Rd9NqLc1iESc8dgtSRtoAGo=; b=l7AtgYtPds6lMKuFAUWVBUxu5C9QSMkaSQr4YX4iUArThAMahmkApKKQkSq5weTZ0o HFPYAoVMlPUjcQLOsT3uvN7lNheNoXBafDexzLzGhJEO54b1nCmiXc7M1FlwzY9L3Bio 4hqaBlndrex0Ly0gXtqU2DfvdIpD6kq45GafeJ/HcTShulV8kYnHqMghTrhjH6EgWVXV SkiMCRYNHOwirRTz/M/esb6JrsdC+T20+7vlomZ4ce7C3mwcPs806YWh+/Ifw7ltxDSA qnQ0Q+Qxhy0kGJz2AbLNGyykwiDaDNkMRQADcAFsVTLP+wdV9sgo6DEdvIxfPlrjCLrw UYSQ== X-Gm-Message-State: AOAM531ZdMA7sEKvuOvv+qYzPWw0xz3M3zUUtdylt8wbhYfzyTivPxY9 j/+fymvXaHhXEeFnDf1e/pn6WuJvG0frPa+bRf8XPtEtooFv5VbYr32R0aqppcL7isVd6Q4jhas PBBCM8Y9nVyRRSDbLkz6soFMW5WOnRP15LYB794utxg== X-Received: by 2002:a17:906:ae96:: with SMTP id md22mr7580985ejb.409.1615054660382; Sat, 06 Mar 2021 10:17:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwzyGs+Nxo2sFfxp1gHm5M91NoaPL/OtuRamdi2dx6jcRPRH0A02SzA8eLG1btGURV9Y6QD4A== X-Received: by 2002:a17:906:ae96:: with SMTP id md22mr7580976ejb.409.1615054660202; Sat, 06 Mar 2021 10:17:40 -0800 (PST) Received: from [192.168.1.116] (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.gmail.com with ESMTPSA id m7sm3696800ejk.52.2021.03.06.10.17.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Mar 2021 10:17:39 -0800 (PST) Subject: Re: [PATCH 2/2 v2] usb: gadget: s3c: Fix the error handling path in 's3c2410_udc_probe()' To: Christophe JAILLET , balbi@kernel.org, gregkh@linuxfoundation.org, nathan@kernel.org, gustavoars@kernel.org, arnd@arndb.de, ben-linux@fluff.org Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20210306142145.3490-1-christophe.jaillet@wanadoo.fr> <64c3ca58-639f-95af-35e1-7d5ba240a7c9@canonical.com> <1fb088c0-c94c-908e-e607-796f834f45f3@wanadoo.fr> From: Krzysztof Kozlowski Message-ID: <6b73a1cd-b4b7-baec-1062-b9f1a1634cbd@canonical.com> Date: Sat, 6 Mar 2021 19:17:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1fb088c0-c94c-908e-e607-796f834f45f3@wanadoo.fr> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03/2021 18:22, Christophe JAILLET wrote: > Le 06/03/2021 à 17:16, Krzysztof Kozlowski a écrit : >> On 06/03/2021 15:21, Christophe JAILLET wrote: >>> Some 'clk_prepare_enable()' and 'clk_get()' must be undone in the error >>> handling path of the probe function, as already done in the remove >>> function. >>> >>> Fixes: 3fc154b6b813 ("USB Gadget driver for Samsung s3c2410 ARM SoC") >>> Signed-off-by: Christophe JAILLET >>> --- >>> v2: Fix a stupid error in the hash in Fixes: >>> --- >>> drivers/usb/gadget/udc/s3c2410_udc.c | 16 ++++++++++++---- >>> 1 file changed, 12 insertions(+), 4 deletions(-) >>> >> >> Do not ignore received tags but add them before sending a new version of patch. >> https://lore.kernel.org/linux-samsung-soc/36ef897b-aedc-fcc3-89c8-c602d9733a9b@canonical.com/T/#t >> >> Also somehow your 2nd patch is not in-reply to first one. Don't change >> the settings of sending patches. git format-patch and >> git send-email default settings are correct. Look here: >> https://lore.kernel.org/linux-samsung-soc/ >> Only your patches are not threaded. >> >> Best regards, >> Krzysztof >> > Hi, > > sorry for missing the typo in the first patch. > > For your other comments above, however, I use standard settings only. > My patches are generated by commands like: > git format-patch -2 > > I use cover letter only if it looks useful. In such a case, I use: > git format-patch --thread --cover-letter -2 > > I've never seen that threading series was the rule and/or that cover > letters were a must have. If I'm wrong, sorry, I was not aware of that. The cover letter is not needed. The threading was missing which is a default so you had to configure it to that. Best regards, Krzysztof