From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035149AbdAIRXd (ORCPT ); Mon, 9 Jan 2017 12:23:33 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52546 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1035128AbdAIRXa (ORCPT ); Mon, 9 Jan 2017 12:23:30 -0500 Subject: Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code To: Greg KH References: <1483978880-93705-1-git-send-email-bryantly@linux.vnet.ibm.com> <20170109164748.GA21437@kroah.com> Cc: nab@linux-iscsi.org, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, Bart.VanAssche@sandisk.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Bryant G. Ly" From: "Bryant G. Ly" Date: Mon, 9 Jan 2017 11:23:23 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170109164748.GA21437@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17010917-0004-0000-0000-0000113FC590 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006402; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000199; SDB=6.00805269; UDB=6.00391909; IPR=6.00582891; BA=6.00005038; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013866; XFM=3.00000011; UTC=2017-01-09 17:23:27 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17010917-0005-0000-0000-00007C0576EA Message-Id: <6b74ee38-4490-79df-8311-4d7349749cbf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-09_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701090247 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/9/17 10:47 AM, Greg KH wrote: > On Mon, Jan 09, 2017 at 10:21:20AM -0600, Bryant G. Ly wrote: >> From: "Bryant G. Ly" >> >> If srp_transfer_data fails within ibmvscsis_write_pending, then >> the most likely scenario is that the client timed out the op and >> removed the TCE mapping. Thus it will loop forever retrying the >> op that is pretty much guaranteed to fail forever. A better return >> code would be EIO instead of EAGAIN. >> >> Cc: stable@vger.kernel.org >> Reported-by: Steven Royer >> Tested-by: Steven Royer >> Signed-off-by: Bryant G. Ly >> --- >> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Why are you sending this to me? > > confused, > > greg k-h Sorry I meant to put --to target-devel@vger.kernel.org, and just --cc you. -Bryant