From: Yonghong Song <yhs@fb.com>
To: Douglas RAILLARD <douglas.raillard@arm.com>, bpf@vger.kernel.org
Cc: beata.michalska@arm.com, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v2] libbpf: Fix determine_ptr_size() guessing
Date: Mon, 23 May 2022 08:45:24 -0700 [thread overview]
Message-ID: <6b766a00-58a7-8bde-59a6-5e634ed5ff62@fb.com> (raw)
In-Reply-To: <20220523102955.43844-1-douglas.raillard@arm.com>
On 5/23/22 3:29 AM, Douglas RAILLARD wrote:
> From: Douglas Raillard <douglas.raillard@arm.com>
>
> One strategy employed by libbpf to guess the pointer size is by finding
> the size of "unsigned long" type. This is achieved by looking for a type
> of with the expected name and checking its size.
>
> Unfortunately, the C syntax is friendlier to humans than to computers
> as there is some variety in how such a type can be named. Specifically,
> gcc and clang do not use the same name in debug info.
>
> Lookup all the names for such a type so that libbpf can hope to find the
> information it wants.
>
> Signed-off-by: Douglas Raillard <douglas.raillard@arm.com>
Acked-by: Yonghong Song <yhs@fb.com>
next prev parent reply other threads:[~2022-05-23 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 10:29 Douglas RAILLARD
2022-05-23 15:45 ` Yonghong Song [this message]
2022-05-23 21:00 ` Daniel Borkmann
2022-05-23 22:07 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b766a00-58a7-8bde-59a6-5e634ed5ff62@fb.com \
--to=yhs@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=beata.michalska@arm.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=douglas.raillard@arm.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®