From: Om Prakash Singh <quic_omprsing@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: <neil.armstrong@linaro.org>, <konrad.dybcio@linaro.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<conor+dt@kernel.org>, <davem@davemloft.net>,
<devicetree@vger.kernel.org>, <herbert@gondor.apana.org.au>,
<krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <marijn.suijten@somainline.org>,
<robh+dt@kernel.org>, <vkoul@kernel.org>
Subject: Re: [PATCH V2 2/2] arm64: dts: qcom: sc7280: add QCrypto nodes
Date: Thu, 14 Dec 2023 11:11:07 +0530 [thread overview]
Message-ID: <6b79c66d-7591-443b-92e5-beeff6c93ae4@quicinc.com> (raw)
In-Reply-To: <c848f874-3748-4d59-8e78-9ae044fb760a@linaro.org>
On 12/12/2023 8:32 PM, Krzysztof Kozlowski wrote:
> On 12/12/2023 14:32, Om Prakash Singh wrote:
>> Add the QCE and Crypto BAM DMA nodes.
>>
>> Signed-off-by: Om Prakash Singh <quic_omprsing@quicinc.com>
>> ---
>>
>> Changes in V2:
>> - Update DT node sequence as per register ascending order
>
> Hm, I don't see it...
>
>> - Fix DT node properties as per convention
>>
>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 22 ++++++++++++++++++++++
>> 1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 66f1eb83cca7..7b705df21f4e 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -2272,6 +2272,28 @@ ipa: ipa@1e40000 {
>> status = "disabled";
>> };
>>
>> + cryptobam: dma-controller@1dc4000 {
>
> It still looks like not correctly ordered by unit address against other
> nodes in the file.
>
Hi Krzysztof,
Probably I am missing something basic here. I am trying to put entries
addresses that are sorted wrt their current adjacent.
And it looks fine to me.
1c0e000 (current exist)
1dc4000 (newly added)
1dfa000 (newly added)
1e40000 (current exist)
>
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-12-14 5:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 13:32 [PATCH V2 0/2] Add QCrypto support for SC7280 Om Prakash Singh
2023-12-12 13:32 ` [PATCH V2 1/2] dt-bindings: crypto: qcom-qce: document the SC7280 crypto engine Om Prakash Singh
2023-12-12 13:32 ` [PATCH V2 2/2] arm64: dts: qcom: sc7280: add QCrypto nodes Om Prakash Singh
2023-12-12 15:02 ` Krzysztof Kozlowski
2023-12-14 5:41 ` Om Prakash Singh [this message]
2023-12-14 7:22 ` Krzysztof Kozlowski
2023-12-14 10:22 ` Om Prakash Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b79c66d-7591-443b-92e5-beeff6c93ae4@quicinc.com \
--to=quic_omprsing@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®