From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH 2/4] xen/PVH: Use proper CS selector in long mode
Date: Wed, 2 May 2018 10:57:17 -0400 [thread overview]
Message-ID: <6b7a748d-e289-c370-123a-678c6ad7d9dd@oracle.com> (raw)
In-Reply-To: <5AE9713D02000078001C007B@prv1-mh.provo.novell.com>
On 05/02/2018 04:05 AM, Jan Beulich wrote:
>>>> On 30.04.18 at 18:23, <boris.ostrovsky@oracle.com> wrote:
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
> But to understand why things have been working nevertheless it would
> have been nice if the commit message wasn't empty, but instead said
> something like "The two happen to be identical on 64-bit."
Why do you think they are identical? __KERNEL_CS points to entry#12
(which we don't specify in PVH GDT) while __BOOT_CS is the second entry
(which we do create).
-boris
next prev parent reply other threads:[~2018-05-02 14:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 16:23 [PATCH 0/4] PVH GDT fixes and cleanup Boris Ostrovsky
2018-04-30 16:23 ` [PATCH 1/4] xen/PVH: Replace GDT_ENTRY with explicit constant Boris Ostrovsky
2018-04-30 16:57 ` [Xen-devel] " Roger Pau Monné
2018-04-30 18:07 ` Boris Ostrovsky
2018-05-01 7:53 ` Roger Pau Monné
2018-05-01 12:16 ` Boris Ostrovsky
2018-05-01 11:31 ` David Laight
2018-05-01 12:40 ` Boris Ostrovsky
2018-05-02 8:00 ` [Xen-devel] " Jan Beulich
2018-05-02 14:53 ` Boris Ostrovsky
2018-04-30 16:23 ` [PATCH 2/4] xen/PVH: Use proper CS selector in long mode Boris Ostrovsky
2018-05-02 8:05 ` [Xen-devel] " Jan Beulich
2018-05-02 14:57 ` Boris Ostrovsky [this message]
2018-05-02 15:00 ` Jan Beulich
2018-05-02 15:08 ` Boris Ostrovsky
2018-05-02 15:09 ` Jan Beulich
2018-05-02 15:28 ` Andrew Cooper
2018-04-30 16:23 ` [PATCH 3/4] xen/PVH: Set up GS segment for stack canary Boris Ostrovsky
2018-05-02 8:16 ` [Xen-devel] " Jan Beulich
2018-05-02 15:00 ` Boris Ostrovsky
2018-05-02 15:01 ` Jan Beulich
2018-05-02 15:22 ` Boris Ostrovsky
2018-05-02 15:41 ` Jan Beulich
2018-05-02 17:29 ` Boris Ostrovsky
2018-05-03 7:35 ` Jan Beulich
2018-04-30 16:23 ` [PATCH 4/4] xen/PVH: Remove reserved entry in PVH GDT Boris Ostrovsky
2018-05-01 8:00 ` [Xen-devel] " Roger Pau Monné
2018-05-01 12:34 ` Boris Ostrovsky
2018-05-02 8:26 ` Jan Beulich
2018-05-02 15:06 ` Boris Ostrovsky
2018-05-02 15:07 ` Jan Beulich
2018-05-02 8:19 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b7a748d-e289-c370-123a-678c6ad7d9dd@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=JBeulich@suse.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®