From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 363C3C6FD1F for ; Tue, 14 Mar 2023 15:41:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229988AbjCNPlW (ORCPT ); Tue, 14 Mar 2023 11:41:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230237AbjCNPkx (ORCPT ); Tue, 14 Mar 2023 11:40:53 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13FB3ACBBB for ; Tue, 14 Mar 2023 08:40:26 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id r18so14779048wrx.1 for ; Tue, 14 Mar 2023 08:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678808421; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=txkXz/I3r3Tjb5s8k1jSMemJtidVgLhZ7+02zqLYGf4=; b=sD6q8uCo8xBD0SMMmwkuzWrvH9QcadfmFi4Z+WiGG7JnU3M7+5m5oo1OLN4tkuNsrk rUJ6NQPlzNUtqwoCi31FrojSxjnNDfgnvzH3+a/4CzEKlXKIeA7PrzyMv6HymuGSSgvz wohHyqnxU6dYWpIgbNHHGD2C94TmbVvu5PBKRQbrwj4UqgumRQvG+AnArg2MXqlYtrjL Al/uLzsabUckDbPAX+VH06mju/nbsLsJf7CwOiCN6WRBKNpQEsZQDMzrKDHGxtDvYh34 ff477xAWAkCRmkVGI7JUbZiLEI22/ho/M3v7jfYIlIs5U6CtMuELrINjyOaQWe2/UvQ4 L0ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678808421; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=txkXz/I3r3Tjb5s8k1jSMemJtidVgLhZ7+02zqLYGf4=; b=kiHsarhhJrjCaerNRFl4ibosbGVKyTqxHU1j0JBvDVqxbBQUgbTr7YOfOrgL1JgyU4 JjK4h7OL3xYppb43sCEZXu59P15VS7xZt46E5y0GgcyHuIuHpYx+rxnI2C1Vuym0Ct9F pCo/vb6YcUrEvpuuTOsK3AvKX5QvW1eNeZynsp/ti3Q27t82uulZxCDVi1VQk5Jiv+vx mQQ2WH5vh1lpmvtrJkmIWHf4tFuevY/jED11nYkwnQYe5+K3+1WvwQGjC7nNGckkq+Gj z5yj5fw7i71OSbKC/XK7SQgu75DyPhTg4Bwu0fo72GRbit03gLqG/B90FBfancSsQpuo CaaQ== X-Gm-Message-State: AO0yUKUPvBcmXAFA75ca6hY5SXL5YwH9AnhYNOIYGvh6ZkE/0tVm8kW9 6wAewd+eNrCPisq0eHevO3Al5Q== X-Google-Smtp-Source: AK7set/rB1r35ueF97ISYBhFnUPTdvBSKd9cI6GOQPNUprLBXMlhEuGTztdytq7ar4n0jR5So2Z6jQ== X-Received: by 2002:adf:fb51:0:b0:2ce:7219:42b8 with SMTP id c17-20020adffb51000000b002ce721942b8mr17688166wrs.32.1678808421181; Tue, 14 Mar 2023 08:40:21 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:11c3:d4e5:ef75:8eb9? ([2a01:e0a:982:cbb0:11c3:d4e5:ef75:8eb9]) by smtp.gmail.com with ESMTPSA id g10-20020a5d698a000000b002c71a32394dsm2291933wru.64.2023.03.14.08.40.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Mar 2023 08:40:20 -0700 (PDT) Message-ID: <6b7ae52c-d84d-8d08-139c-5c67ec363e85@linaro.org> Date: Tue, 14 Mar 2023 16:40:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v10 3/5] dt-bindings: clock: meson: add A1 PLL and Peripherals clkcs bindings Content-Language: en-US To: Krzysztof Kozlowski , Dmitry Rokosov Cc: jbrunet@baylibre.com, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, khilman@baylibre.com, martin.blumenstingl@googlemail.com, jian.hu@amlogic.com, kernel@sberdevices.ru, rockosov@gmail.com, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230313201259.19998-1-ddrokosov@sberdevices.ru> <20230313201259.19998-4-ddrokosov@sberdevices.ru> <20230314114825.yiv4vcszr6b7m45w@CAB-WSD-L081021> <2d9297e9-dab7-9615-3859-79b3b2980d9a@linaro.org> <20230314150107.mwcglcu2jv4ixy3r@CAB-WSD-L081021> <9d176288-cd7c-7107-e180-761e372a2b6e@linaro.org> <21add21d-4afe-7840-6c49-3786f82761d9@linaro.org> Organization: Linaro Developer Services In-Reply-To: <21add21d-4afe-7840-6c49-3786f82761d9@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/03/2023 16:37, Krzysztof Kozlowski wrote: > On 14/03/2023 16:33, neil.armstrong@linaro.org wrote: >>> There are many ways - depend on your driver. For example like this: >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/samsung/clk-exynos5420.c#n975 >>> >>> The first argument is the clock ID (or ignore). >>> >>> BTW, quite likely the problem is generic to all Meson clock drivers. >> >> This issue about "public" non-continuous defined was already discussed at https://lore.kernel.org/all/c088e01c-0714-82be-8347-6140daf56640@linaro.org/ >> >> I don't see what's different with this one. > > So you are aware that all undocumented clock IDs are still allowed to > use in DTS and they are ABI? Changing them will be an ABI break. Yes of course. Neil > > Best regards, > Krzysztof >