From: Ivan Vecera <ivecera@redhat.com>
To: Jiri Pirko <jiri@resnulli.us>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
sdf@fomichev.me, almasrymina@google.com, asml.silence@gmail.com,
leitao@debian.org, kuniyu@google.com,
linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [RFC PATCH] net: add net-device TX clock source selection framework
Date: Wed, 30 Jul 2025 16:45:18 +0200 [thread overview]
Message-ID: <6b8281b3-a438-4b3e-a8e7-d5043416d421@redhat.com> (raw)
In-Reply-To: <p4tnkuf3zh7ja45d4y2pas6fj6epbqdqdqtfai2vmyul3n43lf@v3e5dvvbphiv>
On 30. 07. 25 2:26 odp., Jiri Pirko wrote:
> Tue, Jul 29, 2025 at 12:45:28PM +0200, arkadiusz.kubalewski@intel.com wrote:
>
> [...]
>
>> User interface:
>> - Read /sys/class/net/<device>/tx_clk/<clock_name> to get status (0/1)
>> - Write "1" to switch to that clock source
>
> I wonder, if someone invented a time machine and sent me back to 2005...
>
> [...]
>
+1
why do we have netlink based interfaces for configuration...?
Wouldn't be better to implement such thing to be configurable via ip
link or ethtool??
E.g.
ip link set eth0 tx-clk <clock_name>
--or--
ethtool --set-tx-clk/--show-tx-clk eth0 <clock_name>
Ivan
next prev parent reply other threads:[~2025-07-30 14:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 10:45 Arkadiusz Kubalewski
2025-07-29 11:16 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-07-30 12:26 ` Jiri Pirko
2025-07-30 14:09 ` Kubalewski, Arkadiusz
2025-07-31 11:02 ` Jiri Pirko
2025-07-30 14:45 ` Ivan Vecera [this message]
2025-07-31 20:36 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b8281b3-a438-4b3e-a8e7-d5043416d421@redhat.com \
--to=ivecera@redhat.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®