From: David Lechner <david@lechnology.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Henry Martin <bsdhenrymartin@gmail.com>,
linux-clk@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Subject: Re: clk: davinci: Add NULL check in davinci_lpsc_clk_register()
Date: Wed, 2 Apr 2025 09:05:50 -0500 [thread overview]
Message-ID: <6b84e7e9-4ea4-4af7-a57b-3959c5bbdd4a@lechnology.com> (raw)
In-Reply-To: <bb7f73c9-c004-4d2f-a54e-285d4753c583@web.de>
On 4/2/25 2:48 AM, Markus Elfring wrote:
>
> Would you like to clarify any more why the function “kzalloc” is still called here
> (instead of the variant “devm_kzalloc”)?
> https://elixir.bootlin.com/linux/v6.14-rc6/source/drivers/clk/davinci/psc.c#L242
It is a case of "if it isn't broke, don't fix it". While there is room for
some small improvements like that, it does come at a cost of time and energy
to make those improvements.
>
> Regards,
> Markus
next prev parent reply other threads:[~2025-04-02 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 13:13 [PATCH v1] " Henry Martin
2025-04-01 14:05 ` David Lechner
2025-04-01 16:46 ` [PATCH] " Markus Elfring
2025-04-01 17:21 ` David Lechner
2025-04-02 7:48 ` Markus Elfring
2025-04-02 14:05 ` David Lechner [this message]
2025-04-24 3:14 ` [PATCH v1] " henry martin
2025-06-19 23:49 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b84e7e9-4ea4-4af7-a57b-3959c5bbdd4a@lechnology.com \
--to=david@lechnology.com \
--cc=Markus.Elfring@web.de \
--cc=bsdhenrymartin@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®