From: Damien Le Moal <dlemoal@kernel.org>
To: Philipp Stanner <phasta@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Hannes Reinecke <hare@suse.de>,
John Garry <john.g.garry@oracle.com>,
Li Zetao <lizetao1@huawei.com>, Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: mtip32xx: Remove unnecessary function calls
Date: Wed, 22 Jan 2025 15:02:19 +0900 [thread overview]
Message-ID: <6b8d974b-58b6-49f7-9101-5fd5c33750d8@kernel.org> (raw)
In-Reply-To: <20250120162020.67024-3-phasta@kernel.org>
On 1/21/25 1:20 AM, Philipp Stanner wrote:
> pcim_iounmap_regions() does not have to be called, because the regions
> are automatically unmapped since they were mapped with managed
> functions. Moreover, that function is deprecated anyways.
>
> Furthermore, setting the drvdata to NULL is unnecessary in a driver
> remove() function.
>
> Remove the unnecessary calls.
>
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
Looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2025-01-22 6:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 16:20 Philipp Stanner
2025-01-22 6:02 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b8d974b-58b6-49f7-9101-5fd5c33750d8@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=phasta@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®