From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE81CC18E5A for ; Tue, 10 Mar 2020 20:15:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8537521655 for ; Tue, 10 Mar 2020 20:15:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Hb9FDy9A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727531AbgCJUPY (ORCPT ); Tue, 10 Mar 2020 16:15:24 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:34026 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727272AbgCJUPX (ORCPT ); Tue, 10 Mar 2020 16:15:23 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 02AKFIv9090192; Tue, 10 Mar 2020 15:15:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1583871318; bh=7NW06bwfj5FntAVsHPeONgq/hzdzS0WeL4eQPv/ypDo=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=Hb9FDy9AOTpR9RF7XWCZ0sPGYoNB66BI4mLMjVKZdeJn9IkyY50/dTQwZyfifn+QJ qi9mPfl3ipmJIHBBDgrqKkrC9QvridbF7otnRE7qL+gAGxdYfeJkhyG/8fORUt+aPF 4DWemgFNLYbg6/8pyTMDRXGsgNIziDstjs8QugCc= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 02AKFIlk071817 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 10 Mar 2020 15:15:18 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Tue, 10 Mar 2020 15:15:18 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Tue, 10 Mar 2020 15:15:18 -0500 Received: from [10.250.65.13] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 02AKFHvJ030430; Tue, 10 Mar 2020 15:15:17 -0500 Subject: Re: [PATCH v4 2/4] power_supply: Add additional health properties to the header To: Sandeep Patil , Sebastian Reichel CC: , , References: <20200116175039.1317-1-dmurphy@ti.com> <20200116175039.1317-3-dmurphy@ti.com> <20200117010658.iqs2zpwl6bsomkuo@earth.universe> <20200306235548.GA187098@google.com> From: Dan Murphy Message-ID: <6b947adc-a176-5fa0-1382-8b08ec3f8b09@ti.com> Date: Tue, 10 Mar 2020 15:09:37 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200306235548.GA187098@google.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello On 3/6/20 5:55 PM, Sandeep Patil wrote: > Hi Sebastian, > > On Fri, Jan 17, 2020 at 02:06:58AM +0100, Sebastian Reichel wrote: >> Hi, >> >> On Thu, Jan 16, 2020 at 11:50:37AM -0600, Dan Murphy wrote: >>> Add HEALTH_WARM, HEALTH_COOL and HEALTH_HOT to the health enum. >>> >>> Signed-off-by: Dan Murphy >>> --- >> Looks good. But I will not merge it without a user and have comments >> for the driver. > Android has been looking for these properties for a while now [1]. > It was added[2] when we saw that the manufacturers were implementing these > properties in the driver. I didn't know the properties were absent upstream > until yesterday. Somebody pointed out in our ongoing effort to make sure > all core kernel changes that android depends on are present upstream. > > I think those values are also propagated in application facing APIs in > Android (but I am not sure yet, let me know if that's something you want > to find out). > > I wanted to chime in and present you a 'user' for this if that helps. We have re-submitted the BQ25150/155 driver that would be the user and we have 2 more for review that will use the new definitions Dan