From: Stephen Boyd <sboyd@kernel.org>
To: Nathan Chancellor <nathan@kernel.org>, mturquette@baylibre.com
Cc: linus.walleij@linaro.org, saravanak@google.com,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH] clk: Avoid invalid function names in CLK_OF_DECLARE()
Date: Thu, 09 Mar 2023 15:39:04 -0800 [thread overview]
Message-ID: <6b9cbb2be5ec087773290af9538f8488.sboyd@kernel.org> (raw)
In-Reply-To: <20230308-clk_of_declare-fix-v1-1-317b741e2532@kernel.org>
Quoting Nathan Chancellor (2023-03-08 12:47:11)
> After commit c28cd1f3433c ("clk: Mark a fwnode as initialized when using
> CLK_OF_DECLARE() macro"), drivers/clk/mvebu/kirkwood.c fails to build:
>
> drivers/clk/mvebu/kirkwood.c:358:1: error: expected identifier or '('
> CLK_OF_DECLARE(98dx1135_clk, "marvell,mv98dx1135-core-clock",
> ^
> include/linux/clk-provider.h:1367:21: note: expanded from macro 'CLK_OF_DECLARE'
> static void __init name##_of_clk_init_declare(struct device_node *np) \
> ^
> <scratch space>:124:1: note: expanded from here
> 98dx1135_clk_of_clk_init_declare
> ^
> drivers/clk/mvebu/kirkwood.c:358:1: error: invalid digit 'd' in decimal constant
> include/linux/clk-provider.h:1372:34: note: expanded from macro 'CLK_OF_DECLARE'
> OF_DECLARE_1(clk, name, compat, name##_of_clk_init_declare)
> ^
> <scratch space>:125:3: note: expanded from here
> 98dx1135_clk_of_clk_init_declare
> ^
> drivers/clk/mvebu/kirkwood.c:358:1: error: invalid digit 'd' in decimal constant
> include/linux/clk-provider.h:1372:34: note: expanded from macro 'CLK_OF_DECLARE'
> OF_DECLARE_1(clk, name, compat, name##_of_clk_init_declare)
> ^
> <scratch space>:125:3: note: expanded from here
> 98dx1135_clk_of_clk_init_declare
> ^
> drivers/clk/mvebu/kirkwood.c:358:1: error: invalid digit 'd' in decimal constant
> include/linux/clk-provider.h:1372:34: note: expanded from macro 'CLK_OF_DECLARE'
> OF_DECLARE_1(clk, name, compat, name##_of_clk_init_declare)
> ^
> <scratch space>:125:3: note: expanded from here
> 98dx1135_clk_of_clk_init_declare
> ^
>
> C function names must start with either an alphabetic letter or an
> underscore. To avoid generating invalid function names from clock names,
> add two underscores to the beginning of the identifier.
>
> Fixes: c28cd1f3433c ("clk: Mark a fwnode as initialized when using CLK_OF_DECLARE() macro")
> Suggested-by: Saravana Kannan <saravanak@google.com>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
Applied to clk-fixes
prev parent reply other threads:[~2023-03-09 23:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 20:47 Nathan Chancellor
2023-03-08 22:37 ` Saravana Kannan
2023-03-09 23:39 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b9cbb2be5ec087773290af9538f8488.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nathan@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®