From: Sohil Mehta <sohil.mehta@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>, <linux-kernel@vger.kernel.org>
Cc: Jiri Kosina <jikos@kernel.org>, <x86@kernel.org>
Subject: Re: [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro
Date: Thu, 27 Jul 2023 15:05:20 -0700 [thread overview]
Message-ID: <6ba4a23c-3b4b-eb7f-0ecb-3b7bf5c4406e@intel.com> (raw)
In-Reply-To: <772ac95d-9eab-2090-245e-fcc40bd7a5da@infradead.org>
On 7/27/2023 2:21 PM, Randy Dunlap wrote:
> On 7/27/23 13:06, Sohil Mehta wrote:
>> I am not sure if a Fixes tag is really needed for a redundant macro
>> definition. If at all, shouldn't it be 874bcd00f520c ("apm-emulation:
>> move APM_MINOR_DEV to include/linux/miscdevice.h") ?
>
> I don't see any need for this patch to be backported.
>
> Should it be commit 874bcd00f520c? Maybe. That one certainly
> missed moving this macro.
>
Also, applying this patch anytime before 874bcd00f520c will cause a
compilation issue unless 874bcd00f520c is applied as well.
-Sohil
next prev parent reply other threads:[~2023-07-27 22:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 23:49 Randy Dunlap
2023-07-27 20:06 ` Sohil Mehta
2023-07-27 21:21 ` Randy Dunlap
2023-07-27 22:05 ` Sohil Mehta [this message]
2023-07-27 22:41 ` Randy Dunlap
2023-07-28 0:58 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ba4a23c-3b4b-eb7f-0ecb-3b7bf5c4406e@intel.com \
--to=sohil.mehta@intel.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®