From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, fenghua.yu@intel.com, vkoul@kernel.org,
dave.jiang@intel.com, tony.luck@intel.com,
wajdi.k.feghali@intel.com, james.guilford@intel.com,
kanchana.p.sridhar@intel.com, vinodh.gopal@intel.com,
giovanni.cabiddu@intel.com, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v7 12/14] crypto: iaa - Add support for deflate-iaa compression algorithm
Date: Sat, 22 Jul 2023 12:14:28 -0500 [thread overview]
Message-ID: <6ba5b58f637e3ec8c4b00e407e18dd426db6086f.camel@linux.intel.com> (raw)
In-Reply-To: <ZLsvdS6NbaetDFe1@gondor.apana.org.au>
On Sat, 2023-07-22 at 13:23 +1200, Herbert Xu wrote:
> On Mon, Jul 10, 2023 at 02:06:52PM -0500, Tom Zanussi wrote:
> >
> > Because the IAA hardware has a 4k history-window limitation, only
> > buffers <= 4k, or that have been compressed using a <= 4k history
> > window, are technically compliant with the deflate spec, which
> > allows
> > for a window of up to 32k. Because of this limitation, the IAA
> > fixed
> > mode deflate algorithm is given its own algorithm name, 'deflate-
> > iaa'.
>
> So compressed results produced by this can always be decompressed
> by the generic algorithm, right?
>
Right.
> If it's only when you decompress that you may encounter failures,
> then I suggest that we still use the same algorithm name, but fall
> back at run-time if the result cannot be decompressed by the
> hardware. Is it possible to fail gracefully and then retry the
> decompression in this case?
>
Yeah, I think that should be possible. I'll try it out and add it to
the next version. Thanks for the suggestion!
Tom
> Thanks,
next prev parent reply other threads:[~2023-07-22 17:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 19:06 [PATCH v7 00/14] crypto: Add Intel Analytics Accelerator (IAA) crypto compression driver Tom Zanussi
2023-07-10 19:06 ` [PATCH v7 01/14] dmaengine: idxd: add wq driver name support for accel-config user tool Tom Zanussi
2023-07-11 17:49 ` Fenghua Yu
2023-07-11 18:57 ` Tom Zanussi
2023-07-10 19:06 ` [PATCH v7 02/14] dmaengine: idxd: add external module driver support for dsa_bus_type Tom Zanussi
2023-07-12 23:13 ` Yu, Fenghua
2023-07-10 19:06 ` [PATCH v7 03/14] dmaengine: idxd: Export drv_enable/disable and related functions Tom Zanussi
2023-07-10 19:06 ` [PATCH v7 04/14] dmaengine: idxd: Export descriptor management functions Tom Zanussi
2023-07-10 19:06 ` [PATCH v7 05/14] dmaengine: idxd: Export wq resource " Tom Zanussi
2023-07-10 19:06 ` [PATCH v7 06/14] dmaengine: idxd: Add wq private data accessors Tom Zanussi
2023-07-12 23:12 ` Yu, Fenghua
2023-07-10 19:06 ` [PATCH v7 07/14] dmaengine: idxd: add callback support for iaa crypto Tom Zanussi
2023-07-10 19:06 ` [PATCH v7 08/14] crypto: iaa - Add IAA Compression Accelerator Documentation Tom Zanussi
2023-07-10 19:06 ` [PATCH v7 09/14] crypto: iaa - Add Intel IAA Compression Accelerator crypto driver core Tom Zanussi
2023-07-10 19:06 ` [PATCH v7 10/14] crypto: iaa - Add per-cpu workqueue table with rebalancing Tom Zanussi
2023-07-10 19:06 ` [PATCH v7 11/14] crypto: iaa - Add compression mode management along with fixed mode Tom Zanussi
2023-07-10 19:06 ` [PATCH v7 12/14] crypto: iaa - Add support for deflate-iaa compression algorithm Tom Zanussi
2023-07-17 2:12 ` Rex Zhang
2023-07-17 21:35 ` Tom Zanussi
2023-07-22 1:23 ` Herbert Xu
2023-07-22 17:14 ` Tom Zanussi [this message]
2023-07-10 19:06 ` [PATCH v7 13/14] crypto: iaa - Add irq support for the crypto async interface Tom Zanussi
2023-07-10 19:06 ` [PATCH v7 14/14] crypto: iaa - Add IAA Compression Accelerator stats Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ba5b58f637e3ec8c4b00e407e18dd426db6086f.camel@linux.intel.com \
--to=tom.zanussi@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=james.guilford@intel.com \
--cc=kanchana.p.sridhar@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=vinodh.gopal@intel.com \
--cc=vkoul@kernel.org \
--cc=wajdi.k.feghali@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®