From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C0AC16DC12 for ; Wed, 5 Mar 2025 18:42:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741200161; cv=none; b=OWIqVX0z10fEVCXwXT7bzqzT75fJ+Ni0Cri9Jjy122JCBIlu/v9NRJy+EzWlw9swwd5iDGNfrs5oYSP1t5lbEBpDqGS41EMkFWxYzGsNWhXMQ6LY7YeGwpx+0vTd1BYGkqGOWINQBr6LbUAuRNlISbZyUIYdIS+bKOO7VrcDQ2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741200161; c=relaxed/simple; bh=C3OFfJZmcjoi5VkDHSmacnWyhu3vxFu+FcNtSp8imTg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EFdBiQ6GoYPiyaD2ky1TWhnZzIrsyjOD/oda80Mw3LU2ylykQx54dz1ChC2XZIyIhu5cZImqbMEgt9X1C0B4kquDlHquau13kyGvlepV3CxaSAHSQT8m0um8t9HO3HMYU+ldUHf5yjuLgXKK7gCD7CuQMU57OVMwrgMdUc7HSMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com; spf=pass smtp.mailfrom=cloud.com; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b=gTx4hiB7; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=citrix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="gTx4hiB7" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-abf6f3b836aso636119066b.3 for ; Wed, 05 Mar 2025 10:42:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1741200157; x=1741804957; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=IVUFVvCVdIl/aQ7JSL2VcbMfl65AWHm3sfvYPRJX9q0=; b=gTx4hiB7AX7SCJRkHu+Oo3og6p4xKIK7eztrOwSIbDDfZQrx7vjvoM7NXTB+rkTlo8 Vovv+D+2zUnt80IU47Y5Tc48UyFmYheLtLPTmunbBF5Bivq8LISRODkqs3GRh0cY4cnj kNZtkHJu5+/i6Wy+bHB4WnGS6R1BkJxh+1v/w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741200157; x=1741804957; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IVUFVvCVdIl/aQ7JSL2VcbMfl65AWHm3sfvYPRJX9q0=; b=dmMKiCfSWLhewAL85QmOfFtmovEgn+teHME5ZAFcSHtxZpgIVePar9E/xKgdjYqgoW XSQwSOxfdhgTAuU+Iuil4I/pSqPQC6l7yOJwEbhvAznYKV3qVythKm79Ocvkqn8uVCB0 UA3BmPPo7XpaWJdNGO5u+7Kuof/urzQOO/azh0CBcGI5/hX8+ra6imV4nEG1wMN0corq OzizVPT/rdAoAqE076NfU4OHj36AyIOUVn92tZTsVR7HCQ2NNAcPQ4h811Tx+79oDT/v cTHjPFIiZEeUPp0TbbRzRGPYU3K417ptXlqFLL4Pbe/Vn3yFRvS1EQnD3N5lTaNohGW9 JAjg== X-Forwarded-Encrypted: i=1; AJvYcCV7zfThJBRrHVPOXpdIIjWEV6/7dnh3//v2L5JGkZNfOpSLhnULD6xFjgF/nufy7UHQH9BGV87tzGFJwzI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2VnhFkWMw0Gw+jWsAXHVpSsptSW7Ww0PwJXCfDdeODkj31jft l0eG1QS2r7wW9FmWsoRyp8ZYecc8hN70f6puSYey0yi+3B0bgyYaZWqGobNGYPTtPE8AuAls2Au b X-Gm-Gg: ASbGncsHuDqm0ruvlvK/mfmouOFGhWH5p2eFZfdyZJwjcSOzZNtNmEfqIzmUXpPCZPA bBNq8au62bIm13HnM953Q//gIE2w1l7MZcnpyNPIktBzp8f0hCfEb0ZWYBrSFleytQg3Pu/YS7q Yjqp4wPmWokTcqa/Mx6fSv2zGSB6ZwV/2NtrAOOWO3eV7IEvQiESXDVaRP88eJozs0X9OLBdnpz f+Bp9OTJ6vjPWIkMFhPgBGEqeQrn2/d3tBVRnqXNsIJDVZiJHHmn+mRUgklqNa8fR/pibp8tYBp WQKUj1+4rz8K0lduwujqD687tsYSEkhtIa+b1ElJDJgejgWmenxh/kQd3Lk2aSEyjT/JQfVt0WO oy/ItSV6q X-Google-Smtp-Source: AGHT+IEZpgDR+wmpmO+wAvktLUsZOtdTQR7f1UCkOp9WGn+PBTvrfUQA/8nArTd60ZcaRcp0uYX5JA== X-Received: by 2002:a17:907:c283:b0:abf:67de:2f21 with SMTP id a640c23a62f3a-ac20d9f39bamr383948566b.22.1741200157342; Wed, 05 Mar 2025 10:42:37 -0800 (PST) Received: from [192.168.1.10] (host-92-26-98-202.as13285.net. [92.26.98.202]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf75c6d4f3sm590789766b.184.2025.03.05.10.42.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Mar 2025 10:42:36 -0800 (PST) Message-ID: <6ba638d3-b3a3-410b-9761-0b3658e3215a@citrix.com> Date: Wed, 5 Mar 2025 18:42:36 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 37/40] x86/cacheinfo: Extract out cache self-snoop checks To: "Ahmed S. Darwish" Cc: Borislav Petkov , Ingo Molnar , Dave Hansen , Thomas Gleixner , John Ogness , "H. Peter Anvin" , x86@kernel.org, x86-cpuid@lists.linux.dev, LKML References: <20250304085152.51092-1-darwi@linutronix.de> <20250304085152.51092-38-darwi@linutronix.de> <01367a6b-8eeb-417e-9a66-e7a64d518319@citrix.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 05/03/2025 6:40 pm, Ahmed S. Darwish wrote: > Hi Andrew, > > On Tue, 04 Mar 2025, Andrew Cooper wrote: >> On 04/03/2025 8:51 am, Ahmed S. Darwish wrote: >>> The logic of not doing a cache flush if the CPU declares cache self >>> snooping support is repeated across the x86/cacheinfo code. Extract it >>> into its own function. >>> >>> Signed-off-by: Ahmed S. Darwish >> I know you're just refactoring code, but the SDM has basically reverted >> this statement about it being safe to skip WBINVD based on SELFSNOOP. >> > Still, thanks a lot for sharing :) > >> It turns out not to be safe in cases where the underlying physical >> memory changes from cacheable to unchangeable.  By skipping the WBINVD >> as part of changing the memory type, you end up with spurious writebacks >> at a later point when the memory is expected to be UC.  Apparently this >> is a problem for CLX devices, hence the change in the SDM. > While writing that refactoring patch, I indeed noticed that there is an > errata list of CPUs where X86_FEATURE_SELFSNOOP is force disabled, thus > ensuring WBINVD is never skipped: > > static void check_memory_type_self_snoop_errata(...) > { > switch (c->x86_vfm) { > case INTEL_CORE_YONAH: > case INTEL_CORE2_MEROM: > case INTEL_CORE2_MEROM_L: > case INTEL_CORE2_PENRYN: > case INTEL_CORE2_DUNNINGTON: > case INTEL_NEHALEM: > case INTEL_NEHALEM_G: > case INTEL_NEHALEM_EP: > case INTEL_NEHALEM_EX: > case INTEL_WESTMERE: > case INTEL_WESTMERE_EP: > case INTEL_SANDYBRIDGE: > setup_clear_cpu_cap(X86_FEATURE_SELFSNOOP); > } > } > > That's why I added "CPUs without known erratas" in the comments: > > /* > * Cache flushing is the most time-consuming step when programming > * the MTRRs. On many Intel CPUs without known erratas, it can be > * skipped if the CPU declares cache self-snooping support. > */ > static void maybe_flush_caches(void) > { > if (!static_cpu_has(X86_FEATURE_SELFSNOOP)) > wbinvd(); > } > > But, interestingly, CLX devices (intel-family.h CASCADELAKE_X / > SKYLAKE_X) are not part of the kernel's Self Snoop errata list above. CLX (Cascade Lake) != CXL (Compute eXpress Link). CXL is the new PCIe.  (So say the CXL consortium at least.) ~Andrew