From: Florian Fainelli <f.fainelli@gmail.com>
To: 马强 <maqianga@uniontech.com>, "Andrew Lunn" <andrew@lunn.ch>
Cc: davem <davem@davemloft.net>, netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Ming Wang <wangming01@loongson.cn>
Subject: Re: [PATCH] net: phy: fix autoneg invalid error state of GBSR register.
Date: Wed, 1 Sep 2021 07:55:17 -0700 [thread overview]
Message-ID: <6bac579b-5261-f96b-7a26-61cfe5f8ce87@gmail.com> (raw)
In-Reply-To: <tencent_312431A93CE3F240692EF111@qq.com>
On 9/1/2021 6:40 AM, 马强 wrote:
> > > > It looks like you are using an old tree.
> > > Yes, it is linux-4.19.y, since 4.19.y does not have
> autoneg_complete flag,，
> > > This patch adds the condition before
> > > reading GBSR register to fix this error state.
> >
> > So you first need to fix it in net/master, and then backport it to
> > older kernels.
>
> This patch is modified according to the contents of the latest kernels,
> the following is a reference:
> [ Upstream commit b6163f194c699ff75fa6aa4565b1eb8946c2c652 ]
> [ Upstream commit 4950c2ba49cc6f2b38dbedcfa0ff67acf761419a ]
Then you need to be extremely clear in the commit message which specific
branch you are targeting, which commits you used as a reference, and how
you are fixing the problem. Also, the register is commonly named BMSR
(Basic Mode Status Register), no idea what GBSR means.
--
Florian
prev parent reply other threads:[~2021-09-01 14:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210901105608.29776-1-maqianga@uniontech.com>
2021-09-01 12:43 ` Andrew Lunn
[not found] ` <tencent_405C539D1A6BA06876B7AC05@qq.com>
2021-09-01 13:01 ` Andrew Lunn
2021-09-01 14:39 ` Jakub Kicinski
[not found] ` <tencent_312431A93CE3F240692EF111@qq.com>
2021-09-01 14:55 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bac579b-5261-f96b-7a26-61cfe5f8ce87@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maqianga@uniontech.com \
--cc=netdev@vger.kernel.org \
--cc=wangming01@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®