From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A09AEC43460 for ; Tue, 6 Apr 2021 13:41:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B0E2613C3 for ; Tue, 6 Apr 2021 13:41:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344587AbhDFNlH (ORCPT ); Tue, 6 Apr 2021 09:41:07 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:2769 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238827AbhDFNlG (ORCPT ); Tue, 6 Apr 2021 09:41:06 -0400 Received: from fraeml745-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FF7lp74C9z682sK; Tue, 6 Apr 2021 21:33:58 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml745-chm.china.huawei.com (10.206.15.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 6 Apr 2021 15:40:56 +0200 Received: from [10.210.166.136] (10.210.166.136) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 6 Apr 2021 14:40:55 +0100 Subject: Re: [PATCH v2 2/6] perf test: Handle metric reuse in pmu-events parsing test To: Jiri Olsa CC: , , , , , , , , , , , , , , , , References: <1616668398-144648-1-git-send-email-john.garry@huawei.com> <1616668398-144648-3-git-send-email-john.garry@huawei.com> <49025439-f9e3-0d32-b0a3-ff9f9ff71835@huawei.com> From: John Garry Message-ID: <6bb503e4-8d75-62a6-3c10-8478df9c3e44@huawei.com> Date: Tue, 6 Apr 2021 14:38:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.210.166.136] X-ClientProxiedBy: lhreml711-chm.china.huawei.com (10.201.108.62) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/04/2021 14:34, Jiri Olsa wrote: >> >> } >> >> So once we evaluate a pmu_event in pctx->ids in @pe, @all is set false, and >> we would loop again in the do-while loop, regardless of what >> expr__find_other() does (apart from erroring), and so call >> hashmap__for_each_entry_safe(&pctx->ids, ) again. > ah ok, so it finishes the hash iteration first and > then restarts it.. ok, I missed that, then it's fine > >> This is really what is done in __resolve_metric() - indeed, I would use that >> function directly, but it looks hard to extract that from metricgroup.c . > yea, it's another world;-) it's better to keep it separated ok, so I'll still add the break statement, as suggested. I'll also wait to see if Ian or you have a strong feeling about the function naming in patch 1/6. Thanks, John