From: ascordeiro <alinesantanacordeiro@gmail.com>
To: Ezequiel Garcia <ezequiel@collabora.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 1/2 v2] staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h
Date: Thu, 08 Apr 2021 14:41:10 -0300 [thread overview]
Message-ID: <6bba0e0a5768e902ffec4bda563d4ca810412f84.camel@gmail.com> (raw)
In-Reply-To: <d4000598fddcf45e578462aa04b556c0ca057091.camel@collabora.com>
Em qui, 2021-04-08 às 13:20 -0300, Ezequiel Garcia escreveu:
> Ola Aline,
Ola Ezequiel,
> Welcome to the kernel community. Hope you enjoy some of this
> Outreachy adventures.
Thank you!
> Normally, when you submit a v2, we want to know what changed
> between the first submission and v2.
>
> If you are subscribed to linux-media, you can read some
> of the series with a vN+1 and look how it's done. Examples:
>
> https://www.spinics.net/lists/linux-media/msg190043.html
>
> https://www.spinics.net/lists/linux-media/msg189923.html
>
> I'm sure your Outreachy mentors can tell you more.
Thank you for the examples, it won't happen again.
The reason for sending a v2 is that I sent my very first patchset
yesterday and I sent the cover-letter together, but (I think) I wasn't
supposed to, and as the patches weren't marked as [PATCH 1/2] and
[PATCH 2/2] in the email - since I commited all the files with the same
message - I tought it was wrong and sent again today.
However, I just realized that I've changed just the subject of the e-
mail, but I would've to change the commit message, right? And then, it
would be a second version, am I right?
Thank you in advance,
> On Thu, 2021-04-08 at 11:07 -0300, Aline Santana Cordeiro wrote:
> > Aligns line break with the remaining function arguments
> > to the open parenthesis. Issue found by checkpatch.
> >
> > Signed-off-by: Aline Santana Cordeiro <
> > alinesantanacordeiro@gmail.com>
> > ---
> > drivers/staging/media/hantro/hantro_hw.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/hantro/hantro_hw.h
> > b/drivers/staging/media/hantro/hantro_hw.h
> > index 34c9e46..a650b9c 100644
> > --- a/drivers/staging/media/hantro/hantro_hw.h
> > +++ b/drivers/staging/media/hantro/hantro_hw.h
> > @@ -207,7 +207,7 @@ hantro_h264_mv_size(unsigned int width,
> > unsigned int height)
> > void hantro_g1_mpeg2_dec_run(struct hantro_ctx *ctx);
> > void rk3399_vpu_mpeg2_dec_run(struct hantro_ctx *ctx);
> > void hantro_mpeg2_dec_copy_qtable(u8 *qtable,
> > - const struct v4l2_ctrl_mpeg2_quantization *ctrl);
> > + const struct
> > v4l2_ctrl_mpeg2_quantization *ctrl);
> > int hantro_mpeg2_dec_init(struct hantro_ctx *ctx);
> > void hantro_mpeg2_dec_exit(struct hantro_ctx *ctx);
> >
>
>
next prev parent reply other threads:[~2021-04-08 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1617890467.git.alinesantanacordeiro@gmail.com>
2021-04-08 14:07 ` Aline Santana Cordeiro
2021-04-08 16:20 ` Ezequiel Garcia
2021-04-08 17:41 ` ascordeiro [this message]
2021-04-09 8:25 ` [Outreachy kernel] " Vaishali Thakkar
2021-04-09 11:53 ` ascordeiro
2021-04-09 17:39 ` Julia Lawall
2021-04-08 14:07 ` [PATCH 2/2 v2] staging: media: hantro: Align line break to the open parenthesis in file hantro_mpeg2.c Aline Santana Cordeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bba0e0a5768e902ffec4bda563d4ca810412f84.camel@gmail.com \
--to=alinesantanacordeiro@gmail.com \
--cc=ezequiel@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®