From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932177AbdJWVrI (ORCPT ); Mon, 23 Oct 2017 17:47:08 -0400 Received: from mail1.skidata.com ([91.230.2.99]:57123 "EHLO mail1.skidata.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751282AbdJWVrF (ORCPT ); Mon, 23 Oct 2017 17:47:05 -0400 X-IronPort-AV: E=Sophos;i="5.43,424,1503352800"; d="scan'208";a="6736293" Subject: Re: [PATCH 02/10 v3] usb: usb251xb: Add USB2517i specific struct and IDs To: Serge Semin , , , CC: , , , References: <20170916104220.3742-1-fancer.lancer@gmail.com> <20171022203812.9379-1-fancer.lancer@gmail.com> <20171022203812.9379-3-fancer.lancer@gmail.com> From: Richard Leitner Message-ID: <6bbb6ef6-41bc-a30b-8baf-80f765320d97@skidata.com> Date: Mon, 23 Oct 2017 23:47:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171022203812.9379-3-fancer.lancer@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.24.97] X-ClientProxiedBy: sdex1srv.skidata.net (172.16.10.92) To sdex2srv.skidata.net (172.16.10.93) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, please see comments below for some nit-picks. On 10/22/2017 10:38 PM, Serge Semin wrote: > There are USB2517 and USB2517i hubs, which have almost the same > registers space as already supported USB251xBi series. The difference > it in DIDs and in a few functions. This patch adds the USB2517/i data > structures to the driver, so it would have different setting depending > on the device discovered on i2c-bus. > > Signed-off-by: Serge Semin > --- > drivers/usb/misc/Kconfig | 4 ++-- > drivers/usb/misc/usb251xb.c | 23 +++++++++++++++++++++-- > 2 files changed, 23 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig > index 37dd1c018..27b9fcbdf 100644 > --- a/drivers/usb/misc/Kconfig > +++ b/drivers/usb/misc/Kconfig > @@ -247,8 +247,8 @@ config USB_HUB_USB251XB > depends on I2C > help > This option enables support for configuration via SMBus of the > - Microchip USB251xB/xBi USB 2.0 Hub Controller series. > - Configuration parameters may be set in devicetree or platform data. > + Microchip USB251x/xBi USB 2.0 Hub Controller series. Configuration > + parameters may be set in devicetree or platform data. Here you have "USB251x/xBi"... > Say Y or M here if you need to configure such a device via SMBus. > > config USB_HSIC_USB3503 > diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c > index 91f66d68b..22c32ea3f 100644 > --- a/drivers/usb/misc/usb251xb.c > +++ b/drivers/usb/misc/usb251xb.c ... > @@ -82,7 +83,7 @@ > > #define USB251XB_ADDR_PRODUCT_STRING_LEN 0x14 > #define USB251XB_ADDR_PRODUCT_STRING 0x54 > -#define USB251XB_DEF_PRODUCT_STRING "USB251xB/xBi" > +#define USB251XB_DEF_PRODUCT_STRING "USB251xB/xBi/7i" but here you have "USB251xB/xBi/7i"... > > #define USB251XB_ADDR_SERIAL_STRING_LEN 0x15 > #define USB251XB_ADDR_SERIAL_STRING 0x92 ... > @@ -590,5 +609,5 @@ static struct i2c_driver usb251xb_i2c_driver = { > module_i2c_driver(usb251xb_i2c_driver); > > MODULE_AUTHOR("Richard Leitner "); > -MODULE_DESCRIPTION("USB251xB/xBi USB 2.0 Hub Controller Driver"); > +MODULE_DESCRIPTION("USB251x/xBi USB 2.0 Hub Controller Driver"); ... and here again "USB251x/xBi"... > MODULE_LICENSE("GPL"); > I'd prefer to use just one "name" for the driver. If you be precise that would be "USB251xB/xBi/xi". But that seems a bit overloaded to me. AFAIK the "B" and "i" prepended to the type have no affect on the I2C interface/register map, so maybe "USB251x" would be sufficient? kind regards, Richard.L