From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A4613A9D99 for ; Tue, 20 Jan 2026 09:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768900039; cv=none; b=ucB2Cp6mBrU2sPNf1OMQ4NJtXi0F1P5bCXj9qg0i4Dv4SWq8QGMQ4/Vdh/2JFXm4rKYcRApXdysZJ3pk5tQMIT0yVwKZlF0p97xHDjXldfnvd/Etv/IWNdZnzgvnBK6xTnEHJkNR4N2ew2YOhRSNh5/XxGcPQaTwPA4L5y2MAxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768900039; c=relaxed/simple; bh=oE5Nuk5dZdqc2wTwq+n3EtHlcxAmrXTIrEu9DdhxhhU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=e6LllveFmKzdlUH3z2cdMDVjdvM8eM2OJ5dTRFx3Z9jkKcpQo/V/0WFzDdwO/QLGcKuS5MWPW3IUQrb60bczKFXXMNTBltIi6k77gcWu2U/gx74L7DXe4V0KpdCi0ZfKYbzveJQZJeToOPGTGSeVg4dq9Lj8E8yoCGOL2+mh6DM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SrsW+YEu; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=HDZQOwTK; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SrsW+YEu"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="HDZQOwTK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768900036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oE5Nuk5dZdqc2wTwq+n3EtHlcxAmrXTIrEu9DdhxhhU=; b=SrsW+YEung9V48xa9KcoAtotX14Y6lIElpT3TEQqNeLEPEc3Pi0wWVt3AtocS86mDlukSI xZPshjEsB3CyvA86VPLhcd3qlU6TgHoyV6DZ1tt86XcHfiXHS/ip1U5Seb2611RnSveGE5 7gJxhAnSnb77dsB6LWpwjJaVL7MT2zQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-7-J7FKz6QaPL6UFwUnGWcbkQ-1; Tue, 20 Jan 2026 04:07:13 -0500 X-MC-Unique: J7FKz6QaPL6UFwUnGWcbkQ-1 X-Mimecast-MFC-AGG-ID: J7FKz6QaPL6UFwUnGWcbkQ_1768900032 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-47ee432070aso30109025e9.1 for ; Tue, 20 Jan 2026 01:07:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768900032; x=1769504832; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=oE5Nuk5dZdqc2wTwq+n3EtHlcxAmrXTIrEu9DdhxhhU=; b=HDZQOwTK/l+uJNJ1zicmjcoQn7A3Xlr+PVfp3ywEGt4U6qdvv+lqHdU+AV9ySEc9TV tFG+icFuN2gyHMfjW9Q7kG6/SnS+yopa+UXTvIR7YcfeL4miLkyHxXiiwUAoupVV1QIr N1Y8gJFkXXDdGyvPzufAEIrLnxA9VVR2z7fb7edvM7g9wdMgy726OHD9iP+IF+msi8Pd zzhcnN7W6YMZPRotplmXbYkYF7242hI1y07uU2SRguVixATLH0A6iulUHZ08N9qiwfbl 2byBorEj2CFyvAUUY7P8kvcVlJ6Ul+f377dgEw03TzV9EoMq0DZ/oX2oBuVBdn6dFh6r ZpbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768900032; x=1769504832; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oE5Nuk5dZdqc2wTwq+n3EtHlcxAmrXTIrEu9DdhxhhU=; b=B7KFdlAwx+BLXkry/frMD5OrzPkCY8/AtN9X2BjKNYoPO9mC/w+30QknLC1sja9ruX DVSHqAbJxdJ+hrLt3m4n9YzeIEr1o163VZ61p4xRRudn4Gk0Gsv+bFUYuVmgFU9UHfp3 nITgJwprUM1SmkuX5liHpvZcDZLtTtEq0Ld6YPbVZLkrBYSDgyLXGrJ7tGXpR5yGGQXN ReJDhDN+hFm3aDiLaQxfAgINOiddWv4BJP8a0RDV0cNz5JqNi7OkgmREDAbmFqlBTCm6 b/5SZv+AXuYK+lA/rOqVixJfNA4xyApXCLUBS0ns/2ZjvUf2YPnc0hjtjkYpINbzQPJ7 vy3w== X-Forwarded-Encrypted: i=1; AJvYcCXZoP1OoiHxbdfCRdnlwya9ugAFbrGR3n6Rk7q5fowZbt7oo2+XcqubGQ8I7T1HTiz96YPzQNCOAXXjEsE=@vger.kernel.org X-Gm-Message-State: AOJu0Yzf3rrL7z8qzoAir4M7+QduU27UKd5EeMgkADykU1BwR0oaT8vF lBUJqPoKQtirJGWLVaCrQWjlTLezX163GpupELuZ6HDMniURxjZR2iTRe1YaQ6skHXfH8yOo+pH Mzjqp1prmVnHYu1lqthXM7Xr6MlH6cjniGFwLxaeLArhMV3ODUbQRxkoitWDAeXVnCzxanLokG4 c4 X-Gm-Gg: AY/fxX5yzN9NLbIteTXiKPRIk8diORWsdpr+TxLbJZFdJj0gjRlJkg8NtQRrJMfuTos NVGPG9UlHx05GQHVVLgzgReRDWHVQa7QOr0XEzM9TfnlZg47X/uS8pvWOBw1GQv6lDQeZYKFFI6 uW0f9FyVk2RV9EyUqJvRCLGjtF5fkBh6BW4kA8g6t+fMG+Zvdd2T0r+F7UC4fBiEPkfgbiEYXRK YJfCu7EmJAzxGKL1MJKOeIUnC+mkQ5d0lhJSWUrU4aG22T5kV+rYJ+3+ll0SOeI3HxUpJLluTF2 qN9vcyX9NKHtEoJ16QHlamotNulpyfqxBTuIx5hInlTRTgaKQBeZ0VI35rGIfrunlO5BPUtMBig rEIju61slbQZgsvzuD1YVO3ejG2R37VpmcJWoDPcQMXdG//O0hVzIAauWnfHI/PqUfCUco2t2f9 FzAHLPUbU5 X-Received: by 2002:a05:600c:4691:b0:480:1c10:5633 with SMTP id 5b1f17b1804b1-4803b9d6ad6mr44169845e9.26.1768900032028; Tue, 20 Jan 2026 01:07:12 -0800 (PST) X-Received: by 2002:a05:600c:4691:b0:480:1c10:5633 with SMTP id 5b1f17b1804b1-4803b9d6ad6mr44169445e9.26.1768900031688; Tue, 20 Jan 2026 01:07:11 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f429071besm289368985e9.10.2026.01.20.01.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 01:07:11 -0800 (PST) Message-ID: <6bbc5b118542b3c95bb9a46a49ce07337c34e6c0.camel@redhat.com> Subject: Re: [PATCH 24/26] rv/rvgen: make monitor arguments required in rvgen From: Gabriele Monaco To: Wander Lairson Costa Cc: Steven Rostedt , Nam Cao , open list , "open list:RUNTIME VERIFICATION (RV)" Date: Tue, 20 Jan 2026 10:07:10 +0100 In-Reply-To: <20260119205601.105821-25-wander@redhat.com> References: <20260119205601.105821-1-wander@redhat.com> <20260119205601.105821-25-wander@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-01-19 at 17:46 -0300, Wander Lairson Costa wrote: > Add required=3DTrue to the monitor subcommand arguments for class, spec, > and monitor_type in rvgen. These arguments are essential for monitor > generation and attempting to run without them would cause AttributeError > exceptions later in the code when the script tries to access them. >=20 > Making these arguments explicitly required provides clearer error > messages to users at parse time rather than cryptic exceptions during > execution. This improves the user experience by catching missing > arguments early with helpful usage information. >=20 > Signed-off-by: Wander Lairson Costa Good catch, thanks! Reviewed-by: Gabriele Monaco > --- > =C2=A0tools/verification/rvgen/__main__.py | 7 ++++--- > =C2=A01 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/tools/verification/rvgen/__main__.py > b/tools/verification/rvgen/__main__.py > index eeeccf81d4b90..f3e79b14c5d5d 100644 > --- a/tools/verification/rvgen/__main__.py > +++ b/tools/verification/rvgen/__main__.py > @@ -28,10 +28,11 @@ if __name__ =3D=3D '__main__': > =C2=A0=C2=A0=C2=A0=C2=A0 monitor_parser.add_argument('-n', "--model_name"= , dest=3D"model_name") > =C2=A0=C2=A0=C2=A0=C2=A0 monitor_parser.add_argument("-p", "--parent", de= st=3D"parent", > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 required=3DFalse, help=3D"Cre= ate a monitor nested > to parent") > -=C2=A0=C2=A0=C2=A0 monitor_parser.add_argument('-c', "--class", dest=3D"= monitor_class", > +=C2=A0=C2=A0=C2=A0 monitor_parser.add_argument('-c', "--class", dest=3D"= monitor_class", > required=3DTrue, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 help=3D"Monitor class, either= \"da\" or > \"ltl\"") > -=C2=A0=C2=A0=C2=A0 monitor_parser.add_argument('-s', "--spec", dest=3D"s= pec", help=3D"Monitor > specification file") > -=C2=A0=C2=A0=C2=A0 monitor_parser.add_argument('-t', "--monitor_type", d= est=3D"monitor_type", > +=C2=A0=C2=A0=C2=A0 monitor_parser.add_argument('-s', "--spec", dest=3D"s= pec", required=3DTrue, > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 help=3D"Monitor specification file"= ) > +=C2=A0=C2=A0=C2=A0 monitor_parser.add_argument('-t', "--monitor_type", d= est=3D"monitor_type", > required=3DTrue, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 help=3Df"Available options: {= ', > '.join(Monitor.monitor_types.keys())}") > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0 container_parser =3D subparsers.add_parser("cont= ainer")