From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752448AbdKJLJ6 (ORCPT ); Fri, 10 Nov 2017 06:09:58 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:55219 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbdKJLJ5 (ORCPT ); Fri, 10 Nov 2017 06:09:57 -0500 Subject: Re: [PATCH] gpio: davinci: Assign first bank regs for unbanked case To: CC: , , References: <1510312027-28543-1-git-send-email-j-keerthy@ti.com> From: Keerthy Message-ID: <6bc4bbb6-872d-1b49-cb6d-c71f769a1a15@ti.com> Date: Fri, 10 Nov 2017 16:39:53 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1510312027-28543-1-git-send-email-j-keerthy@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 10 November 2017 04:37 PM, Keerthy wrote: > From: "J, KEERTHY" Linus, The $Author field is somehow messed up. Please ignore. I will send v2 with this fixed. Regards, Keerthy > > As per the re-design assign the first bank regs for unbanked > irq case. This was missed out in the original patch. > > Signed-off-by: Keerthy > Fixes: b5cf3fd827d2e1 ("gpio: davinci: Redesign driver to accommodate ngpios in one gpio chip") > --- > drivers/gpio/gpio-davinci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c > index f75d844..e4b3d7d 100644 > --- a/drivers/gpio/gpio-davinci.c > +++ b/drivers/gpio/gpio-davinci.c > @@ -383,7 +383,7 @@ static int gpio_irq_type_unbanked(struct irq_data *data, unsigned trigger) > u32 mask; > > d = (struct davinci_gpio_controller *)irq_data_get_irq_handler_data(data); > - g = (struct davinci_gpio_regs __iomem *)d->regs; > + g = (struct davinci_gpio_regs __iomem *)d->regs[0]; > mask = __gpio_mask(data->irq - d->base_irq); > > if (trigger & ~(IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING)) >